Bug 556110

Summary: Custom service and system services both show all services
Product: [openSUSE] openSUSE 11.2 Reporter: Klaus Kämpf <kkaempf>
Component: WebYaSTAssignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Critical    
Priority: P1 - Urgent CC: lslezak, mvidner
Version: RC 2   
Target Milestone: Final   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: screenshot

Description Klaus Kämpf 2009-11-17 13:30:44 UTC
Custom service should only show a single service
Comment 1 Jiří Suchomel 2009-11-18 07:33:43 UTC
Custom service show what you have configured in the config file, /etc/webyast/custom_services.yml.

If there is one service, it will show one service.
If there are more, show more of them.


So, the question is, if we should provide example custom_services.yml just like we are doing it now? Or should we provide empty file, and show an info that no service is defined?
Comment 2 Jiří Suchomel 2009-11-18 07:39:25 UTC
Created attachment 328069 [details]
screenshot

We could show something like this.
Comment 3 Jiří Suchomel 2009-11-18 07:40:47 UTC
(In reply to comment #2)

> We could show something like this.

This is quite general message, however, the technical details are described in the README files, so I think they do not belong here...
Comment 4 Klaus Kämpf 2009-11-18 10:25:51 UTC
Solution of comment #2 is fine.

The main bug currently is that 'system services' and 'custom service' both show _all_ services. There is no visible difference.

(Inclusion of system services in RC2 was a bug, this has been fixed meanwhile. So only custom services will be available)
Comment 5 Jiří Suchomel 2009-11-18 10:37:14 UTC
Sorry, but one more needinfo, to make it clear.

(In reply to comment #4)
> Solution of comment #2 is fine.
> 
> The main bug currently is that 'system services' and 'custom service' both show
> _all_ services. There is no visible difference.
>
> (Inclusion of system services in RC2 was a bug, this has been fixed meanwhile.
> So only custom services will be available)

Uh, do I understand it right, that the orginal report is invalid? (The bug _is_ vs. inclusion _was_)

(If it still happens, this is relevant:

What is actually "RC2"? I'm testing Signed_WebYaST_on_SLES11-0.12.0 image and here I only see those 2 preconfigured services.

What URL do you have after clicking Custom Service? Is "custom=1" parameter there?)


I assume that the answer for comment 1 is  that we should _not_ provide any pre-defined services as example: Martin, could you remove that custom_services.xml?
Comment 6 Martin Vidner 2009-11-18 11:02:18 UTC
(In reply to comment #5)
> I assume that the answer for comment 1 is  that we should _not_ provide any
> pre-defined services as example: Martin, could you remove that
> custom_services.xml?

Removed from both appliances on iStudio: [Signed_]WebYaST_on_SLES11
Comment 7 Klaus Kämpf 2009-11-18 11:23:44 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > I assume that the answer for comment 1 is  that we should _not_ provide any
> > pre-defined services as example: Martin, could you remove that
> > custom_services.xml?
> 
> Removed from both appliances on iStudio: [Signed_]WebYaST_on_SLES11

Err, why is it  custom_services.XML and not  custom_services.YML ? Or is it a typo ?

In any case, I'd suggest to leave the  custom_services file in but with services commented out. Then its much easier for vendors to understand the file's contents
Comment 8 Klaus Kämpf 2009-11-18 11:26:15 UTC
(In reply to comment #5)
> 
> Uh, do I understand it right, that the orginal report is invalid? (The bug _is_
> vs. inclusion _was_)

Its two bugs

1. system services included in webyast for appliances. This is fixed.
2. system services and custom service showing exactly the same output, namely full list of all services. And, yes, 'custom=1' is shown in the url.

> 
> (If it still happens, this is relevant:
> 
> What is actually "RC2"? I'm testing Signed_WebYaST_on_SLES11-0.12.0 image and
> here I only see those 2 preconfigured services.

It's 'git master' on opensuse 11.2 

> 
> What URL do you have after clicking Custom Service? Is "custom=1" parameter
> there?)

Yes.
Comment 9 Jiří Suchomel 2009-11-18 11:38:44 UTC
(In reply to comment #7)

> > > custom_services.xml?
> > 
> > Removed from both appliances on iStudio: [Signed_]WebYaST_on_SLES11
> 
> Err, why is it  custom_services.XML and not  custom_services.YML ? Or is it a
> typo ?

Typo.

(In reply to comment #8)

> It's 'git master' on opensuse 11.2 

Than I assume it is fixable by using latest yast2 package (from svn).
Comment 10 Jiří Suchomel 2009-11-18 12:55:00 UTC
(In reply to comment #4)
> Solution of comment #2 is fine.

yast2-webclient-services-0.0.12