Bug 560713

Summary: yast2 keyboard module not shown in control center
Product: [openSUSE] openSUSE 11.2 Reporter: Ludwig Nussel <lnussel>
Component: YaST2Assignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: captain.magnus, coolo, eich, sndirsch, suse
Version: Final   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Ludwig Nussel 2009-12-04 09:58:54 UTC
the yast2 keyboard module misses a desktop file so it's missing from the yast2 control center. See also bug 540958.
Comment 1 Jiří Suchomel 2009-12-04 10:01:41 UTC
This was intended for 11.2 as original requirement was to remove yast2 keyboard module at all.

I don't know what the correct status should be.
Comment 2 Stefan Dirsch 2009-12-04 10:34:12 UTC
In case we really want this.

We need to make sure that the user knows that this only changes the Linux console keyboard layout and results in a *simple* X keyboard mapping for the system wide X keyboard layout. 

It does *not* change the keyboard layout for the user's session. Not immediately, not for the following sessions. 

At least in gdm you might still have a different keyboard layout, if the keyboard switcher in gdm has been used before - remembering the last setting.

If we can't make this clear, (re)introducing this dialog would be more harm
than benefit, since it would create a lot of confusion.
Comment 3 Jiří Suchomel 2009-12-04 10:37:47 UTC
I think this is for 11.3, now it is confusing enough for updating 11.2

Jiri, what do you think of 11.3 solution?
Comment 4 Ludwig Nussel 2009-12-04 12:17:49 UTC
the problem exists on 11.2 right now and needs to be fixed there. Who knows how things are going to work on 11.3. GDM allowing to select a keyboard is not a new feature in 11.2, it's been there before. Also GDM associates the changed keyboard with the user who selected it, ie it's not a global setting any user inherits.
Comment 5 Jiří Suchomel 2009-12-04 15:36:16 UTC
I'm quite indifferent about this. First, Stefan requested to remove it, so I removed it. If there are good reasons to include current module in Control center, I can add it back.
Comment 6 Stefan Dirsch 2009-12-05 11:14:05 UTC
(In reply to comment #4)
> GDM allowing to select a keyboard is not a new feature in 11.2, it's been 
> there  before. 

No longer using sax2 for keyboard configuration is not related to the features 
of gdm or any other DM at all.

> Also GDM associates the changed keyboard with the user who selected it, ie 
> it's not a global setting any user inherits.

That's even better, so every user can configure his own keyboard setting already in the displaymanager!
Comment 7 Stefan Dirsch 2009-12-05 11:18:00 UTC
(In reply to comment #5)
> I'm quite indifferent about this. First, Stefan requested to remove it, so I
> removed it. 

Well, I requested to remove the keyboard module, which runs sax2 for X keyboard configuration, since this no longer can work. Now we're talking about the Linux console keyboard configuration.

> If there are good reasons to include current module in Control center, I can 
> add it back.

I'm not sure whether this is a good idea. See my comment #2.
Comment 8 Ludwig Nussel 2009-12-07 09:42:53 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > GDM allowing to select a keyboard is not a new feature in 11.2, it's been 
> > there  before. 
> 
> No longer using sax2 for keyboard configuration is not related to the features 
> of gdm or any other DM at all.

Exactly. You brought this up in comment #2 claiming it would cause
confusion. Now the confusing thing is that we offer no way at all to
set the console keyboard layout nor the default X keyboard layout.

> > Also GDM associates the changed keyboard with the user who selected it, ie 
> > it's not a global setting any user inherits.
> 
> That's even better, so every user can configure his own keyboard setting
> already in the displaymanager!

Yeah great. It's quite common that a system has five different
keyboards attached and each user needs a different layout. NOT!
Comment 10 Stefan Dirsch 2009-12-07 10:02:27 UTC
(In reply to comment #8)
> Now the confusing thing is that we offer no way at all to set the console 
> keyboard layout nor the default X keyboard layout.

At least the latter is easy to configure in our standard desktops. How relevant is the Linux console keyboard layout for the average user, so it would justify
to confuse each and every user?

> > That's even better, so every user can configure his own keyboard setting
> > already in the displaymanager!
> 
> Yeah great. It's quite common that a system has five different
> keyboards attached and each user needs a different layout. NOT!

Well, I believe it makes sense to have it implemented that way. Still Linux is
a multiuser system. One use case are universities with students from different
countries.
Comment 12 Ludwig Nussel 2009-12-07 10:18:10 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > > That's even better, so every user can configure his own keyboard setting
> > > already in the displaymanager!
> > 
> > Yeah great. It's quite common that a system has five different
> > keyboards attached and each user needs a different layout. NOT!
> 
> Well, I believe it makes sense to have it implemented that way. Still Linux is
> a multiuser system. One use case are universities with students from different
> countries.

Yes, and that scenario is supported well by the gdm feature and the
desktop applets. That still doesn't mean that we need to remove all
means to configure a system wide default.
Comment 13 Egbert Eich 2009-12-07 11:04:07 UTC
I've tried this: if running 'yast keyboard' (console version) in an X
session any changes made don't affect the current setting, the test line
still shows the wrong settings. When doing the same on the text console,
everything works OK.
When using the 'YaST2 keyboard' version (GUI) the new layout is also set in 
X and the test line shows the correct results. This however affects the rest 
of the X session also and I'm not sure if this is what we want if a keyboard application is running on the desktop.

We could:
a. test if we are running on a text console and if not disable the keyboard  test line.
   This would disable this line always when running in GUI mode.
   Replace the message by a 
b. rename the module to console-keyboard.

If a. is considered to be too confusing the sax2 specific stuff could be replaced (should be fairly easy). The keyboard module could store the previous X keyboard setting and restore it when loosing input focus and on exit.
Comment 14 Stephan Kulow 2009-12-08 13:35:08 UTC
I have no shares in this. If you need more input, please ask opensuse-factory presenting pros and cons
Comment 15 Jiří Suchomel 2009-12-10 14:53:44 UTC
sigh. I do not think this makes sense to change for 11.2. Stefan, what is the solution for 11.3? Should current functionality remain?
Comment 16 Stefan Dirsch 2009-12-10 22:47:35 UTC
My opinion is that we don't need to offer a tool to configure a system wide default for the X keyboard layout. Just use the keyboard setting from installation. The same applies to the Linux console keyboard.

Anyway, I don't believe we're going to find an agreement here. So openSUSE project management needs to decide something here.

Since SaX2 is no longer been developed (see huge email thread on opensuse-factory ML; no single person from our communitiy appears to be interested into further development of this tool) I would appreciate if if the proposal is *not* based on SaX2.
Comment 17 Jiří Suchomel 2009-12-11 09:04:03 UTC
Ludwing, do you miss system wide X11 keyboard configuration or console keyboard configuration?
Comment 18 Stefan Dirsch 2009-12-11 09:13:06 UTC
Of course he does. Otherwise he wouldn't have opened this bugreport.
Comment 19 Jiří Suchomel 2009-12-11 09:22:08 UTC
I mean, which part (there are 2 in comment 17) is more important.
Comment 20 Ludwig Nussel 2009-12-11 09:25:52 UTC
What's the point of the question? Since the module writes /etc/sysconfig/keyboard and the xdm init script hack reads that file the module also sets the X default keyboard *without help of sax2*. I really fail to understand the arguing in this bug. The code is there, works and is not going away since it's needed during install anyways. I'm not asking you to add or remove code, all that's missing is a lousy desktop file for the existing module. That doesn't hurt or prevent anyone from using fancy desktop tools for keyboard changes in their X session.
Comment 21 Stefan Dirsch 2009-12-11 09:53:23 UTC
This "lousy" desktop file is going to trigger a lot of confusion. See my comment 
#2. Also users are going to complain that there were a lot more options to specify with the old keyboard module (which was using SaX2 for the X keyboard configuration, but users don't know this).
Comment 22 Ludwig Nussel 2009-12-11 10:30:14 UTC
Well, I don't buy this confusion argument. The yast2 keyboard module
obviously is for the basic settings, it doesn't even try to be more
than that. Anyone who needs more sophisticated stuff, dynamic layout
switching etc will inevitability have to look elsewhere.
Comment 23 Jiří Suchomel 2009-12-11 12:49:55 UTC
I'm giving up.

Would this be possible to issue as 11.2 update? By "this", we mean  re-adding a desktop file that enables 'yast2 keyboard' in YaST control center.
Comment 24 Christian Dengler 2009-12-11 13:05:26 UTC
Hmm, it seems that it is a topic to argue ;-)

My opinion here is: we ship the code behind, then we also should enable it in yast2.

for an update here: +1
Comment 25 Stefan Dirsch 2009-12-11 13:06:17 UTC
(In reply to comment #22)
> Well, I don't buy this confusion argument. The yast2 keyboard module
> obviously is for the basic settings, it doesn't even try to be more
> than that. 

Apparently you no longer remember the SaX2 keyboard module.

> Anyone who needs more sophisticated stuff, dynamic layout
> switching etc will inevitability have to look elsewhere.

You could do this with the SaX2 keyboard module. People are going to ask for
this, if we offer again a YaST keyboard module.
Comment 26 Stefan Dirsch 2009-12-11 13:08:57 UTC
Against an update here: -1 ;-)
Comment 27 Christian Dengler 2009-12-11 13:13:55 UTC
(In reply to comment #26)
> Against an update here: -1 ;-)

Not your decision :-P (otherwise you have to join the maintenance team *G*)  ... other opinions from MAINTENANCE team?


It is hard to find a solution here ;-)
Comment 28 Stefan Dirsch 2009-12-11 13:16:03 UTC
Sorry, didn't know you are from maintenance team.
Comment 29 Christian Dengler 2009-12-11 13:34:06 UTC
> Sorry, didn't know you are from maintenance team.

I didn't mean it seriously ;-)


Your opinion is important for us. To reintroduce it is not really important for me. From technical view: - ; for user view: + ;-)


> You could do this with the SaX2 keyboard module. People are going to ask for
> this, if we offer again a YaST keyboard module.

ok, convinced: -1
Comment 30 Stefan Dirsch 2009-12-12 13:46:56 UTC
I found another Pro (by lnussel)

"There are requests to support non-ASCII passwords for encrypted
partitions. For that purpose the text console setting is crucial esp
for the root partition as I doubt anyone wants to start X in the
initrd. So no matter what convenience functions the DM offers we
still need that yast module."

Personally I would reject such a request, but since we're used to do everything
what customers are requesting no matter stupid or wrong the idea is ... :-(
Comment 31 Christian Dengler 2009-12-14 16:15:25 UTC
We need a solution here! ;-)


update or no update?


Do we have a proper solution for 11.3?
Comment 32 Stefan Dirsch 2009-12-14 18:05:15 UTC
(In reply to comment #31)
> We need a solution here! ;-)
> 
> update or no update?

As I suggested before the maintenance team need to decide this.
 
> Do we have a proper solution for 11.3?

No.
Comment 33 Magnus Boman 2009-12-14 21:38:32 UTC
I think we should block the update for now, especially since there is no solution for 11.3. If we get any dupes/votes for this bug, then we should re-consider.

-1 to update
Comment 34 Christian Dengler 2009-12-15 14:00:36 UTC
ok, no update here at the moment. Please re-set a NEEDINFO to maintenance team if you have got a proper solution. ;-)

I think it would be nice to add a comment to the release notes, manual,... (deprecated but can be used by "yast2 keyboard" or something like that) ;-)
Comment 35 Jiří Suchomel 2009-12-15 14:09:14 UTC
This means wontfix for 11.2. Christian, Ludwig please discuss what do you want  11.3 and than tell me the result
Comment 36 Christian Dengler 2009-12-15 15:05:44 UTC
hmm, I'm not the right contact person for 11.3. Stefan is the better one here. Otherwise we can start a discussion on the Factory mailing list, how to handle it in the future and collect ideas...
Comment 37 Stephan Kulow 2009-12-16 11:47:07 UTC
I for one would put the keyboard module back in and name it System Keyboard or something.
Comment 38 Stefan Dirsch 2009-12-16 12:01:28 UTC
(In reply to comment #37)
> I for one would put the keyboard module back in and name it System Keyboard or
> something.

Coolo, please read my comment #2. "Linux console keyboard/simplified system keyboard" would be appropriate, but I'm sure it won't be accepted by the usability "team".
Comment 39 Stephan Kulow 2009-12-16 12:57:18 UTC
For good reasons, because it's silly. "System Keyboard" is not.
Comment 40 Stefan Dirsch 2009-12-16 13:58:24 UTC
"System Keyboard" is misleading. It will result in a lot of confusion - mentioned several times before. But in the end, it won't be my decision.
Comment 41 Jiří Suchomel 2009-12-22 10:53:15 UTC
OK, I propose this change in YaST keyboard module for 11.3:

- add the removed desktop file back, label it "System Keyboard Layout" instead of the old "Keyboard Layout".

- adapt the help text. Currently, this is shown _during installation_:

Keyboard Configuration
Choose the Keyboard Layout to use for installation and in the installed system. Test the layout in Test. For advanced options, such as repeat rate and delay, select Expert Settings. 
If unsure, use the default values already selected. 

- my proposal is to have slightly modified help text for the installed system, like:

Keyboard Configuration
Choose the Keyboard Layout to use in the system. Test the layout in Test. For advanced options, such as repeat rate and delay, select Expert Settings.
Find more options as well as more layouts in the keyboard layout tool of your desktop environment.
Comment 42 Jiří Suchomel 2009-12-22 10:54:01 UTC
Stephan?
Comment 43 Stefan Dirsch 2009-12-22 15:08:23 UTC
(In reply to comment #41)
> - my proposal is to have slightly modified help text for the installed system,
> like:
> 
> Keyboard Configuration
> [...] Test the layout in Test. [...]

Maybe remove this line completely? See Egbert's comment #13 why.
Comment 44 Stefan Dirsch 2009-12-22 15:09:25 UTC
(In reply to comment #43)
> > Keyboard Configuration
> > [...] Test the layout in Test. [...]
> 
> Maybe remove this line completely? See Egbert's comment #13 why.

s/line/sentence/
Comment 45 Stefan Dirsch 2010-01-04 09:42:09 UTC
*** Bug 544217 has been marked as a duplicate of this bug. ***
Comment 46 Jiří Suchomel 2010-01-04 09:53:33 UTC
Help text adapted (without Test line), desktop file returned, see comment 41. New package is yast2-country-2.19.4, submitted to Factory.