Bug 561617

Summary: gnome-docker INFO (main:38) No docking station detected, exiting
Product: [openSUSE] openSUSE 11.3 Reporter: Klaus Gast <klaus.gast>
Component: BasesystemAssignee: E-mail List <bnc-team-screening>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P4 - Low CC: vuntz
Version: Milestone 3   
Target Milestone: Milestone 4   
Hardware: i386   
OS: openSUSE 11.3   
Whiteboard:
Found By: Customer Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: lshal output from Dell D820 Notebook taken while being docket

Description Klaus Gast 2009-12-08 14:18:26 UTC
Hardware:
------------------------------------------
Dell Latitude: D820
Dell Docking Station: PR01X
------------------------------------------

Problem:
----------------------------------------------------------------------------
gnome-docker returns: "INFO (main:38) No docking station detected, exiting " since upgrading to openSuSE 11.2. 
----------------------------------------------------------------------------

This worked fine with openSuSE 11.1
Comment 1 Vincent Untz 2010-01-21 15:14:20 UTC
Holger: can you take a look at this?
Comment 2 Holger Macht 2010-01-21 15:16:49 UTC
Yes.
Comment 3 Holger Macht 2010-03-02 11:27:48 UTC
Please attach your lshal output, thanks.
Comment 4 Klaus Gast 2010-03-04 08:46:47 UTC
Created attachment 346502 [details]
lshal output from Dell D820 Notebook taken while being docket
Comment 5 Klaus Gast 2010-03-04 08:47:40 UTC
I attached the file as requested
Comment 6 Holger Macht 2010-03-23 12:26:46 UTC
The issue is that HAL need to as a capability 'dock_station' to the device node. However, if this is done depends on the installed kernel version, it needs to be >=2.6.28. However, the login in HAL to do this is flawed. Due to the fact that the only part which depends on this is the docking code I'm going to add a simple workaround because we know the kernel version in openSUSE distributions. This does not make sense to fix correctly because HAL is supposed to die anyway.

Changing product to 11.3, because we won't fix this for 11.2, sorry.
Comment 7 Danny Al-Gaaf 2010-03-23 12:56:12 UTC
The question is: why wasn't the capability 'dock_station' not set in HAL. Either there is a bug in compare_ge_kernel_version(2,6,28) (since the kernel version is 2.6.31 and the function checks if the kernel version is greater than or equal) or the sysfs-attribute 'type' didn't contain 'dock_station'. 

Anyway: we should fix it.
Comment 8 Holger Macht 2010-03-30 08:12:27 UTC
(In reply to comment #6)
> needs to be >=2.6.28. However, the login in HAL to do this is flawed.
                                       ^^^
This should read "logic". And I guess this makes it more clear ;-) So indeed, the kernel version detection is broken, somehow.

My workaround is in Factory, so I'm closing this bug. If you like to do a real fix, reopen it and assign it to you, but I don't think it's worth the effort.
Comment 9 Danny Al-Gaaf 2010-03-30 11:12:21 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > needs to be >=2.6.28. However, the login in HAL to do this is flawed.
>                                        ^^^
> This should read "logic". And I guess this makes it more clear ;-) So indeed,
> the kernel version detection is broken, somehow.
> 
> My workaround is in Factory, so I'm closing this bug. If you like to do a real
> fix, reopen it and assign it to you, but I don't think it's worth the effort.

No, you're wrong if this is about 11.2: in OBS openSUSE:11.2:Update the hal package doesn't contain the needed code. I'm not sure about the code version of the HAL package in 11.2 (since it wasn't packaged in the correct way (not with make dist-bzip2 since the ChangeLog file is empty, Thanks!))

The code to check the kernel version was added with commit 83c33b40c2be23d4d982777272c7ae2bc714f9e8 which isn't part of the HAL in 11.2. That's why hal never sets info.capability to dock_station. I assume the needed patch from you was removed without checking if the code was already added upstream!
Comment 10 Holger Macht 2010-03-30 11:43:18 UTC
I only looked at Factory code.
Comment 11 Bernhard Wiedemann 2016-04-15 10:37:13 UTC
This is an autogenerated message for OBS integration:
This bug (561617) was mentioned in
https://build.opensuse.org/request/show/35615 Factory / hal