|
Bugzilla – Full Text Bug Listing |
| Summary: | upstream or drop ancient pidgin patches | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.4 | Reporter: | Stanislav Brabec <sbrabec> |
| Component: | GNOME | Assignee: | E-mail List <gnome-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | CC: | dimstar, hpj, lnussel, vuntz, zaitor |
| Version: | Factory | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
|
Description
Stanislav Brabec
2010-01-08 17:36:37 UTC
The default upstream emote theme is following the tango guidelines and is a decent default, I think we can drop our custom themes. Stanislav: any progress on this? Moving to 11.4
Current list of patches in the pidgin package (what is left after updating to 2.7.3 in my branch):
> includes.patch
> pidgin-bnc550170-qq-2008only.patch
> pidgin-browser-default.patch
> pidgin-dbus-invalid-gpointer.patch
> pidgin-gnome-keyring.patch
> pidgin-nonblock-aim.patch
> pidgin-nonblock-common2.patch
> pidgin-nonblock-common.patch
> pidgin-nonblock-gwim.patch
Regarding my patches: pidgin-browser-default.patch: Submitting as http://developer.pidgin.im/ticket/12505 pidgin-bnc550170-qq-2008only.patch: It is a hack that forced all users to migrate to QQ2008 whenever they enter into preferences. I never tried to upstream it, as I don't use QQ and I don't know any details. Feel free to drop the patch. I think that all people already miograted. pidgin-dbus-invalid-gpointer.patch includes.patch look like apparent compilation warning fixes. We should check whether they are still needed. If not, we can drop it, otherwise upstream them. All other patches: Maybe HPJ can answer or try to describe its usefullness to the upstream: http://developer.pidgin.im/newticket pidgin-bnc550170-qq-2008only.patch => dropped in my branch pidgin-dbus-invalid-gpointer.patch => seems still valid. I will upstream it includes.patch => not sure (yet) if really needed. Will check includes.patch can be dropped for sure => the code change is within an #if 0 [...] #endif statement. pidgin-dbus-invalid-gpointer.patch submitted as http://developer.pidgin.im/ticket/12507 Which leaves those rest to be checked: > pidgin-gnome-keyring.patch => is disabled on any non SLE platform.. I could not care less :) I'm not even sure it applies. > pidgin-nonblock-aim.patch ==> is currently disabled in the build ; has been marked as NEEDS REBASE since January 2009. As per .changes text, it was probably earlier disabled. > pidgin-nonblock-common2.patch > pidgin-nonblock-common.patch > pidgin-nonblock-gwim.patch Well, disabling pidgin-gnome-keyring.patch in openSUSE was a consensus in bug 566286. openSUSE: pidgin does not depend on gnome-keyring unlocking (i. e. no extra keyring unlock dialog in non-GNOME sessions). SLED: Use gnome-keyring to keep passwords more safe. It is surely not an optimal solution. I agree with Stanislav is comment #9: Leave gnome-keyring on in SLED, if that is the consensus. The nonblock patches that no longer apply can be dropped. (changed during the 2011-02-20 Open-Bugs-Day about bugs for obsolete versions of openSUSE)+1 So is this bug ready for closing? I see that new patches have been added, so in a sense I guess this bug can remain open for eternity ;-) Lots of patches are gone and the remaining ones are probably safe to stay, so I think it's about time to close this bug (which should not mean we should stop upstreaming patches) |