Bug 571930

Summary:	YaST2 Hardware/Printer/Edit uses Gnome button order in KDE
Product:	[openSUSE] openSUSE 11.2	Reporter:	Keith Briscoe <bbregister>
Component:	YaST2	Assignee:	Katarina Machalkova <kmachalkova>
Status:	RESOLVED DUPLICATE	QA Contact:	Jiri Srain <jsrain>
Severity:	Minor
Priority:	P5 - None	CC:	jsmeix
Version:	Final
Target Milestone:	---
Hardware:	All
OS:	openSUSE 11.2
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Keith Briscoe 2010-01-19 16:51:21 UTC

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET CLR 1.1.4322; MS-RTC LM 8; MS-RTC EA 2)

Specifically, this applet uses Cancel/OK, and therefore looks out of place on a KDE desktop.  There may also be other places where this applet uses the wrong button order, and it may be worth reviewing every dialog for both button order and placement.

Please refer to the wiki about how to handle Gnome/KDE button order differences using the ButtonBox widget:
http://en.opensuse.org/YaST/Development/Misc/Button_Order

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1 Johannes Meixner 2010-01-21 13:17:05 UTC

To verify that the button ordering does not adapt
according to the GUI (Gtk for Gnome, Qt for KDE),
run as root
  yast2 --gtk printer
and
  yast2 --qt --geometry 800x600+100+100 printer
and check the button ordering.

As far as I see the root cause is in the Wizard
because in yast2-printer I call only the Wizard
e.g. in /usr/share/YaST2/include/printer/basicadd.ycp
----------------------------------------------------------------
  Wizard::SetContentsButtons( caption,
                              contents,
                              HELPS["basic_add_dialog"]:"",
                              Label::CancelButton(),
                              Label::OKButton()
                            );
  Wizard::HideAbortButton();
----------------------------------------------------------------
I did this because of bug #440560 in particular note
https://bugzilla.novell.com/show_bug.cgi?id=440560#c4

The button ordering is what the Wizard does
and therefore I assign it accordingly.

Katarina,
if it is not the Wizard but actually my code,
please provide a code example how I can tell the Wizard
to adapt the button ordering therein according to the GUI.

Comment 2 Keith Briscoe 2010-02-02 03:39:16 UTC

This may be a duplicate of bug#575649; I don't know enough about it to be certain.

Comment 3 Johannes Meixner 2010-02-02 11:24:55 UTC

I also don't know enough about it to be certain
but from my point of view it looks very much like
a duplicate of bug#575649 so that I close this one
accordingly - if I am wrong we can reopen this one.

*** This bug has been marked as a duplicate of bug 575649 ***