Bug 579448

Summary: zh_CN (chinese) gimp close modified image - save or save?
Product: [openSUSE] openSUSE 11.2 Reporter: Ailin Nemui <ailin.nemui>
Component: TranslationsAssignee: Karl Eichwalder <ke>
Status: RESOLVED FIXED QA Contact: Karl Eichwalder <ke>
Severity: Critical    
Priority: P3 - Medium CC: maintenance, meissner
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.2   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 555166    
Attachments: screenshot of the problem dialog

Description Ailin Nemui 2010-02-12 08:49:37 UTC
Created attachment 342159 [details]
screenshot of the problem dialog

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.9.2.0) Gecko/20100115 SUSE/3.6.0-1.2 Firefox/3.6

When closing a modified image in the GIMP, it presents the user with the choice of
[ Save ] [ Cancel ] [ Save ]
(in Chinese: ???(S)? ???(C)? ???(S)?)

However, only one of the Save buttons saves the work, the other one discards the changes. The one that discards the changes should read ???(D)? or something thelike.

This is a critical bug, because it might cause data loss. There is no visible clue as to which Save button is the right one. Arguably, the Gnome button order suggests that it is on the right side -- however, in OpenOffice as shipped with openSUSE, it is just on the left :-( (yes, this is not a true Gnome app, but the average user wouldn't know.) The careful reader might choose to cancel this dialog instead and save manually. However, those people I know weren't as clever!

Reproducible: Always

Steps to Reproduce:
1. Modify an image
2. Close the image window (e.g. keyboard shortcut Ctrl+W) 
3. Try your luck hitting the right Save button
Actual Results:  
Image modification get discarded 50% of the time 

Expected Results:  
Image is always saved when clicking on Save. Additionally, a Discard button would be nice.

On a side note, it's strange how many different button layouts are there. For example, gedit says ???????(W)? (don't save but close the window), whereas evolution uses the phrase ?????(D)? (abandon changes; using another verb than OpenOffice)
Comment 1 Karl Eichwalder 2010-02-12 10:12:22 UTC
Eric, can you take a look, please?  Or shall we report it upstream?  Once done, please assign it back to me--it probably deserves an online update.
Comment 2 Ailin Nemui 2010-02-12 14:00:44 UTC
I found the upstream bug
https://bugzilla.gnome.org/show_bug.cgi?id=598516

I believe the fix is included in this changeset
http://git.gnome.org/browse/gimp/commit/?id=35873d22b26e794125718c2ac189289aeee6b4ea
Comment 3 Xiaolong Shan 2010-02-24 07:18:29 UTC
(In reply to comment #1)
> Eric, can you take a look, please?  Or shall we report it upstream?  Once done,
> please assign it back to me--it probably deserves an online update.

It's fixed upstream.

Translations of GIMP and many other GNOME/KDE apps are contributed by upstream. openSUSE l10n teams only translate those SUSE-Only apps.
Comment 4 Karl Eichwalder 2010-02-24 09:13:44 UTC
thanks for investigating!

Maintainers, do we need an online update?
Comment 5 Marcus Meissner 2010-02-24 12:21:37 UTC
is this dialog a GNOME or a gimp specific dialog?
Comment 6 Marcus Meissner 2010-02-24 12:55:43 UTC
we are currently doing a GIMP security update, if this is GIMP specific it is a good idea to roll it into it. (bug 555166 e.g.)
Comment 7 Karl Eichwalder 2010-02-26 12:43:29 UTC
Will one of you gimp/gnome experts please attach the upstream .po translation file?  Once done, I'll do the packaging if nobody else volunteers,
Comment 8 Ailin Nemui 2010-02-26 13:28:26 UTC
Please fix the accelerator binding while at it, the upstream only fixed this in a much later release than the changeset I linked to. 
[ it should be _N, as in "do_N't save", not _S, which was related to the earlier copy&paste bug. ]

Thanks
Comment 9 Ming Xi Wu 2010-03-01 03:21:00 UTC
(In reply to comment #6)
> we are currently doing a GIMP security update, if this is GIMP specific it is a
> good idea to roll it into it. (bug 555166 e.g.)

I confirmed that the bug had been fixed with bug 555166 when upgrade to 2.6.8.
Comment 10 Karl Eichwalder 2010-03-02 13:36:02 UTC
(In reply to comment #9)
> (In reply to comment #6)
> > we are currently doing a GIMP security update, if this is GIMP specific it is a
> > good idea to roll it into it. (bug 555166 e.g.)
> 
> I confirmed that the bug had been fixed with bug 555166 when upgrade to 2.6.8.

Ok, thanks.  This we can close it here and wait for the version upgrade.