Bug 589296

Summary: can't properly uncheck "synchronize with ntp"
Product: [openSUSE] openSUSE 11.3 Reporter: Ludwig Nussel <lnussel>
Component: YaST2Assignee: Martin Vidner <mvidner>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P3 - Medium CC: jsuchome, varkoly
Version: Factory   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: screenshot of the proposal
patch for ntp-client_proposal.ycp

Description Ludwig Nussel 2010-03-18 10:13:55 UTC
in 1st stage install it's not possible to disable the ntp configuration without modifying the system's clock. There should be a third option "keep current system time".
bug 554700 looks similar and was filed for webyast
Comment 1 Martin Schmidkunz 2010-03-23 12:11:05 UTC
Sorry, but I was not able to reproduce that bug :-(

If you want to keep currrent system time just click on "Next" in the installation.
If do not want to use NTP manual time selection is enabled and the dialog can be left without having to modify that setting.

If you have the feeling, that the bug is still valid, please describe steps to reproduce it or add screenshots which illustrate what you mean.
Comment 2 Ludwig Nussel 2010-03-23 12:32:16 UTC
(In reply to comment #1)
> If do not want to use NTP manual time selection is enabled and the dialog can
> be left without having to modify that setting.

If you check the 'Manually' button YaST sets the system clock to the
values of the entry boxes. The entry boxes are filled when you enter
the dialog and are not updated while you are viewing the dialog. So
the system clock always gets set back by the amount of time you
spent in the dialog. To reproduce stay a little longer before
clicking 'Next' (just like a user who needs to read and understand
the dialog), then check your system's time. It's most obvious if you
install in a VM as the VM's time will be behind the host's after
that dialog.
Comment 3 Martin Schmidkunz 2010-03-23 12:45:37 UTC
Thanks for the explanation!

I agree with you from a usability point of view.
Unfortunately the solving of this requires some developer skills which I do not have :-(
So I`ll assign it to the YaST developer for time & date. I suppose, this is you, Jiri. Otherwise please forward this bug to the appropriate developer. Thanks!
Comment 4 Jiří Suchomel 2010-03-26 14:35:30 UTC
Created attachment 350850 [details]
screenshot of the proposal

What about the additional checkbox?
Comment 5 Ludwig Nussel 2010-03-26 14:51:05 UTC
I don't mind. whether a third radio button or that check box is better is probably a question for usability.
Comment 6 Martin Schmidkunz 2010-03-29 10:24:05 UTC
Mhm. The checkbox looks quite confusing.
What about three radio buttons?

( ) Manually
( ) Synchronize with system time
( ) Synchronize with NTP server
Comment 7 Jiří Suchomel 2010-03-29 10:36:18 UTC
(In reply to comment #6)
> Mhm. The checkbox looks quite confusing.
> What about three radio buttons?
> 

> ( ) Synchronize with system time

This does not mean anything.

Technically, we want to achieve the option to "Switch NTP off, but do not adapt time now". That's why it kind of belongs to that 'Manually' part.

I admit that it is not perfect, that's why I did not submit it yet, but still, I think it is better and less confusing that your proposal.
Comment 8 Martin Schmidkunz 2010-03-29 11:08:38 UTC
Mhm. OK, than use a check box with "adapt time now".
I think, it would make sense to have it checked by default as most users will use this option.
Comment 9 Jiří Suchomel 2010-03-30 07:27:34 UTC
Well, do we have API for disabling NTP from ntp-client_proposal?
Comment 10 Jiří Suchomel 2010-03-31 10:59:31 UTC
(In reply to comment #9)
> Well, do we have API for disabling NTP from ntp-client_proposal?

With "SetUseNTP", I can save only the variable that indicates me current status. So if I call it with false, I can show that it is off.

However, it is not, because it was initialized by default and only way to switch it off would be calling ui_try_save.  But this one also does the synchronization, which I want to avoid in this ace.
Comment 11 Jiří Suchomel 2010-04-06 13:52:45 UTC
Created attachment 352598 [details]
patch for ntp-client_proposal.ycp

This seems to be working for me. What do you think?
Comment 12 Jiří Suchomel 2010-04-08 12:00:50 UTC
Submitted yast2-country-2.19.12 (which uses "write_only" option from the patch above).

Please continue with yast2-ntp-client
Comment 13 Martin Vidner 2010-04-08 13:58:10 UTC
Committed: http://svn.opensuse.org/viewvc/yast?view=revision&revision=61616

In a related news, Peter Varkoly has offered to maintain yast2-ntp-client, so he will submit the package after committing a change of his own.