Bug 600134

Summary: Empty "The following product updates will NOT be installed" statement
Product: [openSUSE] openSUSE 11.3 Reporter: Gerald Pfeifer <gp>
Component: libzyppAssignee: Jan Kupec <jkupec>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P2 - High CC: ma
Version: Factory   
Target Milestone: Milestone 7   
Hardware: x86-64   
OS: openSUSE 11.3   
Whiteboard:
Found By: Product Management Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Resolver testcase
Resolver testcase
Resolver testcase: solver-system.xml.gz
Resolver testcase: 8435808-package.xml.gz
Resolver testcase: y2log
Output of zypper dup
proposed patch

Description Gerald Pfeifer 2010-04-27 15:19:35 UTC
Created attachment 357130 [details]
Resolver testcase

Running a zypper up on yesterday's FACTORY right now, I am seeing the
following:

     tcl
       8.5.8-4.21


     The following product updates will NOT be installed:


     The following packages are going to be upgraded:
     ImageMagick
       6.6.1.0-1.3 -> 6.6.1.0-2.1


The mid section ("The following product updates will NOT be installed")
is confusing and should be omitted if there is nothing actually there.
Comment 1 Gerald Pfeifer 2010-04-27 15:20:18 UTC
Created attachment 357131 [details]
Resolver testcase
Comment 2 Gerald Pfeifer 2010-04-27 15:20:50 UTC
Created attachment 357132 [details]
Resolver testcase: solver-system.xml.gz
Comment 3 Gerald Pfeifer 2010-04-27 15:21:13 UTC
Created attachment 357133 [details]
Resolver testcase: 8435808-package.xml.gz
Comment 4 Gerald Pfeifer 2010-04-27 15:21:32 UTC
Created attachment 357134 [details]
Resolver testcase: y2log
Comment 5 Gerald Pfeifer 2010-04-27 15:21:51 UTC
Created attachment 357135 [details]
Output of zypper dup
Comment 6 Jan Kupec 2010-04-27 15:57:32 UTC
Thanx Gerald, i'll fix it soon.

I have a feeling that Michael already reported this one but can't find the dupe.
Comment 7 Michael Andres 2010-04-28 09:55:31 UTC
*** Bug 595684 has been marked as a duplicate of this bug. ***
Comment 8 Jan Kupec 2010-05-06 16:39:02 UTC
Created attachment 360174 [details]
proposed patch

This is consequence of the following code, which leaves empty sets for some keys in the map:

for_(it, toupgrade.begin(), toupgrade.end())
    set_difference(
        candidates[it->first].begin(), candidates[it->first].end(),
        it->second.begin(), it->second.end(),
        inserter(notupdated[it->first], notupdated[it->first].begin()),
        Summary::ResPairNameCompare());

The attached patch should fix this.
Comment 9 Jan Kupec 2010-05-06 16:59:10 UTC
Pushed to git, will be in zypper-1.4.3-(some of the later releases than that which will now get to Factory - sorry for this).