Bug 610313

Summary: yast2-gtk: textdomain missing in most of source files
Product: [openSUSE] openSUSE 11.3 Reporter: Jiri Srain <jsrain>
Component: YaST2Assignee: opensuse-translation-de opensuse-translation-de <opensuse-translation-de>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P3 - Medium CC: coolo, forgotten_h13THG8RK1, jsrain, ke
Version: Factory   
Target Milestone: RC 2   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: PT translation
Gnome desktop with an xterm open

Description Jiri Srain 2010-05-31 09:59:58 UTC
The text domain is missing in the source files of yast2-gtk: This results in the texts not being passed for translations.

y2makepot reports appropriate errors.
Comment 1 Forgotten User h13THG8RK1 2010-06-08 14:33:36 UTC
Well, given only the gtk-pkg code makes intensive use of strings, I have not added such text to every single file. But if you're getting errors, I sure will.

Anyway, do clarify the urgency of the matter. The messages you're getting are not critical errors, but only cosmetic warnings, right? I mean, the build does work? If that's the case, I would feel more comfortable applying the changes to trunk post-11.3.
Comment 2 Jiri Srain 2010-06-08 14:47:15 UTC
Of course, build works, the only problem is that the text don't get their way to the .pot-file and will not be passed for translations.

The urgency depends on whether it should be fixed into 11.3 or not. However, I don't dare to say as it affects only unimportant strings:


Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/YGTable.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/ygtktreeview.c
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgmenubar.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgfilterview.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/yzypptags.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgstatusbar.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgrpmgroupsview.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgpatternview.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgdetailview.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkghistorydialog.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgundolist.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkglistview.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgsearchentry.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/YGPackageSelector.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgproductdialog.cc
Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/yzyppwrapper.cc

Creating ./yast2-gtk.pot from  ./src/YGProgressBar.cc ./src/YGUI.cc ./src/YGUtils.cc ./src/ygtksteps.c ./src/ygtkwizard.c ...


The fact that they are translated in last milestone does not mean it will be translated in GA - if the textdomain was removed at some point of time, next snapshot of the .pot-file did not contain the texts and they will be removed from the final translations.
Comment 3 Forgotten User h13THG8RK1 2010-06-08 15:33:51 UTC
So, all those files with errors do have the Textdomain comment, but it is as:

/* Textdomain "yast2-gtk" */

instead of the successful ones:

/*
  Textdomain "yast2-gtk"
 */

This was always the case since their inception. Is the y2makepot tool picker now? :)

I sure think we should correct this for 11.3 if it means no i18n.
Comment 4 Forgotten User h13THG8RK1 2010-06-08 16:47:50 UTC
(In reply to comment #3)
> This was always the case since their inception. Is the y2makepot tool picker
> now? :)

Okay, so all those are post-11.2 files, so the i18n build only hit the problem now.
Comment 5 Forgotten User h13THG8RK1 2010-06-08 16:50:20 UTC
Jiri, submitted fixed files to build-service. Tell me if there is anything more I should do.

I am also curious if this means the software manager UI will be shipped in English. :( Will at least common strings with the 11.2 release be picked up?
Comment 6 Forgotten User h13THG8RK1 2010-06-08 16:51:54 UTC
By the way, thank you so much for spotting the problem, and bringing it to my attention.
Comment 7 Jiri Srain 2010-06-09 05:56:02 UTC
I have submitted new .pot-file to the i18n SVN. Karl, please, merge the already translated texts and pass the remaining strings to translators so that we get the package selector translated at least in some languages, thanks!
Comment 8 Karl Eichwalder 2010-06-09 08:15:45 UTC
Thanks for your help, Jiri!  Merging is running now.  I'll try to recover as much as possible from the memory files and the 11.2 branch.
Comment 9 Forgotten User h13THG8RK1 2010-06-09 12:21:12 UTC
Appreciated Karl!

Do tell me where I can locate those files. I know some people who will be happy to review them.
Comment 10 Forgotten User h13THG8RK1 2010-06-09 18:45:25 UTC
FYI: [obs submit-request 41268] openSUSE:Factory/yast2-gtk: accepted by autobuild
Comment 11 Karl Eichwalder 2010-06-14 07:57:21 UTC
(In reply to comment #9)

> Do tell me where I can locate those files. I know some people who will be happy
> to review them.

yast translations are in the opensuse-i18n SVN at BerliOS.de: for more info, see http://en.opensuse.org/OpenSUSE_Localization_Guide .

Last week, I submitted the updated yast2-trans package.
Comment 12 Forgotten User h13THG8RK1 2010-06-14 14:30:29 UTC
Created attachment 368982 [details]
PT translation

Here's the PT file reviewed.

I noticed that major languages like French (fr), Spanish (es) and Brazilian
Portuguese (pt_BR) are all fully translated already. Very cool.

German (de) isn't however. Will try to get someone to review that one.
Comment 13 Forgotten User h13THG8RK1 2010-06-14 14:32:03 UTC
Karl, please commit the PT file from comment 12.

No need to submit this already to build-service just now. Let's see if we can get at least the German one reviewed too.
Comment 14 Karl Eichwalder 2010-06-14 14:45:52 UTC
Thanks for your help!  I guess or hope that I can add a translation update for RC2.  Thus, reopening.
Comment 15 Karl Eichwalder 2010-06-16 09:43:35 UTC
Created attachment 369476 [details]
Gnome desktop with an xterm open
Comment 16 Karl Eichwalder 2010-06-16 09:45:59 UTC
Comment on attachment 369476 [details]
Gnome desktop with an xterm open

wrong bug; it belongs to bug 614651
Comment 17 Martin Kudlvasr 2010-06-23 15:53:26 UTC
*** Bug 608802 has been marked as a duplicate of this bug. ***
Comment 18 Karl Eichwalder 2010-06-25 12:31:40 UTC
Not sure, whether this counts as a ship stopper:

msgfmt --stat de/po/yast2-gtk.de.po
141 translated messages, 93 fuzzy translations, 18 untranslated messages.
Comment 19 Forgotten User h13THG8RK1 2010-06-25 14:54:37 UTC
By the way, noticed this mistake in the German PO file:

#: src/pkg/yzyppwrapper.cc:147
msgid " of "
msgstr "von"

Treacherous trailing whites-spaces... Will avoid using them in the future.
Comment 20 Forgotten User h13THG8RK1 2010-06-27 13:04:54 UTC
I had someone (In reply to comment #12)
> German (de) isn't however. Will try to get someone to review that one.

Sorry, that guy just told me he has been unable to have a take at it. Contact me if you need assistance. I have posted some thoughts to translators here:
http://groups.google.com/group/yast2-gtk/browse_thread/thread/2517efcb01d21fba
Comment 21 Forgotten User h13THG8RK1 2010-07-05 11:17:19 UTC
Guys, the following PO file is still the out-dated one. Check my comment 12 for a revised one.

https://svn.berlios.de/svnroot/repos/opensuse-i18n/trunk/yast/pt/po/yast2-gtk.pt.po
Comment 22 Karl Eichwalder 2010-07-05 13:14:34 UTC
(In reply to comment #21)
> Guys, the following PO file is still the out-dated one. Check my comment 12 for
> a revised one.
> 
> https://svn.berlios.de/svnroot/repos/opensuse-i18n/trunk/yast/pt/po/yast2-gtk.pt.po

In SVN now.

I also fixed #19
Comment 23 Forgotten User h13THG8RK1 2011-08-26 22:24:04 UTC
Should be fixed by now.
Comment 24 Bernhard Wiedemann 2016-04-15 11:49:00 UTC
This is an autogenerated message for OBS integration:
This bug (610313) was mentioned in
https://build.opensuse.org/request/show/42486 Factory / yast2-trans
https://build.opensuse.org/request/show/42610 11.3 / yast2-trans
Comment 26 Swamp Workflow Management 2018-04-24 13:40:53 UTC
This is an autogenerated message for OBS integration:
This bug (610313) was mentioned in
https://build.opensuse.org/request/show/600626 Factory / yast2-trans
Comment 27 Swamp Workflow Management 2018-04-25 08:01:00 UTC
This is an autogenerated message for OBS integration:
This bug (610313) was mentioned in
https://build.opensuse.org/request/show/600814 15.0 / yast2-trans