|
Bugzilla – Full Text Bug Listing |
| Summary: | yast2-printer: test_* scripts should do the most meaningful test first | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.3 | Reporter: | Chris Rhodes <chris> |
| Component: | YaST2 | Assignee: | Johannes Meixner <jsmeix> |
| Status: | RESOLVED FIXED | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Enhancement | ||
| Priority: | P4 - Low | CC: | jsmeix |
| Version: | Factory | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | openSUSE 11.3 | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: | improved test_remote_socket | ||
|
Description
Chris Rhodes
2010-06-23 13:39:39 UTC
Adding auch a print queue works regardless if the test was successful or not. Just ignore the test result and proceed. yast2-printer runs the script /usr/lib/YaST2/bin/test_remote_socket to test this kind of connection which does basically those tests: 1. ping IP 2. netcat IP port If ping (which does ICMP echo) fails, there is an error message (use the [Details] button to get in in the YaST GUI) like this: --------------------------------------------------------------------- PING 10.11.12.13 (10.11.12.13) 56(84) bytes of data. --- 10.11.12.13 ping statistics --- 2 packets transmitted, 0 received, 100% packet loss, time 999ms Host 10.11.12.13 unreachable (network issue or firewall active?) --------------------------------------------------------------------- If netcat fails, there is an error message like this: --------------------------------------------------------------------- No connection possible to port 65000 on host 10.10.11.92 (wrong port or firewall active there?) --------------------------------------------------------------------- The connection test is just a basic connection test. To test whether or not the whole print queue (connection plus driver) really works, you have to print a test page. If you run a firewall, the messages already show you why the test may have failed in your particular case. I will not remove the initial ping test because I like to distinguish whether or not the IP is accessible via "ping IP" and afterwards whether or not the particular port on this IP is accessible (via "netcat IP port"). It works as intended and therefore the bug report is invalid. I have an idea... In /usr/lib/YaST2/bin/test_remote_socket
I can exchange the ordering of the tests:
If "netcat IP port" works then exit successfuly
else show the netcat-related error message and
do "ping IP" and if this also fails
then show also the ping error message
Then the most meaningful "netcat IP port" test alone
is sufficient for a successful test result so that
in your particular case no ping (ICMP echo) would be
required.
Created attachment 373249 [details]
improved test_remote_socket
You may copy the attached test_remote_socket
to /usr/lib/YaST2/bin/test_remote_socket
to test and and report if this works better
in your particular case.
Thank you very much Johannes, your fix works very well for us. I will do the same (i.e. exchange the ordering of the tests according to comment #3) also for the other test_* scripts. Fixed in YaST SVN revision 62178: ----------------------------------------------------------------- Enhanced the test_* tools to do the most meaningful test first so that ICMP echo (ping) is no longer required in any case (see Novell/Suse Bugzilla bnc#616706). This is an enhancement for after openSUSE 11.3 Increased VERSION to 2.19.14 ----------------------------------------------------------------- Submitted and accepted to YaST:Head via submitrequest 45299 and forwarded this to openSUSE:Factory via submitrequest 45299. The yast2-printer RPM package version is now 2.20.0 A typo: Submitted and accepted to YaST:Head via submitrequest 45295 and forwarded this to openSUSE:Factory via submitrequest 45299. This is an autogenerated message for OBS integration: This bug (616706) was mentioned in https://build.opensuse.org/request/show/45299 Factory / yast2-printer |