|
Bugzilla – Full Text Bug Listing |
| Summary: | Enabling the "Allow Guest Access" Setting in the Yast2 Samba Module Fails | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.4 | Reporter: | Forgotten User xs3PtXj4XH <forgotten_xs3PtXj4XH> |
| Component: | YaST2 | Assignee: | Jiří Suchomel <jsuchome> |
| Status: | RESOLVED FIXED | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Normal | ||
| Priority: | P5 - None | CC: | jsuchome, pdedecker, rolf.schmidt |
| Version: | RC 1 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | SUSE Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: |
Yast2 Error Dialogue Content 1
Yast2 Error Dialogue Content 2 patch for /usr/share/YaST2/include/samba-server/dialogs.ycp |
||
Created attachment 375298 [details]
Yast2 Error Dialogue Content 2
Second error dialogue content attachment added.
Samba Server uses SharesTerm function from samba-client, but I do not see if it actually reads the value of `guest_ch checkbox... maybe that is the problem? Well certainly if "Guest Access" has to be used in conjunction with "Allow Users", then it should remain greyed-out until "Allow Users" is checked. I have noticed that although the checkbox is empty the next time the Samba module is loaded, the relevant line does seem to be added to the samba configuration file. Nevertheless, that doesn't explain the strange Perl errors. This is frustrating. I can't reliably reproduce the Perl error messages. I still get them in 11.3 Final, but MUCH less frequently. I also can't seem to discover any exact combination of steps that will trigger this. I have reproduced this bug in 11.4 M4. This time it was triggered by clicking the "Cancel" button in the Samba module. The error text was as follows: Switch will be removed from the Perl core distribution in the next major release. Please install it from CPAN. It is being used at /usr/share/YaST2/modules/SambaServer.pm, line 17. Bug is still present in 11.4 M5. I can trigger it more reliably by starting the Samba module and setting a non-default Workgroup and Identity, and setting Samba to start automatically (and opening the firewall ports) and then saving. The next time I open the Samba module, if I click "Cancel" immediately, the bug is triggered. Is there any further information available on the status of this bug? Oh, I thought I've removed all of them :-/ Will fix it if I find some time. Thanks Lukas. I'll keep poking around and trying to see if I can still trigger the bug. I'll update if that is the case. Still reproduceable in RC1. Could you give a description of how you triggered the bug Pieter? I just start the Samba server config, check the "Allow guest access" box and click OK. When I come back, the option is no longer checked. Created attachment 422137 [details]
patch for /usr/share/YaST2/include/samba-server/dialogs.ycp
Could you please patch your /usr/share/YaST2/include/samba-server/dialogs.ycp and try again?
patch submitted with new package to Factory This is an autogenerated message for OBS integration: This bug (621618) was mentioned in https://build.opensuse.org/request/show/66113 Jiri, thankyou for submitting a patch. I see the patch has made it into Factory, but not openSuSE 11.4 yet. Is this planned? (In reply to comment #17) > Jiri, thankyou for submitting a patch. I see the patch has made it into > Factory, but not openSuSE 11.4 yet. Is this planned? Could you try to test the patch from comment 14 manually? Just save it to file (e.g. 'dialogs.patch'), backup your original /usr/share/YaST2/include/samba-server/dialogs.ycp and patch it using 'patch /usr/share/YaST2/include/samba-server/dialogs.ycp < dialogs.patch' call. Than run YaST again. If you confirm it works, we might go and release new package as online update... The file you supplied does appear to change the behaviour of the user interface to work as expected. I haven't tested actual guest access when this setting is enabled, but I assume this patch/issue only applies to the user interface. *** Bug 675097 has been marked as a duplicate of this bug. *** |
Created attachment 375297 [details] Yast2 Error Dialogue Content 1 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.6) Gecko/20100626 SUSE/3.6.6-1.2 Firefox/3.6.6 Attempting to enable "Allow Guest Access" in the Yast2 Samba Module fails when the user clicks "OK" to finalise their settings. If the user only clicks on "Allow Guest Access" and then clicks "OK", this checkbox is empty the next time the module is started. It also occasionally appears to produce a Perl error (attached), but I cannot reproduce this reliably. If the user clicks "Allow Users To Share Their Directories" and THEN clicks "Allow Guest Access", the setting stays, but the next time the Samba module is opened, clicking on "Cancel" produces another Perl error (also attached). Reproducible: Sometimes Steps to Reproduce: 1. Start the Yast2 Samba Module 2. Make some changes and then click on "Allow Guest Access" 3. Click "OK". Actual Results: An error dialogue is sometimes produced mentioning that "Switch will be removed from the Perl core distribution in the next major release". Additionally, the "Allow Guest Access" setting does not appear to stay checked unless "Allow Users To Share Their Directories" is also checked. Expected Results: The check mark stays in place and no errors are produced.