Bug 624310

Summary: File > Import and Export menu items faltering (gtk)
Product: [openSUSE] openSUSE 11.3 Reporter: Dirk Engel <dirk>
Component: YaST2Assignee: Forgotten User h13THG8RK1 <forgotten_h13THG8RK1>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Major    
Priority: P5 - None CC: badshah400, forgotten_h13THG8RK1, Markus.Egg, meissner, propstmatthias
Version: Final   
Target Milestone: ---   
Hardware: i586   
OS: openSUSE 11.3   
Whiteboard: .
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Deadline: 2010-10-05   
Attachments: y2logs

Description Dirk Engel 2010-07-21 14:06:22 UTC
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.2.6) Gecko/20100626 SUSE/3.6.6-1.2 Firefox/3.6.6

Export in "Software-Verwalter" Datei->Export... fails when pressing save with "Error exporting package list to '(null)'"

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Comment 1 Jiří Suchomel 2010-07-22 06:08:12 UTC
1. Please attach y2logs (http://en.opensuse.org/openSUSE:Bugreport_YaST)

2. Report the problem with English texts, we are not all fluent in German.
Comment 2 Dirk Engel 2010-07-24 10:56:58 UTC
Created attachment 378198 [details]
y2logs

1. y2logs attached
2. That are the names of the German menu entries. I am not sure about the correct names of the English version but I guess:

Export in "Software-Manager" File->Export... fails when pressing save with
"Error exporting package list to '(null)'"
Comment 3 Jiří Suchomel 2010-07-26 07:56:54 UTC
yast2-gtk not handling correctly that there's a package lock? 
Or libzypp problem?
Comment 4 Forgotten User h13THG8RK1 2010-07-26 16:26:32 UTC
This was a stupid bug at the gtk plugin level. It's not an esoteric corner case at all, one simple test would have caught it.

Fixed over svn for trunk and the 11.3 branch. Will build a package for Factory soon.

Should we also try to see to it that a patch gets released?
Comment 5 Forgotten User h13THG8RK1 2010-07-26 18:45:15 UTC
Submitted to build service; id 44010.
Comment 6 Forgotten User h13THG8RK1 2010-07-29 15:20:04 UTC
Fixed then.
Comment 7 Atri Bhattacharya 2010-07-29 16:50:56 UTC
(In reply to comment #4)
> This was a stupid bug at the gtk plugin level. It's not an esoteric corner case
> at all, one simple test would have caught it.
> 
> Fixed over svn for trunk and the 11.3 branch. Will build a package for Factory
> soon.
> 
> Should we also try to see to it that a patch gets released?

I would like to get a patch for this released for online update for 11.3. 

Ricardo, is it okay to make patches using this version at svn
http://svn.opensuse.org/svn/yast/branches/SuSE-Linux-11_3-Branch/gtk/ ?
Comment 8 Forgotten User h13THG8RK1 2010-07-29 18:33:13 UTC
Atri,

Yes, I fixed the feature in the 11_3 branch too. In fact, my build service submission comes from that code base. But my submission is still in hold:

https://build.opensuse.org/request/show/44010

Anyway, make sure the patch is under the "suggested" category. I mean, judging by the duplicate count, this isn't a terribly popular functionality. Plus, there is no crash or loss of data, and the error message clearly indicates something is wrong with the software. (I think this does warrant a patch; just alerting to adjusting the priority appropriately, because some people may want to review and apply only the most urgent ones.)
Comment 9 Forgotten User h13THG8RK1 2010-08-04 14:14:24 UTC
Build service submission accepted (comment 8).

Anyhow, Michael makes the point it's good practice for non-security / low urgency fixes to be deferred and grouped together with future fixes, given that each patch involves an investment on the part of the support team.

Let's give it 2 weeks? 4 weeks? Atri, it's up to you.
Comment 10 Atri Bhattacharya 2010-08-04 17:19:45 UTC
(In reply to comment #9)
> Build service submission accepted (comment 8).
> 
> Anyhow, Michael makes the point it's good practice for non-security / low
> urgency fixes to be deferred and grouped together with future fixes, given that
> each patch involves an investment on the part of the support team.
> 
> Let's give it 2 weeks? 4 weeks? Atri, it's up to you.

Indeed that is what has kept me from already submitting updates. Let us wait and see if there are other little bugs here and there.
Comment 11 Forgotten User h13THG8RK1 2010-08-10 13:59:08 UTC
*** Bug 629912 has been marked as a duplicate of this bug. ***
Comment 12 Forgotten User h13THG8RK1 2010-08-20 12:26:00 UTC
So, we probably want to defer the patch so we also ship fixes for:
* bug 632377
* bug 633173
Comment 13 Forgotten User h13THG8RK1 2010-08-22 16:24:30 UTC
Possibly also:
* bug 633498
Comment 14 Forgotten User h13THG8RK1 2010-08-22 23:50:40 UTC
All the aforementioned have been fixed. Let's give it a week for testing...
Comment 15 Atri Bhattacharya 2010-08-27 13:31:54 UTC
(In reply to comment #14)
> All the aforementioned have been fixed. Let's give it a week for testing...

I have the packages ready.

Ricardo, please confirm that I am to submit the current YaST:Head yast2-gtk package (that is built from the svn/SUSE-Linux-11_3-branch and does not contain Factory changes right?)
Comment 16 Atri Bhattacharya 2010-08-27 13:46:44 UTC
@Maintenance
The proposed version update of yast2-gtk to version 2.21.70 fixes the following bugs including this one
bug 633498
bug 632377
bug 633173

Please consider the proposed update candidate.
Thanks
Comment 17 Forgotten User h13THG8RK1 2010-08-27 23:34:05 UTC
Yep, I submitted fixes for those bugs as version 2.21.70 to YaST:Head:
https://build.opensuse.org/package/show?package=yast2-gtk&project=YaST%3AHead

Maintenance guys: here is a categorical description of the fixes involved in that submission, to see if you guys feel that, taken together, they warrant issuing an update: (none of the fixes, in isolation, would be update worthy, but we might met the requirements for a collective update.)
* bug 624310 (this one): function loss (a couple of entries clinically dead). User audience is small, and same function is provided by other system tools.
* bug 633498: UI (cosmetic?): window too small for those who use very big fonts.
* bug 632377: UI: showing incorrect package count number, if user changed some setting.
* bug 633173: potential crash: not sure about any real world case, but according to the API of a library, we were not handling some value case.
Comment 18 Christian Dengler 2010-08-30 13:06:54 UTC
Time for an update I think ... +1
Comment 19 Forgotten User h13THG8RK1 2010-08-30 14:24:10 UTC
Atri, recently, yast2-gtk wasn't compiling for Factory because of change to the gtk2 package. Anyhow, some folks fixed that and uploaded the trunk/ code to Yast:Head.

I guess we want to re-upload the 11_3 branch code, right? (because trunk has some modified strings) If so, let's suspend the patch process...
Comment 20 Forgotten User h13THG8RK1 2010-08-30 14:25:00 UTC
Wrt my previous comment, see bug 635439.
Comment 21 Forgotten User h13THG8RK1 2010-08-30 17:13:43 UTC
Uploaded again the 11.3 branch code. Request id: 46681. Version: 2.21.72

We'll have to wait for it to get approved...
Comment 22 Atri Bhattacharya 2010-09-01 09:47:39 UTC
Packages ready for submission, waiting for approval from maintenance. I guess we need one more vote right? :)
Comment 23 matthias propst 2010-09-03 16:58:29 UTC
i think its ready. all works fine here after i installed this package
Comment 24 Atri Bhattacharya 2010-09-07 13:33:01 UTC
@maintenance
Packages ready, waiting for swampid
Comment 25 Christian Dengler 2010-09-07 14:47:37 UTC
Ok, no one against from maintenance team, so starting update.

Be so kind and submit the fixed sources against openSUSE:11.3:Update:Test and submit a patchinfo.
Comment 26 Swamp Workflow Management 2010-09-07 14:48:10 UTC
The SWAMPID for this issue is 35699.
This issue was rated as low.
Please submit fixed packages until 2010-10-05.
Also create a patchinfo file using this link:
https://swamp.suse.de/webswamp/wf/35699
Comment 27 Forgotten User h13THG8RK1 2010-09-13 17:53:02 UTC
Sorry guys, but we probably want to interrupt the patch procedure, because there is a relatively nasty bug we will want to include.

The thing is that, when the user unselects "Dependencies > Autocheck", the qt plugin still applies a final solver run. But the gtk plugin doesn't. This is really problematic if an user relies on that behavior (few those may be), and doesn't apply a manual check.

See bug 637761.
Comment 28 Atri Bhattacharya 2010-09-23 21:07:43 UTC
@maintenance
I have submitted the updated version of yast2-gtk to Update/Testing that also fixes bug 637761. Please let me know if I am required to submit an updated patchinfo too.

Thanks
Comment 29 Swamp Workflow Management 2010-09-28 10:06:01 UTC
Update released for: yast2-gtk, yast2-gtk-debuginfo, yast2-gtk-debugsource
Products:
openSUSE 11.3 (debug, i586, x86_64)
Comment 30 Marcus Meissner 2010-09-28 10:07:24 UTC
released io guess.
Comment 31 Markus Egg 2011-03-06 13:58:31 UTC
Is
yast2-gtk-2.21.70-2.2.1.i586.rpm
the correct version which solves that problem?
Comment 32 Forgotten User h13THG8RK1 2011-03-06 19:53:02 UTC
Markus, yeah, that version is the latest update release, and it addresses all bugs mentioned in this bug report.

I am not sure what is the particular bug you're referring (several are discussed in this bug report), but here are the bugs addressed: (many of them are minor cosmetic fixes)

- sw_single: package count wrong on the filters box when
show-debug or show-devel when de-selected (bcn#632377)
- fixed potential crash when file picking file of esoteric
filename (bnc#633173)
- window size too small when using big fonts: correlate
window size to font size (bnc#633498)
- sw_single: fix file > import / export menu items (bcn#624310)
- sw_single: fixed duplicate separator item in context menu.
- build for bnc#620513 patch.
- adjust window size to cope with big fonts.
- more comsmetic fixes related to bnc#620513.
- comsmetic fixes related to bnc#620513.
- typo correction.
- fix sw_single post-procedure scrolling glitch.
- dependencies box sometimes freezes when open (bnc#620513).
- versions box not visible enough: swap position with
details box (bnc#620513).
- ommit online-update configuration menu item when
not running online-update (bnc#609778s)

If you are still experiencing problems, please let us know.