Bug 633173

Summary:	File open dialog: potential crash when selecting esoteric filename (gtk)
Product:	[openSUSE] openSUSE 11.3	Reporter:	Forgotten User h13THG8RK1 <forgotten_h13THG8RK1>
Component:	YaST2	Assignee:	Forgotten User h13THG8RK1 <forgotten_h13THG8RK1>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	forgotten_h13THG8RK1
Version:	Final
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:	maint:released:11.3:35708
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Forgotten User h13THG8RK1 2010-08-20 12:24:03 UTC

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pt-PT; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Ant.com Toolbar 2.0.1 Firefox/3.6.8

The gtk plugin may crash when selecting a filename, if the "selected file can't be represented with a local filename". NULL case not handled. See:

http://library.gnome.org/devel/gtk/2.20/GtkFileChooser.html#gtk-file-chooser-get-filename

Reproducible: only in some contrived circumstances. Probably not reproducible in the real world, which is why I'm not filling this under Critical.

See also: bug 610861

Reproducible: Always

Comment 1 Forgotten User h13THG8RK1 2010-08-20 22:55:42 UTC

Small related bug: the icon in the file picker is not the respective yast2 tool icon. Instead the broken icon is used.

Comment 2 Forgotten User h13THG8RK1 2010-08-22 21:54:10 UTC

It turns that bug 610861 reporter was using the Qt plugin when on Gnome actually.

All the same, I will ensure we don't crash if NULL is ever returned. Won't bother printing an error message though: just return a blank string.

Comment 1 is also not an issue.

Comment 3 Forgotten User h13THG8RK1 2010-08-22 23:44:46 UTC

Fixed.

Comment 4 Swamp Workflow Management 2010-09-28 10:06:06 UTC

Update released for: yast2-gtk, yast2-gtk-debuginfo, yast2-gtk-debugsource
Products:
openSUSE 11.3 (debug, i586, x86_64)