Bug 644831

by "with terminal set to linux-16color" I mean the TERM environment variable is set to linux-16color.

If you set a higher number than 16 as the limit you will see it can display all 16 colours it just has seems to have them offset wrong, as the later blocks repeat the bright versions faithfully, in the wrong place.

Just take upstream into account ... and IMHO this is a minor.

Thomas? What do you think about this?

I can repeat that - agree that it doesn't look right.
I'll see what fixes I can make (thanks).

It's fixed in yesterday's patch.  By the way, there's no bright black
in Linux's default palette, so I improvised using "dim" (which renders
as gray on my machine).  It's possible to program the palette, but that's
a different thing (in turn it would be possible to program a bright black
with the terminal initialization string, but seems wasteful).

Thank you Thomas, I'll go to update factory to the latest version.
The only problem I'm aware is bootstraping from the latest version
with fallback terminal lines as configure does a search for a not
existing tic.

Is that a new problem (fallback entries), or the longstanding
issue that fallbacks have "always" required ncurses tic to be
available?

The only compatibility issue I recalled was that 5.7 introduced
a bug-fix for cancelled strings which is assumed in the terminal
descriptions.

For generating the fallback.c for e.g. xterm, linux, vt100, and vt102
the program tic is required.  I prefere the tic and misc/terminfo.src
from the current source tar ball.  For this I've to skip the configure
option --with-fallbacks and run

    make -C include
    make -C ncurses fallback.c FALLBACK_LIST=""
    make -C progs   termsort.c transform.h infocmp tic
    rm   -f ncurses/fallback.c
    PATH=$PWD/progs:$OPATH
    pushd ncurses/
        TERMINFO=$PWD/tmp
        export TERMINFO
        mkdir -p $TERMINFO
        $PWD/../progs/tic -I -r -e $FALLBK ../misc/terminfo.src > terminfo.src
        $PWD/../progs/tic -o $TERMINFO -s terminfo.src
        sh -e ./tinfo/MKfallback.sh $TERMINFO ../misc/terminfo.src $PWD/../progs/tic ${FALLBK//,/ } > fallback.c
        rm -rf $TERMINFO
        unset  TERMINFO
        cp -p fallback.c ../fallback.c.backup
    popd
    PATH=$OPATH

with FALLBK="xterm,linux,vt100,vt102"

Beside this I've detected that pthread_kill is not a weak symbol anymore
for libncurses6 and that I'm see a libncursest6.

Created attachment 394370 [details]
ncurses-5.7-pthread.dif

This patch moves pthread_kill back to a weak symbol and
I'm able to use

       if test $cf_cv_weak_symbols != yes ; then
               LIB_SUFFIX="t${LIB_SUFFIX}"
       fi

in configure/configure.in to see reentrant libncurses6 again which
can be used even without libpthread.

thanks

I addressed these two issues in last week's patch (20101023).