Bug 664793

Summary: splashy does not work
Product: [openSUSE] openSUSE 12.1 Reporter: Forgotten User --EoyBps8f <forgotten_--EoyBps8f>
Component: BasesystemAssignee: Holger Macht <hmacht>
Status: RESOLVED WONTFIX QA Contact: E-mail List <qa-bugs>
Severity: Major    
Priority: P3 - Medium CC: andreas.bolsch, bruno, dsterba, e.lex, fjara, forgotten_nJNR0m-wG0, forgotten_q1-mW4hKuE, forgotten_Xl7iAZAFUm, hare, jmeidal, joachim, joerg, kairo, klaus.gast, martin.jedamzik, mihalych, novell, sergey1369, vdboor-fora
Version: Factory   
Target Milestone: ---   
Hardware: x86-64   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Forgotten User --EoyBps8f 2011-01-15 11:39:25 UTC
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.13) Gecko/20101203 SUSE/3.6.13-0.2.1 Firefox/3.6.13

If I suspend to RAM/disk there is no splash screen shown. Neither the "default" theme nor openSUSE work.

Confirmed by other users on IRC.

11.3 duped to 11.4.

Reproducible: Always
Comment 1 Bruno Friedmann 2011-01-15 11:50:08 UTC
I've do my best to catch the error : 
first the linux pingus appear, then the normal suspend splash, and an text console
with splash_start_splash error -10 done

then the normal suspend process is done in text console.
cosmetic :-) but so important for end users ....
Comment 2 Holger Macht 2011-01-25 11:20:37 UTC
Fixed splashy package submitted and should show up in factory soon. Please reopen if the problem persists in one of the following milestones or factory.
Comment 3 Forgotten User --EoyBps8f 2011-02-07 23:12:12 UTC
I updated several times to current factory but the issue is still not fixed.
Comment 4 Forgotten User --EoyBps8f 2011-02-08 08:14:55 UTC
splashy-0.3.13-19.1.i586
splashy-branding-openSUSE-0.3.13-19.1.i586
Comment 5 Holger Macht 2011-02-08 12:09:29 UTC
But hibernation still works? Or is the result any different? You might also want to run mkinitrd as root to see if this changes anything on resume.
Comment 6 MichaƂ Sawicz 2011-02-10 11:58:23 UTC
I have the same behavior on both hibernate and resume from hibernation

The message is:

"splashy_start_splash: -10none"

Hibernation works (some issues with resuming, but that's a separate problem).

That's on 11.4M6 updated from Factory as of 09.02.2010.
Comment 7 Forgotten User nJNR0m-wG0 2011-03-09 10:36:50 UTC
I see the exact same problem with 11.4 Final. Hibernation proceeds in text mode, and resume works too (with a switch to text console from kernel bootsplash before X resumes).
Comment 8 Forgotten User q1-mW4hKuE 2011-03-13 12:16:55 UTC
I can reproduce this, suspend itself works, but splashy fails with:

splashy_start_splash: -10none

I also tried this as root:
splashy test

It shows the splash screen for a second and then crashes with:

commandline read: splashy
commandline read: test
Splashy ERROR: Couldn't splashy_start_splashy(). Error -10
Comment 9 Felix Jara 2011-03-17 19:21:25 UTC
I have the same problem with hibernation option (Hibernation work, but don't show splash).

Error:
splashy_start_splash: -10none
Comment 10 Holger Macht 2011-03-18 10:34:26 UTC
*** Bug 680631 has been marked as a duplicate of this bug. ***
Comment 11 Sergey - 2011-03-19 13:23:09 UTC
It dumps core on "splashy test".
--------------------------------
rm -f core
ulimit -c 9999
splashy test
sleep 2
gdb /usr/sbin/splashy core
------------------------------
Core was generated by `splashy test'.
Program terminated with signal 11, Segmentation fault.
#0  0x00000021 in ?? ()
(gdb) bt
#0  0x00000021 in ?? ()
#1  0xb77c4eff in splashy_stop_splash () at splashy_video.c:1356
#2  0x08049f92 in cmd_exit (args=0x0) at splashy_functions.c:298
#3  0x0804b15f in splashy_child_exit () at splashy_functions.c:1332
#4  0x08049c88 in main (argc=2, argv=0xbf8542d4) at splashy_main.c:154
(gdb) fr 1
#1  0xb77c4eff in splashy_stop_splash () at splashy_video.c:1356
1356                    video.ev_buffer->Release (video.ev_buffer);     /* input buffer */
(gdb) list
1351             * Also release textarea ? 
1352             */
1353            if (video.ev_buffer)
1354            {
1355                    DEBUG_PRINT ("Releasing %s\n", "ev_buffer");
1356                    video.ev_buffer->Release (video.ev_buffer);     /* input buffer */
1357            }
1358            if (video.keyboard)
1359            {
1360                    DEBUG_PRINT ("Releasing %s\n", "keyboard");
(gdb)
Comment 12 Alexander notavailable 2011-04-11 14:17:36 UTC
The issue remains; please fix it.
Comment 13 Forgotten User Xl7iAZAFUm 2011-05-04 13:20:19 UTC
I face with this bug too, but for me hibernate to disk does not work at all, even with "--force" option.
Comment 14 Lucas Christian 2011-05-09 05:12:19 UTC
I can confirm this issue still exists in Splashy version 0.3.13-20.1.  I have a clean install.
Comment 15 Holger Macht 2011-05-17 08:49:56 UTC
Ok, sorry guys, I thought I'll find the time to look into this (which is quite time consuming to debug), but I realize I don't. I've seen this working in openSUSE Factory, so it doesn't seem to be a generic bug which needs fixing for the future. The general hibernate behaviour is not affected by this bug, so it is rather cosmetic. So sorry again, closing as WONTFIX.
Comment 16 Bruno Friedmann 2011-05-17 10:34:33 UTC
I'm waiting the last rebuild of factory synchronized here.
But test last week and yesterday, I saw at each time the -10 error.

I understand the won't fix, but that's only valid if we have plymooth :-)
Comment 17 Holger Macht 2011-05-18 11:26:11 UTC
There seems to be a submit request to openSUSE:Factory (not accepted yet):


Tue May  3 12:31:23 CEST 2011 - jslaby@suse.de

- fix gcc 4.6 build
- splashy exits prematurely fix


So it seems a fix is on its way for Factory.
Comment 18 David Sterba 2011-09-07 10:34:19 UTC
The factory version does not fix this. I don't understand how the fix

https://build.opensuse.org/package/view_file?file=splashy-exits-prematurely-fix.patch&package=splashy&project=openSUSE%3AFactory&srcmd5=be0414ca07dcc4381c5c3481879c70fb

could have ever worked, it modifies a file which is removed during install:

--- a/scripts/initramfs-tools/scripts/local-premount/splashy
+++ b/scripts/initramfs-tools/scripts/local-premount/splashy
-grep -q '\(VESA\|VGA\)' /proc/fb || exit
+# newer kernels use inteldrmfb. allowing splashy to fail
+# if framebuffer is not set might be a better option:
+# users can actually see an error and report this to us
+#grep -q '\(VESA\|VGA\)' /proc/fb || exit

spec:
%install
...
rm -rf .%{_datadir}/initramfs-tools
Comment 19 David Sterba 2011-09-07 10:37:05 UTC
There is another fix in splashy.git, but it also modifies the same file

http://anonscm.debian.org/gitweb/?p=splashy/splashy.git;a=commit;h=7fb92a888a53a4efd4d240e87d539bea8bc829c0

--- a/scripts/initramfs-tools/scripts/local-premount/splashy
+++ b/scripts/initramfs-tools/scripts/local-premount/splashy
@@ -35,3 +35,4 @@ test $SPLASH = "true" || exit
 grep -q '\(VESA\|VGA\)' /proc/fb || exit
 
 /sbin/splashy boot
+sleep 0.5
Comment 20 David Sterba 2011-09-07 11:33:39 UTC
So it's problem with directfb and fonts:

int
splashy_start_splash ()
{
...
        if (init_font () < 0)
        {
                splashy_stop_splash ();
                return -10;
        }
...
}

disabling font init does not crash anymore and is not needed for the default theme.

--- src/splashy_video.c 2008-12-24 17:14:55.000000000 +0100
+++ src/splashy_video.c.nofont  2011-09-07 13:17:59.873000244 +0200
@@ -1316,6 +1316,7 @@ splashy_start_splash ()

         draw_progressbar ();

+/*
         if (init_font () < 0)
         {
                 splashy_stop_splash ();
@@ -1323,6 +1324,7 @@ splashy_start_splash ()
         }

         start_text_area ();
+*/

         return 0;
 }

Fine for me and I'm very glad my son will not be disappointed by not seeing the penguing during suspend.
Comment 21 Holger Macht 2011-09-19 12:14:43 UTC
If someone who is seeing this problem on his machine could please mv /etc/fb.modes /tmp and try again? Would be interesting to know if this also fixes the problem, we had this in the past.
Comment 22 Alexander notavailable 2011-09-19 15:08:23 UTC
(In reply to comment #21)
> If someone who is seeing this problem on his machine could please mv
> /etc/fb.modes /tmp and try again? Would be interesting to know if this also
> fixes the problem, we had this in the past.

No, it doesn't work.

So, how can I solve the problem for openSUSE 11.4?
Comment 23 Holger Macht 2011-09-21 09:41:42 UTC
For what it's worth, I've built a workaround package without the font initialization code as described in comment #20. It can be found in my home repository here:

http://download.opensuse.org/repositories/home:/hmacht:/branches:/openSUSE:/11.4:/Update:/Test/standard/

However, this is no real fix because it might only work with a limited number of themes (it should with the standard thime). I won't persue any further fix for 11.4, though, sorry.
Comment 24 Alexander notavailable 2011-09-21 12:52:43 UTC
Ok, thanks Holger Macht, now it seems work fine.
However, on resume, I don't see splashy but bootsplash. This was a problem in openSUSE 11.3 too.
Comment 25 Christoph G 2011-11-20 11:31:31 UTC
This problem is still in 12.1.
Comment 26 Forgotten User --EoyBps8f 2011-11-20 11:45:24 UTC
It's some config file I guess. I zypper duped my 11.4 to 12.1 and had the same issue. After that I formatted / and re-installed. It worked once and after that the same error.
Comment 27 Jared Meidal 2011-11-20 17:06:28 UTC
I would love to see a fix method for this, I'm having this issue also, with 12.1 and splashy/splashy-branding-OpenSUSE 0.3.13-29.1.2

Thank you!
Comment 28 Alexander notavailable 2011-11-21 18:19:51 UTC
In openSUSE 11.4 with the repo

http://download.opensuse.org/repositories/home:/hmacht:/branches:/openSUSE:/11.4:/Update:/Test/standard/

splashy is perfect, both in hibernate and in thaw .

In openSUSE12.1 there isn't the repo hmacht:branches?
Comment 29 Holger Macht 2011-11-22 17:13:56 UTC
I could build the package from there for 12.1, too. And ideed, it could contain a possible fix. Have you tried the package from there on your 12.1? Could be worth a try...
Comment 30 Jared Meidal 2011-11-22 20:12:22 UTC
hmacht: that worked for me in 12.1!
now using splashy-0.3.13-22.1.i586
Thank you!

I look forward to seeing this fix merged with the standard repos.

I currently get the sleeping penguin, rather than the OpenSUSE-branding, but it's better now than CLI errors.
Comment 31 Alexander notavailable 2011-11-22 20:46:21 UTC
Ok, with splashy from 
http://download.opensuse.org/repositories/home:/hmacht:/branches:/openSUSE:/11.4:/Update:/Test/standard/
openSUSE_12.1 works very well, both in hibernate and in thaw.

Then, with

# splashy_config -s openSUSE
# mkinitrd

I get openSUSE theme.

So, it's fantastic, congratulations Holger Macht :)
Comment 32 Holger Macht 2011-11-23 14:39:40 UTC
Can you please also try the packages from http://download.opensuse.org/repositories/home:/hmacht:/branches:/openSUSE:/12.1:/Update/openSUSE_12.1/

Those are the 12.1 packages with the one patch that hopefully seems to fix the issue. Thanks.
Comment 33 Bruno Friedmann 2011-11-23 15:07:23 UTC
Why I didn't see an update anything for Factory ?
Comment 34 Holger Macht 2011-11-23 15:13:46 UTC
The patch just slipped through. So if anybody confirms it working in 12.1 or Factory where it didn't work before, I will submit this to Factory and as an online update for 12.1.
Comment 35 Alexander notavailable 2011-11-23 15:22:49 UTC
(In reply to comment #32)
> Can you please also try the packages from
> http://download.opensuse.org/repositories/home:/hmacht:/branches:/openSUSE:/12.1:/Update/openSUSE_12.1/
> 
> Those are the 12.1 packages with the one patch that hopefully seems to fix the
> issue. Thanks.

Ok all good for me.
Comment 36 Holger Macht 2011-11-24 13:42:27 UTC
So reopening to push the update for 12.1
Comment 37 Andreas Jaeger 2011-12-06 14:47:48 UTC
Asking for an update...
Comment 38 Holger Macht 2011-12-07 08:45:39 UTC
I hope to submit today, tomorrow at the latest.
Comment 39 Holger Macht 2011-12-08 11:49:01 UTC
Ok, the fix in this bug (comment 32) seems to work for some, but breaks the resume for others, as seen in bug 715967. So this can't be pushed for an online update and can just be seen as a workaround package for those systems where it works.

So I'm closing this as WONTFIX again, because there are a couple of other related open bugs (bnc#715967,bnc#728656,bnc#730050.
Comment 40 Alexander notavailable 2011-12-09 02:37:32 UTC
Ok... However thanks for your work.