Bug 677007

Summary: yast2 --gtk firewall segfaults
Product: [openSUSE] openSUSE 11.4 Reporter: Bernhard Wiedemann <bwiedemann>
Component: YaST2Assignee: Michael Meeks <mmeeks>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Critical    
Priority: P5 - None CC: badshah400, forgotten_h13THG8RK1, meissner, mmeeks, vuntz
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: Other   
Whiteboard: .
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Deadline: 2011-04-20   
Attachments: yast2 logs

Description Bernhard Wiedemann 2011-03-04 15:11:30 UTC
yast2 --gtk firewall segfaults in Allowed Services of Internal Zone

Steps To Reproduce:
1. have any fresh 11.4 GNOME install
2. run as root yast2 --gtk firewall
=> Allowed Services
=> Selected Zone = Internal Zone

Actual Results:
YaST2 segfaults

Expected Results:
ncurses and qt versions work fine there. So should gtk.

Reproducible: Always
Comment 1 Bernhard Wiedemann 2011-03-04 15:12:50 UTC
Created attachment 417598 [details]
yast2 logs
Comment 2 Forgotten User h13THG8RK1 2011-03-04 16:04:31 UTC
Bernhard, you had previously reported this bug as bug 670625.

What version of the gtk plugin are you using?

$ rpm -q yast2-gtk
Comment 3 Bernhard Wiedemann 2011-03-04 16:26:52 UTC
# rpm -q yast2-gtk
yast2-gtk-2.21.92-3.1.i586

# rpm -q --changelog yast2-gtk | head
* Fri Feb 11 2011 rpmcruz@alunos.dcc.fc.up.pt
- 2.21.92
- fixed freeze in webpin search tool, and possibly others
  (bnc#670625).
Comment 4 Forgotten User h13THG8RK1 2011-03-04 21:26:56 UTC
I was able to reproduce the crash when choosing "Internal Zone" from the combo-box within "Allowed Services".

If you can, it would be great if you could try the fix:

https://build.opensuse.org/package/show?package=yast2-gtk&project=YaST%3AHead

We'll want to emit a patch for this one -- in which case, please re-assign if you're happy with the fix.
Comment 5 Bernhard Wiedemann 2011-03-06 07:58:25 UTC
no more segfault with YaST:Head yast2-gtk
Comment 6 Forgotten User h13THG8RK1 2011-03-06 19:58:36 UTC
Guys, we probably want to issue an update for this one.
Comment 8 Marcus Meissner 2011-03-31 12:49:41 UTC
if an update is needed, NEEDINFO maintenance@opensuse.org
Comment 9 Forgotten User h13THG8RK1 2011-03-31 13:17:05 UTC
Thanks Marcus. Allow me a couple of days to push the fix to the 11_4 branch...
Comment 10 Forgotten User h13THG8RK1 2011-03-31 23:20:49 UTC
Okay, backported the fix to yast2 11_4 branch:
http://svn.opensuse.org/svn/yast/branches/SuSE-Linux-11_4-Branch/

(Hey Atri, we got a situation here. I already submitted a fixed package to Factory for this crash. But that package contains a couple of changes to strings. Do you think you could create a package, out of the svn repo I mentioned, for the maintenance guys? I already bumped the version files, and updated the changelog.)
Comment 11 Atri Bhattacharya 2011-04-01 00:46:39 UTC
Fixed packages are in the build service project home:badshah400:branches:openSUSE:11.4:Update:Test if anyone is inclined to test.

Requesting maintenance for an update: please note this is a version update (2.21.92 -> 2.21.93) that fixes the crash.
Comment 12 Christian Dengler 2011-04-04 17:41:01 UTC
Update contains only bugfixes:
+Fri Apr 01 00:09:00 WET 2011 - rpmcruz@alunos.dcc.fc.up.pt
+
+- 2.21.93
+- backport trunk fixes:
+- firewall tool crash fix (bnc#677007).
+- refer to LibreOffice rather than OpenOffice.org in help text
+  (bnc#675486).

So no problem (for an update +1)
Comment 13 Forgotten User h13THG8RK1 2011-04-04 18:34:57 UTC
+- refer to LibreOffice rather than OpenOffice.org in help text
+  (bnc#675486).

Ups, this line shouldn't have made it to the changelog. My bad.

"OpenOffice.org" is referred in the help text, and we changed it to "LibreOffice". I did _not_ apply this fix to the 11.4 backport, since it would mess with the i18n. This update package refers only to this one crash fix, as reported here.

Should we fix the changelog, or...?
Comment 14 Atri Bhattacharya 2011-04-04 19:00:22 UTC
I have removed that line from the changelog now. We are ready to submit for consideration of online-update (I think we need one more +1?).
Comment 15 Marcus Meissner 2011-04-06 12:26:58 UTC
lets do the update, yes. +1
Comment 16 Swamp Workflow Management 2011-04-06 18:07:20 UTC
The SWAMPID for this issue is 39999.
This issue was rated as moderate.
Please submit fixed packages until 2011-04-20.
Also create a patchinfo file using this link:
https://swamp.suse.de/webswamp/wf/39999
Comment 17 Christian Dengler 2011-04-06 18:08:09 UTC
(In reply to comment #14)
> I have removed that line from the changelog now. We are ready to submit for
> consideration of online-update (I think we need one more +1?).

Thanks!

Update started. Be so kind and submit the fixed sources against the update-test repo.
Comment 18 Christian Dengler 2011-04-08 14:38:16 UTC
There is also the wrong changelog entry in the file "view package/yast2-gtk.changes". Can you adjust it?
Comment 19 Swamp Workflow Management 2011-04-18 10:31:07 UTC
Update released for: yast2-gtk, yast2-gtk-debuginfo, yast2-gtk-debugsource
Products:
openSUSE 11.4 (debug, i586, x86_64)
Comment 20 Christian Dengler 2011-04-18 10:32:29 UTC
update released.