Bug 679287

Summary:	mingetty printing "Hint:" logic is faulty
Product:	[openSUSE] openSUSE 11.4	Reporter:	Marcus Meissner <meissner>
Component:	Basesystem	Assignee:	Dr. Werner Fink <werner>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	Markus.Elfring, meissner, thom-s
Version:	Final
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:	.
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Deadline:	2011-04-12

Description Marcus Meissner 2011-03-14 08:49:36 UTC

mingetty prints 

Hint: 

before every login prompt.

This comes from mingetty.c, around line 476 and is meant to print 
caps lock/num lock/scroll lock hints.

it should print "Hint:" only when one of them is set I think?

Comment 1 Thomas Siedentopf 2011-03-14 09:04:51 UTC

may it be related to the keyboard type and/or some BIOS setting?

Three machines here:

1 - VMware virtual machine
2 - bare metal machine with Apple Aluminium USB keyboard
3 - bare metal machine with PS/2 keyboard (also checked with USB keyboard)

machine 1 and 3 do not show this behaviour while machine 2 does.

Additionaly the machanism seems to be broken because:

"Hint: Num Lock on, Caps Lock on"
will show up when only CAPS LOCK is set (would expect "Hint: Num Lock off, Caps Lock on" here) and:

"Hint: Num Lock onCaps Lock on" will show up when CAPS LOCK and NUM LOCK is set (would expect "Hint: Num Lock on, Caps Lock on" here)

Comment 2 Dr. Werner Fink 2011-03-14 09:25:02 UTC

(In reply to comment #0)

Do you really see an empty "Hint:" ?

Comment 3 Marcus Meissner 2011-03-14 09:52:07 UTC

yes I do.

/var/run/numlock-on  is present btw.

Comment 4 Thomas Siedentopf 2011-03-14 12:56:15 UTC

comment #2: me also. reproducable - made two installations on the same machine.

Comment 5 Dr. Werner Fink 2011-03-14 13:05:08 UTC

osc build is running, have a look in a few minutes at

   http://download.opensuse.org/repositories/Base:/System/openSUSE_11.4/

for a mingetty package.  Please test out and return feedback

Comment 6 Marcus Meissner 2011-03-14 13:28:13 UTC

*** Bug 679323 has been marked as a duplicate of this bug. ***

Comment 7 Thomas Siedentopf 2011-03-14 14:09:44 UTC

will check tonight - at least the output on machine 3 (see comment #1) is correct now.

Comment 8 Thomas Siedentopf 2011-03-15 06:41:38 UTC

works for me on all machines now. Thanks for fixing this that fast!

Comment 9 Marcus Meissner 2011-03-15 06:46:20 UTC

it no longer shows Hint: for me too, so its fixed for me.

Comment 10 Dr. Werner Fink 2011-03-15 08:18:57 UTC

Then the question is: do we need an update?

Comment 11 Dr. Werner Fink 2011-03-15 12:27:32 UTC

request id 64182

Comment 12 Christian Dengler 2011-03-15 12:53:06 UTC

+1

Update started. SwampID: 39388

Comment 13 Dr. Werner Fink 2011-03-15 13:00:36 UTC

patchinfo submitted
package submitted

Comment 14 Swamp Workflow Management 2011-03-15 13:45:49 UTC

The SWAMPID for this issue is 39388.
This issue was rated as low.
Please submit fixed packages until 2011-04-12.
Also create a patchinfo file using this link:
https://swamp.suse.de/webswamp/wf/39388

Comment 15 Swamp Workflow Management 2011-03-23 17:44:26 UTC

Update released for: mingetty, mingetty-debuginfo, mingetty-debugsource
Products:
openSUSE 11.4 (debug, i586, x86_64)