Bug 682608

Summary:	YaST remote (VNC) doesn't open firewall ports (again :))
Product:	[openSUSE] openSUSE 11.4	Reporter:	Katarina Machalkova <kmachalkova>
Component:	YaST2	Assignee:	Martin Vidner <mvidner>
Status:	RESOLVED INVALID	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None
Version:	Final
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	patch -- just for reference

Description Katarina Machalkova 2011-03-25 10:41:41 UTC

Since the corresponding service changed the name again (xorg-x11-Xvnc now, xorg-x11-server before), obviously without letting YaST maintainers know about it, requesting opening ports in firewall in YaST remote admin. module does nothing. 
I'll attach a trivial patch fixin' the issue shortly

Comment 1 Katarina Machalkova 2011-03-25 10:51:26 UTC

Created attachment 421392 [details]
patch -- just for reference

Comment 2 Martin Vidner 2011-04-07 12:15:36 UTC

Thanks for the report and the patch!

But, er, now that I've tried to reproduce the bug, I noticed that in 11.4, x11-xorg-Xvnc.rpm still contains the old file: /etc/sysconfig/SuSEfirewall2.d/services/xorg-x11-server . And "yast2 remote" does open ports 5801 5901 as it should.

I have tested on a clean VM installed from the KDE live cd.

So I wonder how you got the differently named file on your system? What actually behaved differently than you expected?

Comment 3 Katarina Machalkova 2011-04-07 12:53:33 UTC

I've no '/etc/sysconfig/SuSEfirewall2.d/services/xorg-x11-server' on my 11.4 system, just '/etc/sysconfig/SuSEfirewall2.d/services/xorg-x11-Xvnc'

{
## Name: VNC Server
## Description: Opens ports for VNC Server
TCP="5801 5901"
}

kmachalkova@dhcp81:~> rpm -qf /etc/sysconfig/SuSEfirewall2.d/services/xorg-x11-Xvnc
xorg-x11-Xvnc-0.1-2.1.x86_64

> So I wonder how you got the differently named file on your system? What
> actually behaved differently than you expected?

No idea how I got differently named file (that'd be question for xorg maintainers, likely). But since I have it, and y2-remote is looking for xorg-x11-server and doesn't find it, it doesn't open 5801 and 5901 ports in fw.

Comment 4 Martin Vidner 2011-04-07 13:07:32 UTC

`zypper se -s xorg-x11-Xvnc` shows me a package from the OSS repo at version 7.6_1.9.3-15.18.4 (wow!) while your 0.1-2.1 looks highly suspicious. Whence?

Comment 5 Martin Vidner 2011-04-13 14:32:50 UTC

Sorry, I think you got some outdated package there. I've reverted your patch in SVN: http://svn.opensuse.org/viewcvs/yast?rev=63773&view=rev

Please reopen if the package came from a source where it could affect more users.