Bug 686619

Summary: yast2-snapper should correctly restore directories
Product: [openSUSE] openSUSE 12.1 Reporter: Jiří Suchomel <jsuchome>
Component: YaST2Assignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: aschnell
Version: Factory   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Jiří Suchomel 2011-04-11 14:27:52 UTC
yast2-snapper should use libsnapper rollback call instead of simple 'cp' call
Comment 1 Jiří Suchomel 2011-04-14 07:02:26 UTC
Actually, I'm not sure if it will be better than 'cp to current system'.

If I understand it correct, File object needs to be initialized from Comparison and than I can call doRollback on File(s). But for the way yast2-snapper offers 'restoring files', comparing whole original snapshot to current system is not necessary, user just picks files he wants to have replaced by some old version. This is lot faster; generating Comparison object relative to current system takes quite a lot of time.

So I'd rather stay with cp, although I probably have to solve directories some better way. And of course escape strings.
Comment 2 Arvin Schnell 2011-04-14 12:40:44 UTC
I see. I didn't have the action you mention in mind when I developed
snapper. That action would be performed by selecting a single snapshot
and then restoring.
Comment 3 Jiří Suchomel 2011-04-14 13:23:55 UTC
(In reply to comment #2)
> I see. I didn't have the action you mention in mind when I developed
> snapper. That action would be performed by selecting a single snapshot
> and then restoring.

Actually, single file.
Comment 4 Jiří Suchomel 2011-04-15 11:56:06 UTC
Fixed yast2-snapper-2.21.3
Comment 5 Bernhard Wiedemann 2011-04-15 12:00:08 UTC
This is an autogenerated message for OBS integration:
This bug (686619) was mentioned in
https://build.opensuse.org/request/show/67507
Comment 6 Bernhard Wiedemann 2011-04-28 12:00:35 UTC
This is an autogenerated message for OBS integration:
This bug (686619) was mentioned in
https://build.opensuse.org/request/show/67683