Bug 686639

Summary:	yast2-snapper is slow for large file lists
Product:	[openSUSE] openSUSE 12.1	Reporter:	Arvin Schnell <aschnell>
Component:	YaST2	Assignee:	Jiří Suchomel <jsuchome>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	aschnell, gs, tgoettlicher
Version:	Factory
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Arvin Schnell 2011-04-11 15:42:52 UTC

yast2-snapper is slow for large file lists. E.g. installing texlive
results in a file list with more than 10000 entries. After selecting
the snapshot in the UI it takes more than 1 minute to have the next
dialog usable.

Tested with Qt and ncurses UI.

Comment 1 Jiří Suchomel 2011-04-12 07:16:05 UTC

I'll need to build the tree by parts, not whole at the beginning.

Is libsnapper able to return the diff somehow (tree) structured, not just list of changed files?

Comment 2 Arvin Schnell 2011-04-12 14:14:31 UTC

I have added a function in the snapper agent that generates a YCPMap
containing the tree.

Comment 3 Jiří Suchomel 2011-04-13 07:13:08 UTC

Thanks. I also added function to generate file index, so now the changes are also shown.


However, there's one more problem with the speed: tree widget handling when clicking on directory checkboxes. How does it behave for you, when you click eg. on '/usr' (directory with lots of items below)?

It's terribly slow for my (slow) virtual machine scenario, and the reason is that new tree state (checked and unchecked items) is computed in YCP, although I think such behavior should be part of Tree widget implementation.

Comment 4 Arvin Schnell 2011-04-14 08:44:28 UTC

That is also very slow for me (I also test in a virtual machine).

Another thing I noticed is that the visible area of the tree can move
when clicking a checkbox.

Comment 5 Jiří Suchomel 2011-04-14 08:49:55 UTC

Thomas, please see comments 3 and 4. Could you reconsider your stance on Tree widget? I think it would need an improvement.

Comment 6 Bernhard Wiedemann 2011-04-15 12:00:16 UTC

This is an autogenerated message for OBS integration:
This bug (686639) was mentioned in
https://build.opensuse.org/request/show/67507

Comment 7 Thomas Göttlicher 2011-04-15 14:37:37 UTC

yast2-qt 2.20.8 supports `recursiveSelection for tree widgets now.
Gabi could you please add support for yast2-ncurses?

Comment 9 Gabriele Mohr 2011-04-20 08:28:32 UTC

yast2-ncurses-2.21.1 supports `recursiveSelection for tree widgets
(the package is submitted to Factory).

Comment 10 Bernhard Wiedemann 2011-04-28 12:00:45 UTC

This is an autogenerated message for OBS integration:
This bug (686639) was mentioned in
https://build.opensuse.org/request/show/67683