Bug 743133

Summary:	cifs-utils: setuid binaries need to be position independent
Product:	[openSUSE] openSUSE 12.2	Reporter:	Ludwig Nussel <lnussel>
Component:	Other	Assignee:	Forgotten User b5BnQSUi71 <forgotten_b5BnQSUi71>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	security-team
Version:	Factory
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	744091

Description Ludwig Nussel 2012-01-24 15:50:21 UTC

cifs-utils triggered the rpmlint check
"non-position-independent-executable" which means there are one or
more binaries that need to be compiled as position independent
executable.

To fix the issue add -fPIE to CFLAGS and -pie to LDFLAGS of the
binaries in question.

Comment 1 Daniel Lovasko 2012-02-06 09:19:48 UTC

fixed with submit 102839

Comment 2 Forgotten User b5BnQSUi71 2012-02-06 10:38:33 UTC

Daniel: what are the reasons for using -fpie instead of -fPIE for CFLAGS?

--snip--
-export CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE"
+export CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE -fpie"

--end-snip--

Comment 3 Daniel Lovasko 2012-02-06 11:00:37 UTC

On x86 systems -fPIC and -fpic are exactly the same. Ditto with -fPIE and -fpie.

Comment 4 Forgotten User b5BnQSUi71 2012-02-06 11:16:34 UTC

Ok, thanks for the patch.

Please note that for the cifs-utils package the changelog format we follow is 
"- <changelog>; (bnc#id)." and it would be nice to follow the same format for future changes.

Comment 5 Bernhard Wiedemann 2012-02-15 12:00:57 UTC

This is an autogenerated message for OBS integration:
This bug (743133) was mentioned in
https://build.opensuse.org/request/show/105190 Factory / cifs-utils

Comment 6 Daniel Lovasko 2012-02-15 12:04:43 UTC

Suresh: i am sorry, it was one of my first bugfixes, next time wont happen :)

Comment 7 Bernhard Wiedemann 2012-02-22 14:00:14 UTC

This is an autogenerated message for OBS integration:
This bug (743133) was mentioned in
https://build.opensuse.org/request/show/106457 11.4 / cifs-utils