Bug 744820

Summary:	iscsi restart kills iscsi sessions
Product:	[openSUSE] openSUSE 12.1	Reporter:	Mendel Mobach <mendel>
Component:	Other	Assignee:	Jain Ankit <jankit>
Status:	VERIFIED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Critical
Priority:	P5 - None	CC:	alx, brammuffin-2way, dvaleev, forgotten_ToNzP6iHCC, hare, jkosina
Version:	Final
Target Milestone:	Final
Hardware:	x86-64
OS:	openSUSE 12.1
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:	656119
Bug Blocks:

Description Mendel Mobach 2012-02-02 15:38:45 UTC

Damn. It was fixed in opensuse 11.4, now the bug is back in opensuse 12.1.

Please put this fix in open-iscsi. It's not that hard, you've done it before:

https://build.opensuse.org/package/view_file?file=open-iscsi-fix-sysfs-get-value-null&package=open-iscsi.openSUSE_11.4&project=home%3Ajankit%3Abranches%3AOBS_Maintained%3Aopen-iscsi&rev=32dcc9b919adae36f765da970de0bdf0

collector:/usr/src/packages/BUILD/open-iscsi-2.0-870-rc1 # patch -p1 < /usr/src/packages/SOURCES/stupid-fix.patch
patching file usr/iscsi_sysfs.c
Hunk #1 succeeded at 43 (offset 2 lines).
Hunk #2 succeeded at 86 (offset 2 lines).


and please send out an update. The source of the problem and the solution of the problem is still the same.

Thankfully renaming boot.open-iscsi to boot.iscsid-early also breaks the startup during boot of iscsid. This keeps some servers alive for a few more moments. (This might be seen as a bug, but since the bugs are creeping back from under the rocks I do like this startup behaviour as a feature).

Thanks in advance for putting out new packages in the update repositories. And please also fix it in the next releases.

Comment 1 Mendel Mobach 2012-02-09 11:08:08 UTC

Also here is a nice patch for the makefile to make it build on systems where open-iscsi is installed. HTH - HAND

--- Makefile.org        2012-02-09 11:50:58.000000000 +0100
+++ Makefile    2012-02-09 11:51:57.000000000 +0100
@@ -105,7 +105,7 @@
        $(INSTALL) -m 644 $^ $(DESTDIR)$(etcdir)/iscsi/ifaces
 
 install_etc: $(ETCFILES)
-       if [ ! -f /etc/iscsi/iscsid.conf ]; then \
+       if [ ! -f $(DESTDIR)$(etcdir)/iscsi/iscsid.conf ]; then \
                $(INSTALL) -d $(DESTDIR)$(etcdir)/iscsi ; \
                $(INSTALL) -m 644 $^ $(DESTDIR)$(etcdir)/iscsi ; \
        fi
@@ -118,11 +118,11 @@
        $(MAKE) -C kernel install_kernel
 
 install_iname:
-       if [ ! -f /etc/iscsi/initiatorname.iscsi ]; then \
-               echo "InitiatorName=`/sbin/iscsi-iname`" > /etc/iscsi/initiatorname.iscsi ; \
+       if [ ! -f $(DESTDIR)$(etcdir)/iscsi/initiatorname.iscsi ]; then \
+               echo "InitiatorName=`/sbin/iscsi-iname`" > $(DESTDIR)$(etcdir)/iscsi/initiatorname.iscsi ; \
                echo "***************************************************" ; \
-               echo "Setting InitiatorName to `cat /etc/iscsi/initiatorname.iscsi`" ; \
-               echo "To override edit /etc/iscsi/initiatorname.iscsi" ; \
+               echo "Setting InitiatorName to `cat $(DESTDIR)$(etcdir)/iscsi/initiatorname.iscsi`" ; \
+               echo "To override edit $(DESTDIR)$(etcdir)/iscsi/initiatorname.iscsi" ; \
                echo "***************************************************" ; \
        fi

Comment 2 Chao Wei 2012-04-09 14:32:15 UTC

Hi Jain,

Assign this bug to you since you've done it before. thanks for your help!

Comment 3 Jain Ankit 2013-08-29 06:47:44 UTC

Product not supported anymore.