Bug 768624

Summary:	inst_extrasources.ycp vs inst_addon_update_sources.ycp
Product:	[openSUSE] openSUSE 12.2	Reporter:	Ludwig Nussel <lnussel>
Component:	YaST2	Assignee:	Jiří Suchomel <jsuchome>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	coolo
Version:	Factory
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	y2logs patch for /usr/share/YaST2/clients/inst_addon_update_sources.ycp

Description Ludwig Nussel 2012-06-25 08:59:50 UTC

After installation (ftp) one get the following repos:

Aktualisierungen-für-openSUSE-12.2-12.2-1.16.repo
openSUSE-12.2-12.2-1.16.repo
repo-debug.repo
repo-debug-update.repo
repo-non-oss.repo
repo-oss.repo
repo-source.repo

The first two were added by inst_addon_update_sources.ycp and the latter ones by inst_extrasources.ycp. The first repo should actually be named "repo-update.repo" according to control.xml. The second repo is redundant with repo-oss.

Comment 1 Jiří Suchomel 2012-07-02 09:20:27 UTC

Log files?

Comment 2 Ludwig Nussel 2012-07-02 14:11:56 UTC

I already looked up the source code responsible for adding the repos for you. What other information do you need from the log files?

Comment 3 Jiří Suchomel 2012-07-02 14:25:24 UTC

I want to get touch with the code. See the metadata that are used there and which arguments are used incorrectly or which code check is missing.

I expect to find that in log files.

Comment 4 Ludwig Nussel 2012-07-02 14:34:57 UTC

Created attachment 497118 [details]
y2logs

Comment 5 Jiří Suchomel 2012-07-02 15:32:28 UTC

The name for 1st repo is generated as described in bug 542792:

Updates for <product> <version>

It's alias ID that is missing, and that is indeed not read from control file.

Comment 6 Jiří Suchomel 2012-07-02 16:04:44 UTC

inst_addon_update_sources.ycp is adding sources defined by 'update_urls' of each product (esp. Add-Ons, but not only). This has nothing to do with control.xml

inst_extrasources.ycp, on the other hand, adds the sources defined in control.xml.


So far, I see these possible solutions:

1. do not check for base product in inst_addon_update_sources step
2. switch the order of these 2 steps, so 1st would be predefined sources, and only later possibly the ones from proucts (if they are not registered already).


2 is easier code-wise, but I'm not sure if we'd not run into some other problem...

Comment 7 Jiří Suchomel 2012-07-04 05:51:56 UTC

Ludwig, could you try second option, switching steps in control file?

If not during normal installation, you can do it in /etc/YaST/control.xml of installed system, delete your current repositories, touch /var/lib/YaST/runme_at_boot and run 2nd stage again...

Comment 8 Ludwig Nussel 2012-07-05 12:51:05 UTC

Switching the two modules via control.xml results in repo-update indeed.
That doesn't really fix the issue of yast picking a rather inconvenient alias for the repo though. What about setting the alias of the repo according to the 'name' tag of the url and only using the generated pretty name for the 'name' tag of the repo?

Comment 9 Jiří Suchomel 2012-07-09 11:13:15 UTC

Created attachment 497772 [details]
patch for /usr/share/YaST2/clients/inst_addon_update_sources.ycp

Try patching inst_addon_update_sources.ycp and see if this result is good enough.


(It should create repo with 'update-openSUSE-12.2' alias)

Comment 10 Ludwig Nussel 2012-07-11 13:50:58 UTC

better than the translated string before I guess.

Comment 11 Jiří Suchomel 2012-07-12 06:13:49 UTC

than it is fixed

Comment 12 Bernhard Wiedemann 2012-07-12 07:00:15 UTC

This is an autogenerated message for OBS integration:
This bug (768624) was mentioned in
https://build.opensuse.org/request/show/127695 Factory / yast2-installation