|
Bugzilla – Full Text Bug Listing |
| Summary: | xf86-video-nv: ppc patch | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 12.2 | Reporter: | Marcus Meissner <meissner> |
| Component: | X.Org | Assignee: | E-mail List <xorg-maintainer-bugs> |
| Status: | RESOLVED WONTFIX | QA Contact: | E-mail List <xorg-maintainer-bugs> |
| Severity: | Normal | ||
| Priority: | P3 - Medium | CC: | dvaleev, schwab |
| Version: | Final | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
I assume the check exists since nouveau driver (KMS) and nvidia driver (proprietary) conflicts with nv driver (UMS). Don't know, why Andreas removed it. Maybe there is no nouveau KMS available on ppc. For sure there is no nvidia proprietary driver available for PPC. IMH the patch is *not* acceptable in this form. Andreas, could you explain what's the issue here on ppc? Thanks. On non-legacy platforms there is always a framebuffer driver claming the device, so the check is useless for checking for KMS. (In reply to comment #3) > On non-legacy platforms there is always a framebuffer driver claming the > device, so the check is useless for checking for KMS. Maybe on ppc with the native framebuffer drivers enabled. It is not on %ix86/x86_64, where these are disabled and only generic framebuffer is enabled. Of course with KMS you now have native framebuffers as well. %ix86/x86_64 isn't non-legacy. Still I'm not interested in breaking non-ppc platforms. Do you think this check has been introduced just for fun? I've never intented to submit the patch as is. LOL. I cannot easily integrate it seperately (ppc specific) into openSUSE:12.2:PowerPC, as this package has received online updates already :/ so if this is required for ppc machines to work, we need to find a acceptable upsrteam solzution. openSUSE 12.2 is no longer supported. Hence the issue won't be fixed for this product. In case the issue still is reproducable with a supported product (openSUSE 12.3/13.1 at the moment) or with openSUSE:Factory, please feel free to reopen. Thanks. |
done by andreas schwab. not sure why the check for the "nv" kernel driver is removed. Index: xf86-video-nv-probe.diff =================================================================== --- xf86-video-nv-probe.diff (added) +++ xf86-video-nv-probe.diff (revision 2) @@ -0,0 +1,18 @@ +--- xf86-video-nv-2.1.18/src/nv_driver.c ++++ xf86-video-nv-2.1.18/src/nv_driver.c +@@ -912,15 +912,6 @@ NVPciProbe(DriverPtr drv, int entity, st + NVGetPCIXpressChip(dev) : dev->vendor_id << 16 | dev->device_id; + const char *name = xf86TokenToString(NVKnownChipsets, id); + +- if (pci_device_has_kernel_driver(dev)) { +- xf86DrvMsg(0, X_ERROR, +- NV_NAME ": The PCI device 0x%x (%s) at %2.2d@%2.2d:%2.2d:%1.1d has a kernel module claiming it.\n", +- id, name, dev->bus, dev->domain, dev->dev, dev->func); +- xf86DrvMsg(0, X_ERROR, +- NV_NAME ": This driver cannot operate until it has been unloaded.\n"); +- return FALSE; +- } +- + if(dev->vendor_id == PCI_VENDOR_NVIDIA && !name && + !NVIsSupported(id) && !NVIsG80(id)) { + /* See if pci.ids knows what the heck this thing is */