Bug 797245

Summary: Installer crashes with 'Client umount_finish returned invalid data'
Product: [openSUSE] openSUSE Tumbleweed Reporter: Forgotten User OfsFetVrzR <forgotten_OfsFetVrzR>
Component: YaST2Assignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P2 - High CC: aschnell, locilka
Version: 13.1 Milestone 1   
Target Milestone: ---   
Hardware: x86-64   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Forgotten User OfsFetVrzR 2013-01-08 13:30:41 UTC 
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20100101 Firefox/17.0

Installation of the live media crashes with the following error:

2013-01-08 14:24:32 <3> linux.site(2447) [YCP] clients/inst_finish.ycp:297 Missing YCP client: kdump_finish
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 Parameters don't match any declaration:
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 Storage::Umount (/* any -> string */e["device"]:"")
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 Candidates are:
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 global boolean Storage::Umount (string dev, boolean unsetup)
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 Parameters don't match any declaration:
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 Storage::Umount (/* any -> string */e["device"]:"")
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 Candidates are:
2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219 global boolean Storage::Umount (string dev, boolean unsetup)
2013-01-08 14:24:33 <5> linux.site(2447) [liby2] Y2Component.cc(doActualWork):67 component ErrorComponent: stub function Y2Component::doActualWork() called
2013-01-08 14:24:33 <3> linux.site(2447) [YCP] clients/inst_finish.ycp:315 Client umount_finish returned invalid data



Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Comment 1 Jiří Suchomel 2013-01-11 06:58:19 UTC 
(In reply to comment #0)

> Parameters don't match any declaration:
> 2013-01-08 14:24:33 <3> linux.site(2447) [Parser] clients/umount_finish.ycp:219
> Storage::Umount (/* any -> string */e["device"]:"")

Lukas, haven't you adapted Storage.ycp API recently?
Comment 2 Lukas Ocilka 2013-01-11 08:50:47 UTC 
Yes, but it wasn't related.

It was Thomas' change:
https://github.com/yast/yast-storage/commit/38674ad20cca24b98f1da8d6c24d5acdc851339f
Comment 3 Lukas Ocilka 2013-01-11 08:52:19 UTC 
Maybe Storage should have two methods:

  Umount(device)

    and

  Umount(device, unsetup)

and use some sane default if unsetup not defined.
Comment 4 Lukas Ocilka 2013-01-11 08:56:15 UTC 
Hmm, which is impossible except for builtins http://lists.opensuse.org/opensuse-bugs/2012-10/msg03185.html

So, either two different methods, one calls another. Or just broken API.
I'm afraid testsuite should catch such error - bat testsuite in yast2-installation (ycpc check called during build).
Comment 5 Jiří Suchomel 2013-01-11 09:08:09 UTC 
(In reply to comment #4)

> I'm afraid testsuite should catch such error

Yes, seems like y2-installation package should deserve one...
Comment 8 Jiří Suchomel 2013-01-11 10:22:25 UTC 
fixed
Comment 9 Bernhard Wiedemann 2013-01-11 11:00:12 UTC 
This is an autogenerated message for OBS integration:
This bug (797245) was mentioned in
https://build.opensuse.org/request/show/148018 Factory / yast2-installation