Bug 804435

Frederic removed that -- setting needinfo.

BTW: it might be a good idea to replace the DISTRO= variable in openSUSE template by DISTRO=${DISTRO:-@@DISTRO@@} and then do in a %prep or %build

source /etc/os-release
if [[ ${NAME} != "openSUSE" ]]; then
    VERSION_ID="12.2" #<---- or latest? would that work?
fi

sed -e "s/@@DISTRO@@/${VERSION_ID}/" -i templates/lxc-opensuse.in

I saw the SUITE=${SUITE:-squeeze} in debian's template, so I assume the call SUITE="wheezy" lxc-create will install container with wheezy instead.

So I've run it and now I have "7.0 (wheezy)" in /var/lib/lxc/wheezy/rootfs/etc/os-release, which seems like reasonable way how to configure a script.

I removed manual node creation at container creation time to be compatible with systemd. /dev is a tmpfs and lxc will take care of creating the needed devices when container is booted (you need to set lxc.autodev=1 in your container configuration to have this feature).

I prefer to hardcode version in lxc opensuse template because bumping from one release to another is usually not as easy as changing install repositories.. It needs manual testing, which is why I only bump release once it has been tested as working.

Leaving up to you to decide what to do with this one...

Michal, could you test with lxc.autodev=1 ? (it should be set in the created config for openSUSE, anyway)

Hi Frederic, you are right, the nodes are created when lxc.autodev=1 is in, which is btw the default. They appear if you log into the container and are not visible by ls /var/lib/lxc/tomcat/rootfs/dev, neither by chroot.

Unfortunately there is still a problem with chpasswd - my tests shows it is not connected with urandom, but something else in a PAM stack is not happy. I try to debug it using strace, but did not realize the problem. Unfortunately w/o /dev/log the pam debugging is almost impossible.

I've some strace -f outputs - are you interested to check them?

Well, I could re-create some devices there, even if they are hidden when container is booted (I really thought it was useless, not thinking about running software in chroot, before booting the container).

Another possibility could be to create the needed devices at container creation time, then remove them when container is done (but it is probably too much trouble).

opinions welcome.

(In reply to comment #7)
> opinions welcome.

Wouldn't a bind-mount of /dev suffice for that very chpasswd moment?

(In reply to comment #8)
> (In reply to comment #7)
> > opinions welcome.
> 
> Wouldn't a bind-mount of /dev suffice for that very chpasswd moment?

probably.. This is strange because I'm working right now on updating lxc openSUSE template to install 12.3 (and it requires some changes, not only release number change) and I didn't saw the need for /dev/urandom nor /dev/log when container was installed (chpasswd worked).

I've update template for 12.3, please test at https://build.opensuse.org/package/show?package=lxc&project=home%3Afcrozat%3Abranches%3AVirtualization

I'd like to push it for 12.3 final, if it is still possible (otherwise, as an update).

The chpasswd problem still appears :-(

I don't have the issue.. Very strange, chpasswd works for me..

oh, my bad, you try to run chpasswd while chrooting in the container, right ?

Does it works if you use chpasswd -R /path_to_container, without chrooting ?

(In reply to comment #13)
> Does it works if you use chpasswd -R /path_to_container, without chrooting ?

Not for me... It fails while lxc-create is proceeding.

(In reply to comment #14)
> (In reply to comment #13)
> > Does it works if you use chpasswd -R /path_to_container, without chrooting ?
> 
> Not for me... It fails while lxc-create is proceeding.

hmm, so we have some different config, because I don't have this issue, neither running passwd in the chroot itself to change root password..

Hi,

@jiri: I assume you have to remove the cache /var/cache/lxc/opensuse, because I'd say the 12.2 packages are still installed, so it is inconsistent with a new template for 12.3.

@frederic: maybe it is a good idea to use opensuse-${DISTRO} cache directory

Anyway with cleaned cache, chpasswd no longer fail

Checking cache download in /var/cache/lxc/opensuse/rootfs-x86_64 ... 
Copy /var/cache/lxc/opensuse/rootfs-x86_64 to /var/lib/lxc/test2/rootfs ... 
Copying rootfs to /var/lib/lxc/test2/rootfs ...Please change root-password !
BAD PASSWORD: it is too short
BAD PASSWORD: is too simple
'opensuse' template installed
'test2' created


BTW: I've got a lot of when container is started

<46>systemd-journal[446]: Received SIGURS1

This is relevant log (root logout from a system)

Feb 25 15:46:04 test2 login[414]: pam_unix(login:session): session opened for user root by LOGIN(uid=0)
Feb 25 15:46:04 test2 systemd-logind[30]: New session 21 of user root.
Feb 25 15:46:04 test2 login[414]: ROOT LOGIN ON console
Feb 25 15:47:23 test2 login[414]: pam_unix(login:session): session closed for user root
Feb 25 15:47:24 test2 systemd-journal[464]: Allowing system journal files to grow to 4.0G.
Feb 25 15:47:24 test2 systemd-journal[464]: Journal started
Feb 25 15:47:23 test2 systemd[1]: console-getty.service holdoff time over, scheduling restart.
Feb 25 15:47:23 test2 systemd[1]: Stopping Console Getty...
Feb 25 15:47:23 test2 systemd[1]: Starting Console Getty...
Feb 25 15:47:23 test2 systemd[1]: Started Console Getty.
Feb 25 15:47:24 test2 systemd[1]: systemd-journald.service: main process exited, code=exited, status=1/FAILURE
Feb 25 15:47:24 test2 systemd[1]: Started Trigger Flushing of Journal to Persistent Storage.

BTW: I've got an issue when I've switched the LAN cable during a lxc-create, which triggered a new gateway and a connection failure. However template fails on an attempt to readd repo-oss and update repos.

Please consider following change (or maybe the is a zypper switch for that purpose)

+    if [[ ! -f $cache/partial-$arch-packages/etc/zypp/repos.d/repo-oss.repo ]]; then
+        zypper --quiet --root $cache/partial-$arch-packages --non-interactive ar http://download.opensuse.org/distribution/$DISTRO/repo/oss/ repo-oss || return 1
+    fi
+    if [[ ! -f $cache/partial-$arch-packages/etc/zypp/repos.d/update.repo ]]; then
+        zypper --quiet --root $cache/partial-$arch-packages --non-interactive ar http://download.opensuse.org/update/$DISTRO/ update || return 1
+    fi

(In reply to comment #16)
> Hi,
> 
> @jiri: I assume you have to remove the cache /var/cache/lxc/opensuse, because
> I'd say the 12.2 packages are still installed, so it is inconsistent with a new
> template for 12.3.
> 
> @frederic: maybe it is a good idea to use opensuse-${DISTRO} cache directory

Well, versioning the cache wouldn't remove the old one (which would become irrelevant as soon as the template is updated).

This is indeed a shortcoming in the current way we handle template and cache :(
 
> Anyway with cleaned cache, chpasswd no longer fail

Good :)

> BTW: I've got a lot of when container is started
> 
> <46>systemd-journal[446]: Received SIGURS1

Yes, I saw that. But I didn't spend time to debug it.

> BTW: I've got an issue when I've switched the LAN cable during a lxc-create,
> which triggered a new gateway and a connection failure. However template fails
> on an attempt to readd repo-oss and update repos.
> 
> Please consider following change (or maybe the is a zypper switch for that
> purpose)
> 
> +    if [[ ! -f $cache/partial-$arch-packages/etc/zypp/repos.d/repo-oss.repo
> ]]; then
> +        zypper --quiet --root $cache/partial-$arch-packages --non-interactive
> ar http://download.opensuse.org/distribution/$DISTRO/repo/oss/ repo-oss ||
> return 1
> +    fi
> +    if [[ ! -f $cache/partial-$arch-packages/etc/zypp/repos.d/update.repo ]];
> then
> +        zypper --quiet --root $cache/partial-$arch-packages --non-interactive
> ar http://download.opensuse.org/update/$DISTRO/ update || return 1
> +    fi

Could you do a sr against lxc package with this change ?

(In reply to comment #17)
> (In reply to comment #16)
> > Hi,
> > 
> > @jiri: I assume you have to remove the cache /var/cache/lxc/opensuse, because
> > I'd say the 12.2 packages are still installed, so it is inconsistent with a new
> > template for 12.3.
> > 
> > @frederic: maybe it is a good idea to use opensuse-${DISTRO} cache directory
> 
> Well, versioning the cache wouldn't remove the old one (which would become
> irrelevant as soon as the template is updated).
> 
> This is indeed a shortcoming in the current way we handle template and cache :(

Well, it is probably better than using a template with 12.3, with packages from 12.2. What about to check if VERSION_ID in /etc/os-release matches the DISTRO and if no, remove cache? Maybe install_opensuse can do it.

> Could you do a sr against lxc package with this change ?

Sure 156404

(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > Hi,
> > > 
> > > @jiri: I assume you have to remove the cache /var/cache/lxc/opensuse, because
> > > I'd say the 12.2 packages are still installed, so it is inconsistent with a new
> > > template for 12.3.
> > > 
> > > @frederic: maybe it is a good idea to use opensuse-${DISTRO} cache directory
> > 
> > Well, versioning the cache wouldn't remove the old one (which would become
> > irrelevant as soon as the template is updated).
> > 
> > This is indeed a shortcoming in the current way we handle template and cache :(
> 
> Well, it is probably better than using a template with 12.3, with packages from
> 12.2. What about to check if VERSION_ID in /etc/os-release matches the DISTRO
> and if no, remove cache? Maybe install_opensuse can do it.

Yes, it sounds cleaner.. 

> > Could you do a sr against lxc package with this change ?
> 
> Sure 156404

Jiri accepted it.

This is an autogenerated message for OBS integration:
This bug (804435) was mentioned in
https://build.opensuse.org/request/show/156416 Factory / lxc

> > > This is indeed a shortcoming in the current way we handle template and cache :(
> > 
> > Well, it is probably better than using a template with 12.3, with packages from
> > 12.2. What about to check if VERSION_ID in /etc/os-release matches the DISTRO
> > and if no, remove cache? Maybe install_opensuse can do it.
> 
> Yes, it sounds cleaner.. 

sent to Virtualization by 156437 - I would say this bug can be then marked as RESOLVED/FIXED. Thanks for your valuable help!

looks good for me. Jiri, please accept it. Closing as fixed

This is an autogenerated message for OBS integration:
This bug (804435) was mentioned in
https://build.opensuse.org/request/show/156461 Factory / lxc

it looks like some of the changes broke container generation on 12.3 / x86_64 (was working fine on i586).

I've pushed sr#157927

Let's do a maintenance update with this fix (and the cache cleaning fix) for 12.3.

This is an autogenerated message for OBS integration:
This bug (804435) was mentioned in
https://build.opensuse.org/request/show/158004 Factory / lxc

This is an autogenerated message for OBS integration:
This bug (804435) was mentioned in
https://build.opensuse.org/request/show/542066 15.0 / lxc