Bug 812541

This looks similar to bnc#787228

Did you change the vpn config to not restart dnsmasq on shutdown ?

Of course, my bad. This is another machine. Sorry for the noise.

*** This bug has been marked as a duplicate of bug 787228 ***

Created attachment 533912 [details]
journalctl with try-restart

(In reply to comment #2)
> Of course, my bad. This is another machine. Sorry for the noise.

Not really. I had 'dnsmasq restart' there, so I changed that to try-restart, but still the issue is there.

.

Apr 08 09:34:32 anemoi systemd[1]: Trying to enqueue job dnsmasq.service/try-restart/replace
Apr 08 09:34:32 anemoi systemd[1]: Job dnsmasq.service/stop finished, result=canceled
Apr 08 09:34:32 anemoi systemd[1]: Installed new job dnsmasq.service/restart as 906

So, try-restart replaced "stop" by "restart" because it wasn't stopped at the time try-restart was reached.

The "real" fix (non abortable shutdown / kexec / reboot) will be available in Factory soon but I can't backport it for 12.3 (changes are too intrusive).

I've asked upstream their opinion on whether try-restart should ack as "no-op" or "restart" if a "stop" call is pending. There is currently no precise answer for this so I've sent a mail on systemd-devel mailing list to see if we can change the behavior or not.

In the mean time, you should probably add something like:
systemd_booting () {
        # returns 0 when we boot, 1 in running system
        systemctl show -p ActiveState default.target | grep -qi inactive
}

and use it to call systemctl try-restart dnsmasq.service only if system is in running state..

(In reply to comment #5)
> The "real" fix (non abortable shutdown / kexec / reboot) will be available in
> Factory soon but I can't backport it for 12.3 (changes are too intrusive).

Ok, is it safe to install Base:System's systemd on the top of 12.3? I'm using tumbleweed anyway, so I'm asking if adding new systemd there is an option?

(In reply to comment #6)
> (In reply to comment #5)
> > The "real" fix (non abortable shutdown / kexec / reboot) will be available in
> > Factory soon but I can't backport it for 12.3 (changes are too intrusive).
> 
> Ok, is it safe to install Base:System's systemd on the top of 12.3? I'm using
> tumbleweed anyway, so I'm asking if adding new systemd there is an option?

Right now, Base:System doesn't have new systemd (I'm planning to work on it this week). It "should" work but it is less tested and I can't make any garantee on how broken it will be in the future when used on 12.3, during 13.1 development.

I would suggest to "workaround" the try-restart issue instead, might be more stable ;)

Ok, I'm now having this:

if ! systemctl show -p ActiveState default.target | grep -qi inactive; then
        systemctl try-restart dnsmasq.service
fi

(In reply to comment #8)
> Ok, I'm now having this:
> 
> if ! systemctl show -p ActiveState default.target | grep -qi inactive; then
>         systemctl try-restart dnsmasq.service
> fi

This doesn't work when openvpn is started during boot-up -- dnsmasq is not restarted at that time. I have to restart it manually.

Could you try :

if ! systemctl show -p ActiveState shutdown.target | grep -qi active; then
        systemctl try-restart dnsmasq.service
fi

This should detect properly when the system is in shutdown mode (the other test was more to detect when system was not in startup mode).

(In reply to comment #11)
> Could you try :
> 
> if ! systemctl show -p ActiveState shutdown.target | grep -qi active; then
>         systemctl try-restart dnsmasq.service
> fi

This doesn't work either. Are you sure with the 'not'?

I mean this:

> if ! systemctl show -p ActiveState shutdown.target | grep -qi active; then

     ^
-----'

This whole is weird. 'grep active' matches both active *and* inactive...

err, I should learn to type, someday :)

if systemctl show -p ActiveState shutdown.target | grep -qi =active ; then


should work much better..

(In reply to comment #15)
> err, I should learn to type, someday :)
> 
> if systemctl show -p ActiveState shutdown.target | grep -qi =active ; then
> 
> 
> should work much better..

Are you sure?
  if systemctl show -p ActiveState shutdown.target | grep -qi =active; then
    echo aa
  fi
doesn't print anything on a running system. Maybe it's OK, but I don't see why it should be :)...

Since the proper fix has been included since v198 meaning that opensuse 13.[12] have it and opensuse 12.3 is not supported anymore, it should be safe to close this bug.