Bug 821866

Summary: YAST2 On-line Update generates an error when closed using Ctrl-W
Product: [openSUSE] openSUSE 12.3 Reporter: John Carrick Smith <jcarricksmith>
Component: YaST2Assignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Minor    
Priority: P5 - None CC: jsuchome, tgoettlicher
Version: Final   
Target Milestone: ---   
Hardware: i586   
OS: openSUSE 12.3   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Error text from message box.

Description John Carrick Smith 2013-05-27 14:58:50 UTC
Created attachment 541379 [details]
Error text from message box.

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0

If I check for updates and there are none, then using Ctrl-W to close the window causes and error message to appear. Once acknowledged the error message box closes and everything works OK.

I am running KDE as the desktop in 12.3 with updates applied. The problem has existed for a few versions and is not new to 12.3. 

Reproducible: Always

Steps to Reproduce:
1. Open YAST On-line Update
2. Press Ctrl-W to close window. 
Actual Results:  
Error message box appears.

Expected Results:  
Clean close.

uname -a output: Linux jlin.site 3.7.10-1.4-desktop #1 SMP PREEMPT Fri Apr 19 12:06:34 UTC 2013 (8ef74f8) i686 i686 i386 GNU/Linux
Comment 1 Jiří Suchomel 2013-05-31 07:07:52 UTC
It is detected in PackageSelector, it does not seem online_update_select can do anything here.


2013-05-31 09:05:02 <1> linux-ys7e.site(21890) [qt-pkg] YQPackageSelectorBase.cc(~YQPackageSelectorBase):116 Destroying PackageSelector
2013-05-31 09:05:02 <2> linux-ys7e.site(21890) [ui] YWidget.cc(findWidget):632  THROW:    No widget with ID `selector
2013-05-31 09:05:02 <2> linux-ys7e.site(21890) [ui] YCP_UI.cc(RunPkgSelection):1411     CAUGHT:   No widget with ID `selector
2013-05-31 09:05:02 <3> linux-ys7e.site(21890) [libycp] clients/online_update_select.ycp:134 RunPkgSelection() failed


Thomas?
Comment 2 Thomas Göttlicher 2013-06-24 03:56:03 UTC
I think that's not caused by the Package Selector itself.
Comment 3 Jiří Suchomel 2013-06-24 06:15:46 UTC
Well... right. The problem is completely different: With Ctrl+W, Package Selector returns `webpin result.

Now, 
1. online update bug is that it does not expect possible `webpin return value. (The question is, what should it actually do - I think the web search should be disabled for online update anyway)

2. webpin module (the one for searching packages on the web) actually does not work. I think it would be better to remove that option from Package Selector menu completely. Thomas, this would be on you, I think, see "Search Packages on &Web..." in YQPackageSelector.cc
Comment 4 Jiří Suchomel 2013-06-24 06:24:16 UTC
Why NEEDINFO: if you remove "Search Packages on &Web..." from package selector, no change in online_update_select will be needed. Otherwise, I'll need to adapt online update.
Comment 5 Ladislav Slezák 2013-06-24 06:32:00 UTC
JFYI: the webpins search server does not work for several years, so I guess the menu item (and the shortcut) can be safely removed.

Just use a good commit description for removal in case we would add it back in the future...
Comment 6 Thomas Göttlicher 2013-06-26 03:17:28 UTC
I removed the webpin menu entry in libyui-qt-pkg version 2.42.9.
Comment 7 Jiří Suchomel 2013-06-26 03:54:41 UTC
So I think this is fixed now