Bug 824609

Summary: installation boot parameters not written toGRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub
Product: [openSUSE] openSUSE Tumbleweed Reporter: Ludwig Nussel <lnussel>
Component: YaST2Assignee: Michael Chang <mchang>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Major    
Priority: P2 - High CC: coolo, mchang, snwint
Version: 13.1 Beta 1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard: GOLD
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: y2logs
perl bootloader patch to fix parsing kernel append in grub.cfg

Description Ludwig Nussel 2013-06-12 09:45:40 UTC
Created attachment 543850 [details]
y2logs

boot parameters used for the installation are not taken to the installed system. AFAICT they should be in /etc/default/grub in the variable GRUB_CMDLINE_LINUX_DEFAULT.
Specifically I'm missing drm_kms_helper.edid_firmware after installation which makes the system boot with the wrong resolution.
Comment 1 Ludwig Nussel 2013-06-13 01:32:23 UTC
raising severity as it prevents automated acceptance tests of milestones using openQA
Comment 2 Michael Chang 2013-06-13 21:03:05 UTC
Fixed in this pull request

https://github.com/yast/yast-bootloader/pull/17

The commit info
https://github.com/WenhuaChang/yast-bootloader/commit/a553d672e711d905396902665909878d21fdc9ec

It's a regression, but really head scratching to find out from what time it occurs. The above commit works for me, it makes sense (at least to me) to honor that was_proposed flag to guard erroneous invocation of propose method that make your settings recreated from scratch ..  

Steffen would you please help to review them. Thanks a lot.
Comment 3 Ludwig Nussel 2013-09-18 15:53:04 UTC
Steffen, this one still applies to 13.1 Beta1. Please have a look at it.
Comment 4 Steffen Winterfeldt 2013-09-19 07:01:52 UTC
The patches have been applied.
Comment 5 Ludwig Nussel 2013-09-20 07:22:19 UTC
so why does it still not work?
Comment 6 Michael Chang 2013-09-23 04:12:29 UTC
That fix is for old .ycp and somehow not work for the new ruby yast. I'm now trying to find what's wrong.
Comment 7 Michael Chang 2013-09-23 12:18:35 UTC
The fix in comment#2 is effective and this one is a separate issue. So far is only reproducible on grub2-efi and the root cause is due to some bogus variable handling and in perl bootloader. I'll continue to verify the fix tomorrow (is late is my time zone).
Comment 8 Michael Chang 2013-09-25 07:20:36 UTC
Created attachment 559927 [details]
perl bootloader patch to fix parsing kernel append in grub.cfg

The patch has been verified to fix this issue, the pull request has been sent to perl bootloader git as well.
Comment 9 Michael Chang 2013-09-25 07:24:00 UTC
Hi Steffen,

Would be great if you could review that patch for acceptance. 
Thanks.
Comment 10 Michael Chang 2013-09-27 09:51:16 UTC
Set to resolve fix as patch as been submitted.
Comment 11 Bernhard Wiedemann 2013-10-01 14:00:33 UTC
This is an autogenerated message for OBS integration:
This bug (824609) was mentioned in
https://build.opensuse.org/request/show/201607 Factory / perl-Bootloader