Bug 837954

Summary: system fails to boot due to missing /usr/sbin/lvm
Product: [openSUSE] openSUSE Tumbleweed Reporter: Lars Müller <lmuelle>
Component: BasesystemAssignee: Dong Mao Zhang <dmzhang>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Critical    
Priority: P2 - High CC: bbrunner, crrodriguez, iacobcatalin, meissner, ro, xwhu
Version: 13.1 Milestone 4   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: Yes
Marketing QA Status: --- IT Deployment: ---
Attachments: output of journalctl -xb before I've created the sym link
Modify scripts/lvm2_activation_generator_systemd_red_hat.c
Patch to generate scripts/lvm2_activation_generator_systemd_red_hat.c on the fly

Description Lars Müller 2013-08-31 17:01:28 UTC
Created attachment 555249 [details]
output of journalctl -xb before I've created the sym link

The lvm command is available at /sbin/lvm  As workaround I created a symbolic link from /usr/sbin/lvm pointing to at /sbin/lvm and the system boots as expected.

Find the output of journalctl -xb before I've created the sym link

/etc/SuSE-release reports openSUSE 13.1 Milestone 4 (x86_64)

Linux hip 3.11.0-rc6-1.g7ee85be-default #1 SMP Wed Aug 21 09:21:00 UTC 2013 (7ee85be) x86_64 x86_64 x86_64 GNU/Linux

rpm -q lvm2 
lvm2-2.02.98-0.26.1.x86_64

Might adding the systemd support to the lvm2 package have caused this?

I'm testing if adding --exec-prefix=/ as parameter to configure cures this.
Comment 1 Lars Müller 2013-08-31 18:03:09 UTC
Created attachment 555250 [details]
Modify scripts/lvm2_activation_generator_systemd_red_hat.c

--exec-prefix=/ is the wrong approach.  Instead scripts/lvm2_activation_generator_systemd_red_hat.c has to be modified to ExecStart=/sbin/lvm instead of /usr/sbin/lvm
Comment 2 Lars Müller 2013-08-31 18:25:13 UTC
A modified lvm2 package as suggested with comment #1 leads to a booting system.  See https://build.opensuse.org/package/show/home:lmuelle:branches:Base:System/lvm2

Nevertheless I consider this change suboptimal as in this state upstream can't accept it.
Comment 3 Lars Müller 2013-08-31 19:56:16 UTC
Created attachment 555251 [details]
Patch to generate scripts/lvm2_activation_generator_systemd_red_hat.c on the fly

This happens while configure got called.
Comment 4 Lars Müller 2013-08-31 20:21:59 UTC
The branch from comment #2 has the suggested modification.

a) we need some review if this is the correct approach
b) more testing;  Therefore I've written a mail to opensuse-factory  See http://lists.opensuse.org/opensuse-factory/2013-08/msg00549.html
c) discuss it upstream
Comment 5 Dong Mao Zhang 2013-11-21 08:20:49 UTC
close,fixed
Comment 6 Lars Müller 2013-12-17 12:14:59 UTC
There is no reference to this defect report in the package change log nor in the lvm-path.patch file.

Nor have we seen a discussion of the questions raised with comment #4.

We need at least a reference in the package change log _and_ the lvm-path.patch to this defect.
Comment 7 Benjamin Brunner 2014-01-16 09:46:16 UTC
The submission to factory was declined with the following reason:

State:   declined   2014-01-13T10:34:31 saschpe
Comment: /etc/lvm/lvm.conf lost %config, not sure if that's intentional. With %config, users will get your updates, they'll get a *.rpmsave file for their previous modifications.


This line is also removed for the 13.1 update. Could this cause problems or was it intentional?
Comment 8 Dong Mao Zhang 2014-01-16 10:22:02 UTC
(In reply to comment #7)
> The submission to factory was declined with the following reason:
> 
> State:   declined   2014-01-13T10:34:31 saschpe
> Comment: /etc/lvm/lvm.conf lost %config, not sure if that's intentional. With
> %config, users will get your updates, they'll get a *.rpmsave file for their
> previous modifications.
> 
> 
> This line is also removed for the 13.1 update. Could this cause problems or was
> it intentional?


No, it's not intentional. 
I would check the spec file. thank you
Comment 9 Bernhard Wiedemann 2014-01-16 11:00:11 UTC
This is an autogenerated message for OBS integration:
This bug (837954) was mentioned in
https://build.opensuse.org/request/show/214084 Factory / lvm2
Comment 10 Benjamin Brunner 2014-01-16 13:52:33 UTC
JFYI, I've applied your change for factory to the 13.1 update and a new maintenancerequest is not necessary. Thanks for the fast fix.
Comment 11 Dong Mao Zhang 2014-01-23 09:22:01 UTC
close
Comment 12 Swamp Workflow Management 2014-02-03 15:29:06 UTC
openSUSE-RU-2014:0186-1: An update that has 5 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 779965,837954,851741,854076,854413
CVE References: 
Sources used:
openSUSE 13.1 (src):    lvm2-2.02.98-0.28.5.1