|
Bugzilla – Full Text Bug Listing |
| Summary: | open-iscsi should be updated to start when needed using systemd | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 13.1 | Reporter: | Lee Duncan <lduncan> |
| Component: | Basesystem | Assignee: | Lee Duncan <lduncan> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P3 - Medium | CC: | aj, fcrozat, forgotten_yDnX4kBjpV, hare, meissner, werner |
| Version: | RC 1 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | openSUSE 12.3 | ||
| Whiteboard: | |||
| Found By: | Development | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Bug Depends on: | 821695, 827654 | ||
| Bug Blocks: | |||
|
Description
Lee Duncan
2013-10-21 21:50:03 UTC
accepted, simple fix, but will have to get permission to make such a change, since the list of auto-enabled service seems to guarded like Fort Knox. Lee, we have a policy of not enabling services by default. This policy was introduced at the time when we switched to systemd. Yes, this is a change to the old way with SysV Init. Is there a specific reason that open-iscsi needs to be enabled by default when installed? Andreas: I'm not clear on this new policy. Is it that no service is enabled by default, ever, from now on, or are there exceptions? I assumed the policy was designed to stop all services from enabling themselves by default, when installed, since that might not be what the user wanted in all cases. Especially if such automatic enablement means the system is bogged down using unneeded resources because daemons are running when not needed. In this case, it seems like the socket-driven model available to systemd services means that "enabling" iscsid.socket in this case causes almost no system impact. And I feel that the principle of least surprise should be that if the customer installs open-iscsi and runs "iscsiadm -m discovery ..." to find some nodes, they don't expect a message saying "the daemon is not running". The daemon should be started. In the System V Init days, there was a line in /etc/iscsi/iscsid.conf that told the open-iscsi system to start up the daemon in such cases, if needed. But that line has been removed because of systemd's socket-driven functionality. I noticed that there are more than a few other services that are enabled by default, hence my confusion. Is this new policy from systemd or by openSUSE? Do you have a reference to it and other such policies, so I can provide appropriate submissions in the future? I take it, then, that the expected work flow for most service installations will be, from the end user point of view: 1. install the service (using zypper or yast2), then 2. manually run "systemctl enable <SERVICE>" from the command line Is this correct? In the case of open-iscsi, there are 3 services, and only 2 of them should be enabled, since enabling the 3rd will mean the iscsid daemon is running even if not needed. I thought automatically installing open-iscsi with the correct 2 of 3 units enabled would result in the least number of bugs filed. (In reply to comment #3) > Andreas: I'm not clear on this new policy. Is it that no service is enabled by > default, ever, from now on, or are there exceptions? I assumed the policy was > designed to stop all services from enabling themselves by default, when > installed, since that might not be what the user wanted in all cases. > Especially if such automatic enablement means the system is bogged down using > unneeded resources because daemons are running when not needed. The file default-openSUSE.preset defines what is enabled by default - those are the exceptions. If there are really valid reasons to enable open-iscsi, we can add it. > In this case, it seems like the socket-driven model available to systemd > services means that "enabling" iscsid.socket in this case causes almost no > system impact. And I feel that the principle of least surprise should be that > if the customer installs open-iscsi and runs "iscsiadm -m discovery ..." to > find some nodes, they don't expect a message saying "the daemon is not > running". The daemon should be started. In the System V Init days, there was a > line in /etc/iscsi/iscsid.conf that told the open-iscsi system to start up the > daemon in such cases, if needed. But that line has been removed because of > systemd's socket-driven functionality. > > I noticed that there are more than a few other services that are enabled by > default, hence my confusion. Is this new policy from systemd or by openSUSE? This is an openSUSE policy. > you have a reference to it and other such policies, so I can provide > appropriate submissions in the future? This should be documented in the openSUSE wiki under packaging guide lines but sometimes the sections are not complete. > I take it, then, that the expected work flow for most service installations > will be, from the end user point of view: > 1. install the service (using zypper or yast2), then > 2. manually run "systemctl enable <SERVICE>" from the command line > > Is this correct? In the case of open-iscsi, there are 3 services, and only 2 of Yes, that's correct. > them should be enabled, since enabling the 3rd will mean the iscsid daemon is > running even if not needed. I thought automatically installing open-iscsi with > the correct 2 of 3 units enabled would result in the least number of bugs > filed. So, it's the choice of enabling two for everybody that installs it - versus the fear that users might start all three manually? Two bad choices ;( Btw. if you disagree, feel free to discuss on openstack-packaging in a larger round. Updating priority to P3 Looks like it's fixed in Factory: https://build.opensuse.org/request/show/203672 Removed dependency on 845593, and marked as resolved. Make the removed dependency on 847953. |