Bug 847291

Summary: JJ: [yast2-nis-client] lacks a scrollbar to show the exit buttons
Product: [openSUSE] openSUSE 13.1 Reporter: Olaf Hering <ohering>
Component: YaST2Assignee: Christopher Hofmann <cwh>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P4 - Low CC: cwh, jsuchome, locilka, mvidner
Version: RC 1   
Target Milestone: ---   
Hardware: x86-64   
OS: Linux   
Whiteboard:
Found By: Outsourced Testing Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: 13.1-rc1-yast2-nisclient-no-buttons.png
patch for ui.rb
bug847291-nis-client.png
Screenshot of rearranged layout
Screenshot of rearranged layout; ncurses 80x25

Description Olaf Hering 2013-10-23 16:19:42 UTC
Created attachment 564651 [details]
13.1-rc1-yast2-nisclient-no-buttons.png

13.1-rc1 with KDE desktop in a VM.

As shown in the screenshot, yast2-nisclient does not show the Ok or Cancel button. And it does not have a scrollbar to move the contents of the window.
Comment 1 Martin Vidner 2013-11-05 09:40:35 UTC
YaST does not use scroll bars for dialog content. In such cases we rearrange the layout to make it fit.
Comment 3 Jiří Suchomel 2013-12-02 11:12:55 UTC
*** Bug 850798 has been marked as a duplicate of this bug. ***
Comment 4 Jiří Suchomel 2013-12-02 11:19:57 UTC
Created attachment 569827 [details]
patch for ui.rb

Please try with this patch for /usr/share/YaST2/include/nis/ui.rb
Comment 5 Olaf Hering 2013-12-09 13:49:26 UTC
Created attachment 570875 [details]
bug847291-nis-client.png

No, it does not improve the layout.
Comment 6 Jiří Suchomel 2013-12-09 14:08:47 UTC
Well, for me it did, at least in Qt.

Not sure how to help with GTK.

Martin, is 800x600 actually supported size?
Comment 7 Martin Vidner 2013-12-09 14:34:51 UTC
Yes, 800x600 is a minimal requirement (1024x768 recommended), at least on SLED11 SP3: https://www.suse.com/products/desktop/technical-information/
Comment 8 Christopher Hofmann 2014-08-05 16:16:57 UTC
Created attachment 601133 [details]
Screenshot of rearranged layout

I vertically squeezed the layout. See attached screen shot.
Comment 9 Christopher Hofmann 2014-08-06 08:33:41 UTC
Created attachment 601221 [details]
Screenshot of rearranged layout; ncurses 80x25

Added Screenshot of rearranged layout in ncurses 80x25
Comment 10 Martin Vidner 2014-08-06 08:45:42 UTC
See? In ncurses it does not fit, this time horizonally. Notice the truncated last characters in "Open port in Firewall", "Expert...", and "NFS Configuration...". And in other languages like German of French it might be worse.

Sorry to spoil what seemed to be an easy fix. The dialog has way too many widgets. Maybe stack the firewall box always vertically and try to rearrange Nfs, Expert and Automounter. Ah, also the radio buttons could be HBox'ed.
Comment 11 Martin Vidner 2014-08-06 11:54:47 UTC
locilka said:
> Additional NIS Domains are still not visible in 80x25, or am I wrong?

Indeed, and I thought it was a layout bug of hiding an Input Field. But it is a read only field which does appear once entries are added with the Edit button.
BTW in that case, in the original ncurses layout, one of the top radio buttons is pushed off screen.

So, all things considered, the dialog is seriously ripe for splitting up (tabs? multiple dialogs?) but the state in comments 8 and 9 is good enough for me.
Comment 12 Christopher Hofmann 2014-08-07 10:52:39 UTC
Fixed in yast2-nis-client 3.1.10

We thought about tabs, but "Nfs Configuration" already has tabs which would lead to tabs in tabs. But this might be solvable. We'll find a solution in future.