|
Bugzilla – Full Text Bug Listing |
| Summary: | yast2 apparmor bad UX for profile management | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Christian Boltz <suse-beta> |
| Component: | YaST2 | Assignee: | YaST Team <yast-internal> |
| Status: | RESOLVED WONTFIX | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Major | ||
| Priority: | P3 - Medium | CC: | jreidinger, jsrain |
| Version: | 13.2 Milestone 0 | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | openSUSE 12.3 | ||
| Whiteboard: | |||
| Found By: | Beta-Customer | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: | y2log | ||
looks like related with removing deprecated methods in code as seen in log: 2013-11-08 13:06:30 <3> geeko(8525) [Ruby] apparmor/profile_dialogs.rb:1505 Unexpected return code: `timeout 2013-11-08 13:06:33 <3> geeko(8525) [Ruby] apparmor/profile_dialogs.rb:1505 Unexpected return code: `profilelist I will check it. Christian - log lines above is not related. Why you think that YaST crashes? AppArmor was originally developed outside of Yast team, so there is some inconsistent UI decisions like that everything is done immediatelly and in fact button "Next" means only exit. What actually edit profile is "Edit" button. What is annoying that "Abort" and "Next" in fact do same thing. I agree that it is really bad UX, but I am not original author and if we change UI, I hope there is a designer who can create something much better then I. (In reply to comment #3) > Christian - log lines above is not related. Why you think that YaST crashes? Following the workflow I described as reproducer, I expected something to happen/be displayed after clicking "Next". I thought it's a crash (as in "disappears unexpectedly"), but maybe it just exited. > AppArmor was originally developed outside of Yast team, so there is some > inconsistent UI decisions like that everything is done immediatelly and in fact > button "Next" means only exit. What actually edit profile is "Edit" button. > What is annoying that "Abort" and "Next" in fact do same thing. > I agree that it is really bad UX, but I am not original author and if we change > UI, I hope there is a designer who can create something much better then I. Ah, now I notice there's an "edit" button on the left (where typically only the "Help" button is). Yes, that's really bad UX ;-) I expected the workflow to be select -> click "next" to edit it. It would be a good start to rename the "next" button to "Finish" (I'd guess that "Abort" is different and doesn't save edited profiles). For bonus points, move the "Edit" and "Delete" buttons to the right (at least that's the place where I typically look for buttons). BTW: the changelog mentions drop reporting and profile generation tools (FATE#308684,308683) I'd like to know some details/reasons, but those fate entries are non-public :-( I know reporting was disabled since a long time because the upstream code didn't support it anymore, but the profile generation part was working last time I tested it. So what was the reason for dropping it? (That said: personally, I prefer the commandline tools anyway, so I don't care too much - but it seems some users prefer clicking over typing ;-) I only noticed the changes in YaST after a user complained on the german ML.) (In reply to comment #4) > (In reply to comment #3) > > Christian - log lines above is not related. Why you think that YaST crashes? > > Following the workflow I described as reproducer, I expected something to > happen/be displayed after clicking "Next". I thought it's a crash (as in > "disappears unexpectedly"), but maybe it just exited. > Yes, it is probably result. as new Yast when crashes show something useful ( red error popup that internal error happen and message from ruby exception ). > > AppArmor was originally developed outside of Yast team, so there is some > > inconsistent UI decisions like that everything is done immediatelly and in fact > > button "Next" means only exit. What actually edit profile is "Edit" button. > > What is annoying that "Abort" and "Next" in fact do same thing. > > I agree that it is really bad UX, but I am not original author and if we change > > UI, I hope there is a designer who can create something much better then I. > > Ah, now I notice there's an "edit" button on the left (where typically only the > "Help" button is). Yes, that's really bad UX ;-) Yes, I am original author and also find it really strange. But I don't have time to modify it. Feel free to modify it, I welcome any pull request. > I expected the workflow to be select -> click "next" to edit it. > > It would be a good start to rename the "next" button to "Finish" (I'd guess > that "Abort" is different and doesn't save edited profiles). For bonus points, > move the "Edit" and "Delete" buttons to the right (at least that's the place > where I typically look for buttons). And this is problem as big part of module is in perl and written stateless, so it cannot do last final commit, but do it immediatelly, so after three edits you cannot easily revert it. > > BTW: the changelog mentions > drop reporting and profile generation tools (FATE#308684,308683) > I'd like to know some details/reasons, but those fate entries are non-public > :-( > > I know reporting was disabled since a long time because the upstream code > didn't support it anymore, but the profile generation part was working last > time I tested it. So what was the reason for dropping it? > OK, in short, reason is that upstream is not interested in maintaining it, so it means that if something is broken, I or other maintainer of yast2-apparmor must maintain such feature and it is definitively too big task to my available time and also my knowledge of apparmor is not big enough to maintain such task. > (That said: personally, I prefer the commandline tools anyway, so I don't care > too much - but it seems some users prefer clicking over typing ;-) I only > noticed the changes in YaST after a user complained on the german ML.) It would be nice if such users can write to yast-devel or at least to opensuse-factory as yast-team base time allocation also on feeling how much users use given module and for apparmor it looks like almost no-one use GUI. I change title of bug and set priority properly as it is about UX and not crash. This bug has been there since 2013 and the YaST team did not have time to tackle it. Sadly, I don't see this changing within next years either. The UX of this module is very far from being perfect, but the YaST team has no capacity to handle it unless we need to do changes from other reasons. That's why I'm closing this bug as WONTFIX - because, no matter whether it is open or not, it will be the reality. If anyone wants to provide us patches (or pull-request), we will appreciate it and provide necessary help. |
Created attachment 566660 [details] y2log Using current factory, yast2 apparmor crashes after some clicks. Reproducer: - start yast2 apparmor - click "Manage existing profiles" - choose a profile (for example /sbin/klogd) - click "Next" - see YaST crashing The y2log is attached, other files in /var/log/YaST2 were not changed.