|
Bugzilla – Full Text Bug Listing |
| Summary: | grub2 and memmap cause kernel hang | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 13.1 | Reporter: | Pi Ny <piny> |
| Component: | Bootloader | Assignee: | Michael Chang <mchang> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Critical | ||
| Priority: | P5 - None | CC: | arvidjaar |
| Version: | Final | ||
| Target Milestone: | --- | ||
| Hardware: | x86-64 | ||
| OS: | openSUSE 13.1 | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: |
insert '$'-esacping hint to 'memmap' description
insert '$'-esacping hint into /etc/default/grub insert '$'-esacping hint into /boot/grub2/grub.cfg |
||
|
Description
Pi Ny
2014-01-06 01:53:17 UTC
I know this is an grub2 issue - but seems to be a feature! So ALL openSUSE docu is affected! This issue also affects the installation of openSUSE with YAST! Entering the additional boot option "memmap=64K$0K" leads to an "$0"-expansion resulting in an entry (reproduced from my mind) like "memmap=64K/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg" This probably should be a separate bug concerning the YAST installer! (In reply to comment #1) > I know this is an grub2 issue - but seems to be a feature! I do not see where it is grub2 problem. It is perfectly legal to add parameters that would be expanded at boot time to kernel command line in grub.cfg. This feature is very useful. I agree that it is worth to mention it in documentation. Care to provide a patch? May be YaST could special case memmap and additionally escape it. Do you have list of other kernel parameters that are using $ as part of value? (In reply to comment #3) > I do not see where it is grub2 problem. It is perfectly legal to add parameters > that would be expanded at boot time to kernel command line in grub.cfg. This > feature is very useful. > > I agree that it is worth to mention it in documentation. Care to provide a > patch? > > May be YaST could special case memmap and additionally escape it. Do you have > list of other kernel parameters that are using $ as part of value? I checked https://www.kernel.org/doc/Documentation/kernel-parameters.txt There is seems that memmap is the only "true" kernel parameter using the "$"-character. I propose at least 3 documents that should be updated: 1) In https://www.kernel.org/doc/Documentation/kernel-parameters.txt: A note should be added to the memmap entry. -> see attached kernel-parameters.txt.2014-01-08_grub2-dollar.diff (based on kernel-parameters.txt as of 2013-12-30) 2) In the config files of grub: I apologize for surrendering in the face of the data structure of grub-2.00.tar.gz as available from ftp://ftp.gnu.org/gnu/grub/. I could not really identify the places to propose following changes: 2a) /etc/default/grub A note should be added before the entries GRUB_CMDLINE_LINUX_DEFAULT, GRUB_CMDLINE_LINUX_RECOVERY, and GRUB_CMDLINE_LINUX -> see attached _etc_default_grub_2014-01-08_dollar-escape.diff (based on current installation) 2b) /boot/grub2/grub.cfg A note should be added in the file header -> see attached _boot_grub2_grub.cfg_2014-01-08_dollar-escape.diff (based on a current installation) Yes, there is a warning not to edit this file directly but in emergency cases people go there... I strongly agree that YAST should escape it (three-fold!), because YAST is meant for users (like me) who don't know too much about internals. Should I file a bug concerning YAST related to this one? Created attachment 573370 [details] insert '$'-esacping hint to 'memmap' description cf. https://bugzilla.novell.com/show_bug.cgi?id=857464#c4 Created attachment 573372 [details] insert '$'-esacping hint into /etc/default/grub https://bugzilla.novell.com/show_bug.cgi?id=857464#c4 Created attachment 573373 [details] insert '$'-esacping hint into /boot/grub2/grub.cfg cf. https://bugzilla.novell.com/show_bug.cgi?id=857464#c4 (In reply to comment #4) > I strongly agree that YAST should escape it (three-fold!), because YAST is > meant for users (like me) who don't know too much about internals. > Should I file a bug concerning YAST related to this one? Meanwhile I decided to file a separate bug https://bugzilla.novell.com/show_bug.cgi?id=857556 concerning YAST. (In reply to comment #8) > Meanwhile I decided to file a separate bug > https://bugzilla.novell.com/show_bug.cgi?id=857556 concerning YAST. Thanks for report. I will look after it. The memmap escaping problem has fixed by YaST, thanks. *** This bug has been marked as a duplicate of bug 857556 *** |