Bug 899992

Summary: sitar doesn't work
Product: [openSUSE] openSUSE Tumbleweed Reporter: Wolfgang Bauer <wbauer>
Component: BasesystemAssignee: E-mail List <bnc-team-screening>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: chcao, maintenance, wbauer
Version: 201410*   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: patch to fix the issue

Description Wolfgang Bauer 2014-10-06 21:41:17 UTC
Created attachment 609111 [details]
patch to fix the issue

When you try to run sitar, it just won't work.

sudo sitar
root's password:
syntax error at /usr/sbin/sitar line 1369, near "$TT qw ( PCI Device Class Vendor SVendor SDevice Rev )"
syntax error at /usr/sbin/sitar line 1399, near "$TT qw ( PCI Device Class Vendor SVendor SDevice Rev )"
syntax error at /usr/sbin/sitar line 1411, near "}"
syntax error at /usr/sbin/sitar line 1424, near "}"
BEGIN not safe after errors--compilation aborted at /usr/sbin/sitar line 1436.

The attached patch fixes this.
Comment 1 Wolfgang Bauer 2014-10-06 21:52:58 UTC
SR#254456 created against Base:System

@maintenance@opensuse.org:
Can we release this as update for openSUSE 13.1 as well?
12.3 is not affected, there you just get a warning about deprecance, but it still works.
Comment 2 Benjamin Brunner 2014-10-07 11:30:30 UTC
Wolfgang, could you open a maintenancerequest with the fixed package for 13.1 please? We'll start an update. Thanks in advance.
Comment 3 Wolfgang Bauer 2014-10-08 00:22:07 UTC
Done:
https://build.opensuse.org/request/show/254644
Comment 4 Swamp Workflow Management 2014-10-15 12:05:04 UTC
openSUSE-RU-2014:1296-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 899992
CVE References: 
Sources used:
openSUSE 13.1 (src):    sitar-1.0.6-148.4.1
Comment 5 Chenzi Cao 2015-01-13 03:20:16 UTC
Hi Wolfgang, does the update version work fine now? If the issue has been fixed, would you mind closing it? Thank you!
Comment 6 Wolfgang Bauer 2015-01-13 08:59:45 UTC
(In reply to Chenzi Cao from comment #5)
> Hi Wolfgang, does the update version work fine now?
Yes.
I just checked on 13.2 and Tumbleweed as well to be sure, and it works there too.

> If the issue has been
> fixed, would you mind closing it? Thank you!

Sorry.
I thought this bug report would be closed automatically when the update is released, and didn't notice that it is still open.

Closing now...