Bug 907698

Summary: syslog filled with "ModemManager(...)Modem/2: signal quality updated (40)"
Product: [openSUSE] openSUSE Distribution Reporter: Ulrich Windl <Ulrich.Windl>
Component: GNOMEAssignee: E-mail List <gnome-bugs>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None CC: dimstar
Version: 13.2   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 13.2   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on: 906687    
Bug Blocks:    

Description Ulrich Windl 2014-11-29 22:17:03 UTC
When connected via broadband, ModemManager logs this message every 30 seconds to syslog:
ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: signal quality updated (40)

The thing is, it does not log a change, but a state (my signal quality was 40 all the time):

# journalctl | cut -d' ' -f5- | sort | uniq -c
[...]
      7 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: access technology changed (hsdpa -> umts)
      8 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: access technology changed (umts -> hsdpa)
      1 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: access technology changed (unknown -> umts)
    969 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: signal quality updated (40)
      1 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: state changed (connecting -> connected)
      1 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: state changed (disabled -> enabling)
      1 ModemManager[1436]: <info>  Modem /org/freedesktop/ModemManager1/Modem/2: state changed (enabling -> registered)
[...]

Syslog is about logging changes, not about logging states. It makes very little sense to log the signal quality every 30 seconds while the quality does not change.
Comment 1 Dominique Leuenberger 2014-12-02 11:10:40 UTC
In openSUSE Tumbleweed, this issue has already been addressed; the signal qiuality update has been changed to be debug output, rather than info output.

I added a patch to MM and submitted it to the GNOME 3.14.2 stack update; as this is a rather minor issue (functionality is not affected at all), it does not warrant for a speedier update than that imho.
Comment 2 Ulrich Windl 2014-12-02 12:12:38 UTC
I think a better fix than changing the message priority from INFO to DEBUG would be to remember the value reported last, and then only emit a new message if the current value is different from the last value. If values change too frequently, some throttling may be appropriate, also.
Comment 3 Dominique Leuenberger 2014-12-02 12:21:36 UTC
The fix is 100% in line with what MM does upstream in version 1.4.0;
Comment 4 Swamp Workflow Management 2015-02-03 12:06:00 UTC
openSUSE-RU-2015:0203-1: An update that has 9 recommended fixes can now be installed.

Category: recommended (low)
Bug References: 900728,905909,906598,906687,90687,906887,907698,909824,910069
CVE References: 
Sources used:
openSUSE 13.2 (src):    ModemManager-1.0.0-9.4.2, adwaita-icon-theme-3.14.1-4.2, aisleriot-3.14.2-4.14, at-spi2-core-2.14.1-4.1, bijiben-3.14.2-4.63, brasero-3.12.0-5.20, cairo-1.14.0-7.4.1, caribou-0.4.16-4.1, cheese-3.14.2-4.21, clutter-1.20.0-4.11, easytag-2.2.5-4.13, eog-3.14.3-4.13, epiphany-3.14.2-4.1, epiphany-branding-SLED-13.2-2.4.3, epiphany-branding-openSUSE-13.2-2.4.3, evince-3.14.1-4.18, evolution-3.12.9-4.15, evolution-data-server-3.12.9-4.18, evolution-ews-3.12.9-4.1, evolution-rss-0.3.95~git20141120.b2253df-8.5.2, file-roller-3.14.2-4.22, geary-0.8.3-7.16, gedit-3.14.1-4.13, gedit-code-assistance-3.14.1-2.6.1, gedit-plugins-3.14.1-4.17, gitg-3.14.1-4.19, glib-networking-2.42.1-4.1, glib2-2.42.1-5.1, glib2-branding-openSUSE-13.2-9.2, gnome-boxes-3.14.2-4.32, gnome-calculator-3.14.1-4.2, gnome-chess-3.14.2-4.12, gnome-code-assistance-3.14.0-2.5.1, gnome-color-manager-3.14.2-4.12, gnome-contacts-3.14.2-4.1, gnome-control-center-3.14.2-8.3, gnome-desktop-3.14.2-4.1, gnome-devel-docs-3.14.2-4.1, gnome-dictionary-3.14.2-4.7, gnome-disk-utility-3.14.0-2.5.1, gnome-documents-3.14.2-4.32, gnome-initial-setup-3.14.2.1-4.1, gnome-klotski-3.14.2-4.11, gnome-logs-3.14.2-4.11, gnome-maps-3.14.2-4.12, gnome-music-3.14.2-4.11, gnome-online-accounts-3.14.2-4.1, gnome-online-miners-3.14.1-4.1, gnome-packagekit-3.14.2-5.4, gnome-photos-3.14.2-4.22, gnome-robots-3.14.2-4.11, gnome-settings-daemon-3.14.2-4.1, gnome-shell-3.14.3-6.10, gnome-shell-extensions-3.14.3-6.1, gnome-software-3.14.1-9.14, gnome-sound-recorder-3.14.2-4.12, gnome-sudoku-3.14.2-4.11, gnome-terminal-3.14.2-4.1, gnome-themes-standard-3.14.2-4.1, gnome-tweak-tool-3.14.2-5.11, gnome-user-docs-3.14.2-4.1, gnome-user-share-3.14.2-4.1, gnote-3.14.1-4.11, gpaste-3.14-2.4.1, gtk3-3.14.6-8.1, gtk3-branding-SLED-13.2-7.3, gtk3-branding-openSUSE-13.2-7.2, gtksourceview-3.14.2-4.1, gvfs-1.22.2-4.1, hitori-3.14.2.1-4.9, iagno-3.14.2-4.9, latexila-3.14.2-4.9, libgdata-0.16.1-4.1, libsoup-2.48.1-4.1, liferea-1.10.12-2.4.17, meld-3.12.2-9.7, mutter-3.14.3-6.1, nautilus-3.14.1-8.8, orca-3.14.3-4.9, pdfmod-0.9.1-2.10, rygel-0.24.2-4.1, totem-3.14.1-4.11, tracker-1.2.5-6.2, tracker-extras-1.2.5-6.13, vinagre-3.14.3-4.1, vino-3.14.1-4.1, vte-0.38.3-4.1, webkit2gtk3-2.6.4-4.9, webkitgtk-2.4.7-4.11, webkitgtk3-2.4.7-4.10
Comment 5 Dominique Leuenberger 2018-03-19 15:02:22 UTC
(In reply to Swamp Workflow Management from comment #4)
> openSUSE-RU-2015:0203-1: An update that has 9 recommended fixes can now be
> installed.

Long fixed