|
Bugzilla – Full Text Bug Listing |
| Summary: | grub-once isn't called at hibernate | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Takashi Iwai <tiwai> |
| Component: | Basesystem | Assignee: | Cristian RodrÃguez <crrodriguez> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | CC: | arvidjaar, bwiedemann, chcao, crrodriguez, jengelh, lmuelle, mchang, suse, systemd-maintainers |
| Version: | Current | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| See Also: | http://bugzilla.opensuse.org/show_bug.cgi?id=941682 | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
|
Description
Takashi Iwai
2015-08-14 09:50:37 UTC
Here is the note from last review if considering it in grub2 package. 1. cleanup to not having any pm-util related environment variable 2. remove grub related part in the script 3 provide the package as conditional, maybe after some systemd version (or we may have conflicted file ?) 4. packaged as noarch subpackage and maybe "Supplements: packageand(systemd-sleep:grub2)" to install it if systemd-sleep and grub2 is to be installed , do not putting it in grub package. Thanks. (In reply to Michael Chang from comment #1) > 4. packaged as noarch subpackage and maybe "Supplements: > packageand(systemd-sleep:grub2)" to install it if systemd-sleep and grub2 is > to be installed , do not putting it in grub package. I wonder whether this gives any big merit. systemd is mandatory, and grub2 is almost mandatory for x86. So, this hook shall be installed always in the end. (In reply to Takashi Iwai from comment #2) Both Cristian and the grub2 maintainers seems to have a different opinion. Compare with https://build.opensuse.org/request/show/286533 For both Cristian and Andrei: Please provide a user friendly solution for this problem. The supplements idea is just best (but perhaps we need EssentialFor:packageand()), because then you don't have to force either systemd or grub to carry the files. (In reply to Jan Engelhardt from comment #4) > The supplements idea is just best (but perhaps we need > EssentialFor:packageand()), because then you don't have to force either > systemd or grub to carry the files. Well, to my eyes, this looks like a thing that is more relevant to grub2 than systemd. The hook is placed in a public place, and the content of the hook is rather specific to grub. But after all, this is a matter the maintainer should decide at best for the ease of maintenance. The worst thing is the brokenness like now. Please fix ASAP. I will work on this. Thanks. Hi, Close this bug as systemd-sleep-plugin subpackage has been added to grub2. Thanks. *** Bug 941682 has been marked as a duplicate of this bug. *** *** Bug 991350 has been marked as a duplicate of this bug. *** Although sleep has been moved to a subpackage of grub, there are some remains in the systemd package (as shown in bug 991350): * The script /usr/bin/systemd-sleep-grub is called from the systemd-units /usr/lib/systemd/system/systemd-hibernate.service and /usr/lib/systemd/system/systemd-hybrid-hibernate.service > [Service] > Type=oneshot > ExecStart=/usr/bin/systemd-sleep-grub pre > ExecStart=/usr/lib/systemd/systemd-sleep hibernate > ExecStopPost=/usr/bin/systemd-sleep-grub post * But this script has been removed with https://build.opensuse.org/request/show/407291 This error exists at least in Leap 42.2. I created a pull request on github with the fix for the SLE12-SP2 branch of systemd. It removes the calls to systemd-sleep-grub from the two units for hibernate. https://github.com/openSUSE/systemd/pull/2 This seems to be long fixed. In 15.0 and later there is bug 1154783 though with a similar effect. |