Bug 947361

Summary:	fillup header content missing due to missing -t option
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Lars Müller <lmuelle>
Component:	Samba	Assignee:	Lars Müller <lmuelle>
Status:	RESOLVED FIXED	QA Contact:	The 'Opening Windows to a Wider World' guys <samba-maintainers>
Severity:	Normal
Priority:	P5 - None	CC:	samba-maintainers
Version:	Current
Target Milestone:	---
Hardware:	All
OS:	SUSE Other
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	No
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:	947377
Bug Blocks:

Description Lars Müller 2015-09-24 15:29:43 UTC

/etc/sysconfig/samba has not the intended two header lines

## Path:           Network/Samba
## Description:    Samba process options

the -t option needs to be added while calling fillup from the client sub
package.

Comment 1 Lars Müller 2015-09-25 14:35:09 UTC

fillup -t option either isn't intended to be used this way or is broken.
Cf bug#947377

To avoid waiting for a fix and to modify fillup the %post scripts of the samba
and samba-winbind package slightly got changed.  Both check if the header is
present and if missing will merge it on top.

Therefore re pre-require samba-client from samba and samba-winbind with
source time-stamp 3492 and later.  This ensures the required content is
available from /var/adm/fillup-templates/sysconfig.samba-client

The not working as expected fillup call from the client package got
removed.

Comment 2 Lars Müller 2015-09-25 23:18:19 UTC

The fix got merged into openSUSE Factory and all other releases.

Comment 4 Bernhard Wiedemann 2015-09-26 00:00:16 UTC

This is an autogenerated message for OBS integration:
This bug (947361) was mentioned in
https://build.opensuse.org/request/show/333817 Factory / samba

Comment 5 Lars Müller 2015-09-26 15:36:19 UTC

The current implementation leads to a duplication like this:

## Path:           Network/Samba
## Description:    Samba process options
## Type:           string
## Default:        "-D"
## ServiceRestart:·nmb
## Type:           string
## Default:        "-D"
## ServiceRestart:·nmb
NMBDOPTIONS="-D"
## Type:           string
## Default:        "-D"
## ServiceRestart:·smb

Comment 6 Lars Müller 2015-10-06 15:03:28 UTC

Due to comment#5 the suggested workaround got reverted.

Comment 7 Lars Müller 2016-02-22 17:33:34 UTC

Duplicated headers merged with commit 3598.

- Shift samba-client sysconfig data into samba and samba-winbind; (bsc#947361).

Comment 8 Bernhard Wiedemann 2016-02-23 16:00:14 UTC

This is an autogenerated message for OBS integration:
This bug (947361) was mentioned in
https://build.opensuse.org/request/show/361133 Factory / samba