Bug 953985

Summary: document rollback disk space leak
Product: [openSUSE] openSUSE Distribution Reporter: Ludwig Nussel <lnussel>
Component: Release NotesAssignee: Stefan Knorr <sknorr>
Status: RESOLVED FIXED QA Contact: Stephan Kulow <coolo>
Severity: Major    
Priority: P5 - None CC: aplanas, aschnell, ke, lnussel, mge
Version: Leap 42.1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 963792    

Description Ludwig Nussel 2015-11-06 13:29:17 UTC
13.2 used a btrfs filesystem layout that caused a disk space leak on rollback. We need to document the steps to switch to the layout used by Leap.

+++ This bug was initially created as a clone of Bug #910501 +++

After the first rollback, the very first root filesystem is no longer accessible. Which means, it is not mounted in /.snapshots.

This means this disk space is "lost" and will never be deleted.

We need a way to delete the data/free up the disk space.

After later rollbacks, the old root filesystem is available below /.snapshots, so that's not a problem.
Comment 2 Karl Eichwalder 2015-11-09 12:14:54 UTC
Please provide a release notes draft.
Comment 3 Ludwig Nussel 2015-11-09 12:25:59 UTC
I'm not an expert on the matter
Comment 4 Arvin Schnell 2015-11-09 16:05:52 UTC
See bug #910501.
Comment 5 Karl Eichwalder 2015-11-17 08:33:41 UTC
(In reply to Arvin Schnell from comment #4)
> See bug #910501.

Stefan, another candidate.
Comment 8 Stefan Knorr 2015-11-26 18:32:59 UTC
Proposal for a RN entry below.

Arvin, can you check if my added prose is (technically) ok? The command line stuff is taken from the TID, so it should be fine.


     Btrfs: Disk Space Leak after System Rollbacks

     openSUSE 13.2 used a Btrfs partition layout that allowed for disk space
     to become permanently occupied with stale, inaccessible contents after the
     first system rollback was executed.
     This layout issue was fixed in openSUSE Leap 42.1, but only for newly
     installed systems.

     If you are upgrading from openSUSE 13.2, you cannot actually convert the
     to the new layout, but you can reclaim the lost disk space.

     1. Mount the initial root filesystem after a rollback:
        mount /dev/<root> -o subvol=@ /mnt
     2. Remove all files below /mnt that are not in a subvolume:
        find /mnt -xdev -delete
     3. Umount the filesystem again:
        umount /mnt
Comment 9 Arvin Schnell 2015-12-04 14:30:03 UTC
AFAIS openSUSE 13.2 does not use the @ subvolume like SLES does do the
mount command is wrong. You likely have to mount subvolid=5.
Comment 10 Stefan Knorr 2015-12-14 12:24:46 UTC
Thanks Arvin!

Resolving fixed.

Added a variant of the above to the RN, but I replaced "subvol=@" replaced with "subvolid=5".
Comment 11 Bernhard Wiedemann 2016-01-27 15:00:09 UTC
This is an autogenerated message for OBS integration:
This bug (953985) was mentioned in
https://build.opensuse.org/request/show/356297 42.1 / release-notes-openSUSE
Comment 12 Swamp Workflow Management 2016-02-04 15:12:58 UTC
openSUSE-RU-2016:0326-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 953985,956173
CVE References: 
Sources used:
openSUSE Leap 42.1 (src):    release-notes-openSUSE-42.1.20160127-6.1