Bug 966637

Summary:	Snapper configuration not automatically set when importing mount points from disk
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Gabriele Tettamanzi <gtettamanzi>
Component:	Installation	Assignee:	YaST Team <yast-internal>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	ancor, aschnell, bill_wayson, gtettamanzi, shundhammer
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
URL:	https://trello.com/c/6H5M4ely
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	Yast2 logs

Description Gabriele Tettamanzi 2016-02-14 14:58:17 UTC

User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build Identifier:

Info: Tumbleweed net installer 20160209-0 - snapper 0.2.10-1.1

I have a /boot partition + a LVM partition; inside the LVM partition I have a logical btrfs / partition and a logical XFS /home one.

I was running Tumbleweed with snapper activated and running. I decided to fresh install my system importing the mount points from the existing ones (expert partitioner -> rescan device first and import mount points second -> accept).

After booting in the fresh installed system, I ran snapper list-configs: no configuration was available.

I expected the installer to set up the "root" config by default.

Work around: manual set up of "root" configuration by running a "sudo snapper create-config /" command and editing the /etc/snapper/configs/root file for tweaking configuration (As a desktop user, I want no timeline snapshots, only number snapshots and a reduced number of them).

Reproducible: Always

Steps to Reproduce:
1.launch the installer
2. at the partition set up step choose "Expert partitioner"
3. click on "Rescan device"
4. click on "Import mount points" and accept, going ahead with the full installation process
5. check after the first boot if there's in place a snapper configuration (run snapper list-configs)

Actual Results:
No "root" config automatically set.

Expected Results:
"root" configuration automatically set up.

I had the same behavior in a previous re installation process - I guess it's not a regression of the installation media I used this time.

Comment 1 Gabriele Mohr 2016-02-25 13:01:19 UTC

Please attach YaST log-files from installation, see http://en.opensuse.org/openSUSE:Report_a_YaST_bug.

Comment 2 Gabriele Tettamanzi 2016-02-25 21:31:42 UTC

(In reply to Gabriele Mohr from comment #1)
> Please attach YaST log-files from installation, see
> http://en.opensuse.org/openSUSE:Report_a_YaST_bug.

The actual installation is more recent than the one I mentioned in the bug - after acting like described in the report, I chose the "Edit proposal settings" and this way I had snapper working out of the box.

I attach the y2logs.

Comment 3 Gabriele Tettamanzi 2016-02-25 21:33:06 UTC

Created attachment 666939 [details]
Yast2 logs

Comment 4 Stefan Hundhammer 2016-03-01 16:23:34 UTC

Now tracking in Trello:

  https://trello.com/c/6H5M4ely

Comment 5 Bill Wayson 2017-01-22 01:01:03 UTC

This still affects TW as of openSUSE-Tumbleweed-DVD-x86_64-Snapshot20170118-Media.iso and openSUSE-Tumbleweed-NET-x86_64-Snapshot20170117-Media.iso.  I believe it also happened during a December, 2016, net installation of openSUSE Leap 42.2, which ended up with no snapshot configuration.

I have just basic openSUSE filesystem layouts: no LVM, just a straight Btrfs root file system.  Reproducing this does not require an installation.  Only an existing /etc/fstab file with a Btrfs file system (mine is root).  Steps to reproduce:

1.Launch the installer
    I (U)EFI booted the installer
2. At the partition set up step choose "Expert partitioner" 
3. Find an existing Btrfs file system in the proposal
    3.a If none exists, create one
4. Right-click the existing Btrfs file system, choose Edit, then press the Subvolume Handling button
5. Note that the Enable Snapshots checkbox is checked
6. Exit out of this dialog
7. Now click on "Import mount points", find the mount point file (fstab) with the existing Btrfs partition, and accept
8. Right-click this Btrfs file system, choose Edit, then press the Subvolume Handling button
9. Note that the Enable Snapshots checkbox is not checked
10. Exit this dialog and Abort your way out of the installation

Comment 6 Arvin Schnell 2017-01-30 09:07:42 UTC

*** Bug 1022131 has been marked as a duplicate of this bug. ***

Comment 7 Ancor Gonzalez Sosa 2018-06-22 06:24:20 UTC

Starting with yast2-storage-ng 4.0.193, that is already submitted to Factory (see SR below), the same logic that is applied when creating a filesystem (if the 
"Operating System Role" was selected) is applied to imported mount points (if they are going to be formatted).

Submit Request: https://build.opensuse.org/request/show/618360

Comment 17 Swamp Workflow Management 2018-08-03 19:15:04 UTC

SUSE-RU-2018:2183-1: An update that has 20 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1065258,1073633,1078359,1081605,1083851,1085134,1089643,1089699,1094157,1094875,1094924,1094963,1095253,1096240,1096758,1097634,1098594,1099691,760213,966637
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Basesystem 15 (src):    libstorage-ng-3.3.312-3.9.3, yast2-firstboot-4.0.5-3.3.5, yast2-installation-4.0.67-3.3.8, yast2-storage-ng-4.0.200-3.13.2, yast2-update-4.0.17-3.4.9
SUSE Linux Enterprise INSTALLER 15 (src):    libstorage-ng-3.3.312-3.9.3, yast2-storage-ng-4.0.200-3.13.2, yast2-update-4.0.17-3.4.9

Comment 18 Swamp Workflow Management 2018-08-08 22:14:33 UTC

openSUSE-RU-2018:2249-1: An update that has 20 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1065258,1073633,1078359,1081605,1083851,1085134,1089643,1089699,1094157,1094875,1094924,1094963,1095253,1096240,1096758,1097634,1098594,1099691,760213,966637
CVE References: 
Sources used:
openSUSE Leap 15.0 (src):    libstorage-ng-3.3.312-lp150.2.6.1, yast2-firstboot-4.0.5-lp150.2.3.1, yast2-installation-4.0.67-lp150.2.9.1, yast2-storage-ng-4.0.200-lp150.2.9.1, yast2-update-4.0.17-lp150.2.3.1