Bug 975879

Summary:	plymouthd crashes in ply_event_loop_stop_watching_fd
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Forgotten User MQMBH8TW5n <forgotten_MQMBH8TW5n>
Component:	Basesystem	Assignee:	Cliff Zhao <qzhao>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	herbert, mischa.salle, sreeves
Version:	Current
Target Milestone:	---
Hardware:	x86-64
OS:	SUSE Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Forgotten User MQMBH8TW5n 2016-04-17 16:26:03 UTC

In my openSUSE Tumbleweed installation, plymouthd always coredumps during startup. Backtrace:

#0  ply_event_loop_get_destination_from_fd_watch (loop=0x7974742f7665642f, watch=0x21) at ply-event-loop.c:449
#1  0x00007f0d1675920b in ply_event_loop_stop_watching_fd (loop=0x7974742f7665642f, watch=0x21) at ply-event-loop.c:750
#2  0x00007f0d165458f7 in ply_terminal_close () from /usr/lib64/libply-splash-core.so.4
#3  0x00007f0d1675cc53 in ply_hashtable_foreach (hashtable=0x180f8e0, func=0x7f0d16545870 <ply_terminal_close>, user_data=0x180ff20) at ply-hashtable.c:268
#4  0x000000000040c050 in quit_splash (state=state@entry=0x7ffd0872a000) at main.c:1064
#5  0x000000000040c8af in on_boot_splash_idle (state=0x7ffd0872a000) at main.c:1196
#6  0x00007f0d16759d2a in ply_event_loop_handle_timeouts (loop=0x180a150) at ply-event-loop.c:1192
#7  ply_event_loop_process_pending_events (loop=loop@entry=0x180a150) at ply-event-loop.c:1251
#8  0x00007f0d1675a340 in ply_event_loop_run (loop=0x180a150) at ply-event-loop.c:1310
#9  0x0000000000405454 in main (argc=<optimized out>, argv=<optimized out>) at main.c:2233


plymouth package version: 0.9.2-2.1

I also reported this at https://bugs.freedesktop.org/show_bug.cgi?id=94952, but later noticed that the stacktrace points to OpenSUSE patches (ply_close_all_terminals in quit_splash).

Comment 1 Herbert Meier 2016-12-01 20:11:03 UTC

This bug is also present in Leap 42.2
plymouth-0.9.2-2.2.x86_64

Stack trace has one more entry but it looks like the same issue:
#0  ply_event_loop_get_destination_from_fd_watch (loop=0x7974742f7665642f, watch=0x21) at ply-event-loop.c:449
#1  0x00007fc62f5c01db in ply_event_loop_stop_watching_fd (loop=0x7974742f7665642f, watch=0x21) at ply-event-loop.c:750
#2  0x00007fc62f3ac84c in ply_terminal_close (terminal=0x1779cc0) at ply-terminal.c:686
#3  0x00007fc62f5c3c33 in ply_hashtable_foreach (hashtable=0x17798e0, func=0x7fc62f3ac7c0 <ply_terminal_close>, user_data=0x1779f20) at ply-hashtable.c:268
#4  0x00007fc62f3a9573 in ply_close_all_terminals (manager=<optimized out>) at ply-device-manager.c:933
#5  0x000000000040c1e8 in quit_splash (state=state@entry=0x7ffc8782b990) at main.c:1064
#6  0x000000000040d8cf in on_boot_splash_idle (state=0x7ffc8782b990) at main.c:1196
#7  0x00007fc62f5c0d02 in ply_event_loop_handle_timeouts (loop=0x1774150) at ply-event-loop.c:1192
#8  ply_event_loop_process_pending_events (loop=loop@entry=0x1774150) at ply-event-loop.c:1251
#9  0x00007fc62f5c12f0 in ply_event_loop_run (loop=0x1774150) at ply-event-loop.c:1310
#10 0x00000000004055bf in main (argc=<optimized out>, argv=<optimized out>) at main.c:2236

Comment 2 Cliff Zhao 2017-05-15 08:13:16 UTC

(In reply to Daniel Lichtenberger from comment #0)
> In my openSUSE Tumbleweed installation, plymouthd always coredumps during
> startup. Backtrace:
> 
Daniel:

Could you please show me the core dump.

Comment 3 Forgotten User MQMBH8TW5n 2017-05-19 16:08:18 UTC

I no longer get crashes in Tumbleweed with 0.9.2+git20161215.18dd755-2.1. 

The plymouth package has been cleaned up quite a bit since this bug was reported:
https://build.opensuse.org/package/revisions/Base:System/plymouth

It seems like the patch containing the troublesome code (0001-let-it-become-a-real-daemon.patch) was dropped 4 months ago. As far as I'm concerned, this issue could be closed.

Comment 4 Cliff Zhao 2019-11-15 06:52:46 UTC

(In reply to Daniel Lichtenberger from comment #3)
> I no longer get crashes in Tumbleweed with 0.9.2+git20161215.18dd755-2.1. 
> 
> The plymouth package has been cleaned up quite a bit since this bug was
> reported:
> https://build.opensuse.org/package/revisions/Base:System/plymouth
> 
> It seems like the patch containing the troublesome code
> (0001-let-it-become-a-real-daemon.patch) was dropped 4 months ago. As far as
> I'm concerned, this issue could be closed.

So will close it because the crash no longer happened, if it reproduces in the future, please feel free to reopen. Thanks!