Bug 983927

Summary: virtualbox-guest KMP breaks weak-updates also for kernel modules of other KMPs like NVIDIA
Product: [openSUSE] openSUSE Distribution Reporter: Forgotten User 7CGz1Dtadp <forgotten_7CGz1Dtadp>
Component: X11 3rd Party DriverAssignee: Larry Finger <Larry.Finger>
Status: RESOLVED FIXED QA Contact: Stefan Dirsch <sndirsch>
Severity: Major    
Priority: P2 - High CC: amajer, forgotten_OvlPd7Jcli, Larry.Finger, mmarek, PVince81, slacky2005, sndirsch, wbauer
Version: Leap 42.1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Forgotten User 7CGz1Dtadp 2016-06-09 09:56:43 UTC
Installing nvidia-gfxG04-kmp-default (367.18_k4.1.12_1-25.1) updates the weak-references modules of 4.1.20-11-default instead of (the most recent) 4.1.21-14-default

After install & reboot X11 don't start

Workaround (for me):
# cd /lib/modules/`uname -r`/weak-updates/updates
# cp -P /lib/modules/4.1.20-11-default/weak-updates/updates/* .
# depmod
# modprobe nvidia
# lsmod | grep nvidia
# reboot
Comment 1 Stefan Dirsch 2016-06-09 14:31:53 UTC
Ok. I could reproduce the update issue. Although I see a different issue. I've updated from 361.42 to 367.18.

# Xorg
rmmod: ERROR: Module nvidia_modeset is in use by: nvidia_drm
# rmmod nvidia_drm
# rmmod nvidia_modeset
# rmmod nvidia
# Xorg
[works]

Seems like the nvidia kernel modules in initrd were not updated. Size of these modules is even different to the ones of 361.42!?! Runnind mkinitrd (again) doesn't change that.

# rpm -qlv nvidia-gfxG04-kmp-default-367.18_k4.1.12_1-25.1.x86_64|grep updates
drwxr-xr-x    2 root    root                        0 Jun  8 11:11 /lib/modules/4.1.12-1-default/updates
-rw-r--r--    1 root    root                  2677104 Jun  8 11:11 /lib/modules/4.1.12-1-default/updates/nvidia-drm.ko
-rw-r--r--    1 root    root                  1337456 Jun  8 11:11 /lib/modules/4.1.12-1-default/updates/nvidia-modeset.ko
-rw-r--r--    1 root    root                 23799712 Jun  8 11:11 /lib/modules/4.1.12-1-default/updates/nvidia-uvm.ko
-rw-r--r--    1 root    root                 20751272 Jun  8 11:11 /lib/modules/4.1.12-1-default/updates/nvidia.ko

# rpm -qplv nvidia-gfxG04-kmp-default-361.42_k4.1.12_1-21.1.x86_64.rpm|grep updates
drwxr-xr-x    2 root    root                        0 Apr  6 15:04 /lib/modules/4.1.12-1-default/updates
-rw-r--r--    1 root    root                  1301120 Apr  6 15:04 /lib/modules/4.1.12-1-default/updates/nvidia-modeset.ko
-rw-r--r--    1 root    root                 22622120 Apr  6 15:04 /lib/modules/4.1.12-1-default/updates/nvidia-uvm.ko
-rw-r--r--    1 root    root                 19629392 Apr  6 15:04 /lib/modules/4.1.12-1-default/updates/nvidia.ko

# lsinitrd /boot/initrd|grep updates
-rw-r--r--   1 root     root        84896 Jun  9 15:58 lib/modules/4.1.12-1-default/updates/nvidia-drm.ko
-rw-r--r--   1 root     root      1049640 Jun  9 15:58 lib/modules/4.1.12-1-default/updates/nvidia-modeset.ko
-rw-r--r--   1 root     root      1137856 Jun  9 15:58 lib/modules/4.1.12-1-default/updates/nvidia-uvm.ko
-rw-r--r--   1 root     root     15211424 Jun  9 15:58 lib/modules/4.1.12-1-default/updates/nvidia.ko
Comment 2 Stefan Dirsch 2016-06-09 14:36:39 UTC
FWIW, I've removed nvidia-gfxG04-kmp-default, ran mkinitrd in order to make sure that modules are removed from initrd now, which I could confirm. Then I reinstalled nvidia-gfxG04-kmp-default and ran mkinitrd again. Again the modules are added to initrd with the same (diffferent) size. But after reboot now Xserver comes up fine. No idea what's going on here.
Comment 3 Stefan Dirsch 2016-06-09 15:56:45 UTC
Closing as duplicate.

*** This bug has been marked as a duplicate of bug 983934 ***
Comment 4 Stefan Dirsch 2016-06-15 12:48:10 UTC
The issue from initial description appears to differ from boo#983934. Reopening therefore. Please ignore my comments 1-3 here.
Comment 5 Stefan Dirsch 2016-06-15 12:50:08 UTC
Update for 367.27 update by Cees van Nieuwenhuize:

After update to G04 ver 367.27 X11 doesn't come up.

The system I updated to 367.18 last week (and manually copied & installed the nvidia-drivers: see bug 983927) won't start X after updating to 367.27

Problem is identical:
The links to the nvidia kernel drivers are in the module directory of an old kernel version. 
Workaround is also identical:
# cd /lib/modules/`uname -r`/weak-updates/updates
# cp -P /lib/modules/4.1.20-11-default/weak-updates/updates/* .
# depmod
# modprobe nvidia
(checking if module loads:)
# lsmod | grep nvidia
# reboot

I don't know if the error is unique for my system (and it's 'adapted' configuration), or also occurs on an update from 361.42.
Comment 6 Stefan Dirsch 2016-06-15 12:54:39 UTC
I never could reproduce this issue. It's almost impossible to investigate such an issue without root access to it (via ssh e.g.).
Comment 7 Wolfgang Bauer 2016-06-15 14:55:29 UTC
Do you maybe have the virtualbox guest additions installed?

Apparently they (virtualbox-guest-kmp-default in particular) "break" the creation of the symlinks by the weak-updates script currently in Leap 42.1, with the following error messages:
depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTLogBackdoorPrintf
depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTErrConvertToErrno
depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertShouldPanic
depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg1Weak
depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg2Weak
Warning: /lib/modules/4.1.21-14-default is inconsistent
Warning: weak-updates symlinks might not be created

So uninstall virtualbox-guest-kmp-default if it's installed, and reinstall nvidia-gfxG04-kmp-default and it should work.
Comment 8 Forgotten User 7CGz1Dtadp 2016-06-15 15:42:02 UTC
(In reply to Wolfgang Bauer from comment #7)
> Do you maybe have the virtualbox guest additions installed?
> 
> Apparently they (virtualbox-guest-kmp-default in particular) "break" the
> creation of the symlinks by the weak-updates script currently in Leap 42.1,
> with the following error messages:
> depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees
> about version of symbol VBoxGuest_RTLogBackdoorPrintf
> depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees
> about version of symbol VBoxGuest_RTErrConvertToErrno
> depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees
> about version of symbol VBoxGuest_RTAssertShouldPanic
> depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees
> about version of symbol VBoxGuest_RTAssertMsg1Weak
> depmod: WARNING: //lib/modules/4.1.21-14-default/misc/vboxvideo.ko disagrees
> about version of symbol VBoxGuest_RTAssertMsg2Weak
> Warning: /lib/modules/4.1.21-14-default is inconsistent
> Warning: weak-updates symlinks might not be created
> 
> So uninstall virtualbox-guest-kmp-default if it's installed, and reinstall
> nvidia-gfxG04-kmp-default and it should work.

Yeah, virtualbox was installed.
Checking the /var/log/zypp/history file shows the mentioned warnings.
I haven't re-installed 'nvidia-gfxG04-kmp-default', (it works at the moment after all), but this might be the problem.
Thanks!
Comment 9 Stefan Dirsch 2016-06-15 15:56:46 UTC
Indeed I can 100% reproduce the issue when virtualbox-guest-kmp-default is installed.
Comment 10 Stefan Dirsch 2016-06-15 16:00:38 UTC
I'm not sure why this breaks things also for other modules than virtualbox though. Michal M.?
Comment 11 Stefan Dirsch 2016-06-15 16:01:42 UTC
Larry, are you aware of this issue as virtualbox maintainer?
Comment 12 Michal Marek 2016-06-15 19:28:48 UTC
weak-modules2 needs a consistent module tree to be able to determine if the new KMP is compatible. If the tree is broken, it can't recognize a compatible KMP.
Comment 13 Stefan Dirsch 2016-06-16 09:00:38 UTC
Reassigning to maintainer of virtualbox. The issue needs to be fixed in this package.
Comment 14 Larry Finger 2016-06-20 14:45:02 UTC
(In reply to Stefan Dirsch from comment #11)
> Larry, are you aware of this issue as virtualbox maintainer?

No, I was not aware of the issue. What do I need to do to the package to fix the problem?
Comment 15 Stefan Dirsch 2016-06-20 14:52:36 UTC
Apparently one of the latest updates of virtualbox-guest KMPs broke the kABI. This needs to be fixed. Maybe you can figure out first, with which change this came in?

Besides that, I'm curious why these KMPs are installed on hosts at all. I thought these would be only useful for the guest ?!? So how are/were these packages got dragged in?
Comment 16 Stefan Dirsch 2016-06-20 15:50:13 UTC
Still works with virtualbox.4916 with latest changelog entry:

-------------------------------------------------------------------
Mon Apr  4 17:53:30 UTC 2016 - Larry.Finger@lwfinger.net

-  Version bump to 5.0.16 (released 2016-03-04 by Oracle)


So either 5.0.18 or one of the later changes broke it.
Comment 17 Egbert Eich 2016-06-20 16:22:49 UTC
This is a bit strange as all the symbols are provided by vboxguest.ko which is part of the same package ie virtualbox-guest-kmp-default.
None of these symbols are used outside of the modules shipped with virtualbox-guest-kmp-default.

I don't see why virtualbox-guest-kmp-default should get installed on a server:
1. It 'enhances' the kernel-default package
2. It 'supplements' the PCI IDs of the virtualbox devices.
Only the latter causes the package to be installed.

Maybe the user pulled in the package manually?
Comment 18 Larry Finger 2016-06-20 17:34:08 UTC
I think the user manually pulled in the guest kmp packages as my default install has none of the VirtualBox packages. Still, selecting the guest parts should not affect the kernel symbols.

As far as I recall, I have not received any build failure messages for the Leap 42.1 packages, although I did get notification that the package failed with Leap 42.2. In any case, I have done a version bump to 5.0.22. As 5.0.20 had some problems with Xorg, I skipped it. That issue would have affected only VMs, but that seems to cover a lot of Leap installations.

The new version builds locally under osc, and with OBS after the commit. I have just submitted a Maintenance Request for the new version.
Comment 19 sidro ovidiu 2016-06-28 18:53:11 UTC
(2/4) Installing: virtualbox-host-kmp-default-5.0.22_k4.1.26_21-19.1.x86_64 ..................................................................................................[done]
Additional rpm output:
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTLogBackdoorPrintf
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTErrConvertToErrno
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertShouldPanic
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg1Weak
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg2Weak
Warning: /lib/modules/4.1.26-21-default is inconsistent
Warning: weak-updates symlinks might not be created
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTLogBackdoorPrintf
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTErrConvertToErrno
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertShouldPanic
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg1Weak
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg2Weak
Warning: /lib/modules/4.1.26-21-default is inconsistent
Warning: weak-updates symlinks might not be created
Comment 20 Larry Finger 2016-07-03 19:15:29 UTC
I have no idea why this is happening for you. I have installed a copy of Leap 42.1 KDE and installed VirtualBox 5.0.22_k4.1.26_21-19.1-x86_64 with no problem. My kernel is 4.1.26-21-default as shown by 'uname -r'.

This version was created on June 21, 2016 and does match the current kernel.

Version 5.0.24 has been submitted to the build system.

What kernel are you using?
Comment 21 Stefan Dirsch 2016-07-04 09:55:27 UTC
Larry, I can easily reproduce this with kernel version 4.1.21-14-default
by installing virtualbox-guest on the host system.

Retrieving package virtualbox-guest-kmp-default-5.0.22_k4.1.26_21-19.1.x86_64                                          (1/1), 366,5 KiB (621,6 KiB unpacked)
Retrieving: virtualbox-guest-kmp-default-5.0.22_k4.1.26_21-19.1.x86_64.rpm ...............................................................[done (3,7 MiB/s)]
Checking for file conflicts: .........................................................................................................................[done]
(1/1) Installing: virtualbox-guest-kmp-default-5.0.22_k4.1.26_21-19.1 ................................................................................[done]
Additional rpm output:
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTLogBackdoorPrintf
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTErrConvertToErrno
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertShouldPanic
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg1Weak
depmod: WARNING: //lib/modules/4.1.26-21-default/misc/vboxvideo.ko disagrees about version of symbol VBoxGuest_RTAssertMsg2Weak
Warning: /lib/modules/4.1.26-21-default is inconsistent
Warning: weak-updates symlinks might not be created
Comment 22 Stefan Dirsch 2016-07-04 10:04:15 UTC
And I see exactly the same issue with 4.1.26-21-default (latest available update kernel for openSUSE Leap 42.1).
Comment 23 Larry Finger 2016-07-04 17:23:01 UTC
Do you have a stale version of the VB modules in /lib/modules/`uname -r`/updates/? The modules were recently moved from there to misc to match what Oracle was doing. That way it will be possible to switch from their version to ours.

What is the output of 'ls /lib/modules/`uname -r`/misc?

What is the output of 'ls -l /lib/modules/`uname -r`/weak-updates/'?
Comment 24 Stefan Dirsch 2016-07-05 09:48:19 UTC
# ll /lib/modules/`uname -r`/misc
total 628
-rw-r--r-- 1 root root 461586 21. Jun 13:06 vboxguest.ko
-rw-r--r-- 1 root root  79290 21. Jun 13:06 vboxsf.ko
-rw-r--r-- 1 root root  95682 21. Jun 13:06 vboxvideo.ko

# rpm -qlv virtualbox-guest-kmp-default-5.0.22_k4.1.26_21-19.1.x86_64
drwxr-xr-x    2 root    root                        0 Jun 21 12:55 /lib/modules/4.1.26-21-default
drwxr-xr-x    2 root    root                        0 Jun 21 12:56 /lib/modules/4.1.26-21-default/misc
-rw-r--r--    1 root    root                   461586 Jun 21 13:06 /lib/modules/4.1.26-21-default/misc/vboxguest.ko
-rw-r--r--    1 root    root                    79290 Jun 21 13:06 /lib/modules/4.1.26-21-default/misc/vboxsf.ko
-rw-r--r--    1 root    root                    95682 Jun 21 13:06 /lib/modules/4.1.26-21-default/misc/vboxvideo.ko

# ls -l /lib/modules/`uname -r`/weak-updates/
total 0
drwxr-xr-x 1 root root   0  4. Jul 11:53 misc
drwxr-xr-x 1 root root 104  4. Jul 11:43 updates

# ls -l /lib/modules/`uname -r`/weak-updates/misc
total 0

# ls -l /lib/modules/`uname -r`/weak-updates/updates
total 16
lrwxrwxrwx 1 root root 51  4. Jul 11:43 nvidia-drm.ko -> /lib/modules/4.1.12-1-default/updates/nvidia-drm.ko
lrwxrwxrwx 1 root root 55  4. Jul 11:43 nvidia-modeset.ko -> /lib/modules/4.1.12-1-default/updates/nvidia-modeset.ko
lrwxrwxrwx 1 root root 51  4. Jul 11:43 nvidia-uvm.ko -> /lib/modules/4.1.12-1-default/updates/nvidia-uvm.ko
lrwxrwxrwx 1 root root 47  4. Jul 11:43 nvidia.ko -> /lib/modules/4.1.12-1-default/updates/nvidia.ko
Comment 25 Larry Finger 2016-07-05 14:41:06 UTC
(In reply to Stefan Dirsch from comment #24)
> # ll /lib/modules/`uname -r`/misc
> total 628
> -rw-r--r-- 1 root root 461586 21. Jun 13:06 vboxguest.ko
> -rw-r--r-- 1 root root  79290 21. Jun 13:06 vboxsf.ko
> -rw-r--r-- 1 root root  95682 21. Jun 13:06 vboxvideo.ko
> 
> # rpm -qlv virtualbox-guest-kmp-default-5.0.22_k4.1.26_21-19.1.x86_64
> drwxr-xr-x    2 root    root                        0 Jun 21 12:55
> /lib/modules/4.1.26-21-default
> drwxr-xr-x    2 root    root                        0 Jun 21 12:56
> /lib/modules/4.1.26-21-default/misc
> -rw-r--r--    1 root    root                   461586 Jun 21 13:06
> /lib/modules/4.1.26-21-default/misc/vboxguest.ko
> -rw-r--r--    1 root    root                    79290 Jun 21 13:06
> /lib/modules/4.1.26-21-default/misc/vboxsf.ko
> -rw-r--r--    1 root    root                    95682 Jun 21 13:06
> /lib/modules/4.1.26-21-default/misc/vboxvideo.ko
> 
> # ls -l /lib/modules/`uname -r`/weak-updates/
> total 0
> drwxr-xr-x 1 root root   0  4. Jul 11:53 misc
> drwxr-xr-x 1 root root 104  4. Jul 11:43 updates
> 
> # ls -l /lib/modules/`uname -r`/weak-updates/misc
> total 0
> 
> # ls -l /lib/modules/`uname -r`/weak-updates/updates
> total 16
> lrwxrwxrwx 1 root root 51  4. Jul 11:43 nvidia-drm.ko ->
> /lib/modules/4.1.12-1-default/updates/nvidia-drm.ko
> lrwxrwxrwx 1 root root 55  4. Jul 11:43 nvidia-modeset.ko ->
> /lib/modules/4.1.12-1-default/updates/nvidia-modeset.ko
> lrwxrwxrwx 1 root root 51  4. Jul 11:43 nvidia-uvm.ko ->
> /lib/modules/4.1.12-1-default/updates/nvidia-uvm.ko
> lrwxrwxrwx 1 root root 47  4. Jul 11:43 nvidia.ko ->
> /lib/modules/4.1.12-1-default/updates/nvidia.ko

The links in ../weak-updates/updates/ and the files in ../updates/ are the problem. On my system, I get

finger@linux-1t8h:~/home:lwfinger:branches:Virtualization/virtualbox> ls -l /lib/modules/`uname -r`/weak-updates/
total 4
drwxr-xr-x 2 root root 4096 Jun 30 20:01 misc
finger@linux-1t8h:~/home:lwfinger:branches:Virtualization/virtualbox> ls -l /lib/modules/`uname -r`/weak-updates/misc/
total 0
lrwxrwxrwx 1 root root 46 Jun 30 20:01 vboxdrv.ko -> /lib/modules/4.1.26-21-default/misc/vboxdrv.ko
lrwxrwxrwx 1 root root 49 Jun 30 20:01 vboxnetadp.ko -> /lib/modules/4.1.26-21-default/misc/vboxnetadp.ko
lrwxrwxrwx 1 root root 49 Jun 30 20:01 vboxnetflt.ko -> /lib/modules/4.1.26-21-default/misc/vboxnetflt.ko
lrwxrwxrwx 1 root root 46 Jun 30 20:01 vboxpci.ko -> /lib/modules/4.1.26-21-default/misc/vboxpci.ko

Please use "rm -rf /lib/modules/`uname -r`/weak-updates/updates/" and "rm -rf /lib/modules/`uname -r`/updates/" to get rid of the old modules, and then reinstall virtualbox. That should fix the problem. As I said earlier, a change was made to make openSUSE's installation place files in the same locations as Oracle's setup. I see now that some systems could be caught in the transition.
Comment 26 Stefan Dirsch 2016-07-05 15:26:13 UTC
No, it doesn't help to remove the NVIDIA kernel modules. weak-updates/ is completely empty now.
Comment 27 Stefan Dirsch 2016-07-06 13:02:48 UTC
No longer works with virtualbox.5133 with latest changelog entry:

-------------------------------------------------------------------
Fri May  6 20:04:53 UTC 2016 - Larry.Finger@lwfinger.net

-  Fix start failure of vboxadd service routine
   This script fails because /var/lib/VBoxGuestAdditions/config does not exist; however, there is no need
   for this file. That service routine is modified.
   (boo #977328).

So apparently update to 5.0.18 broke it. I verified that Egbert's patches drm-vboxvideo*.patch aren't the culprit here.

It's a pity that the virtualbox maintainer can't reproduce the issue but anybody else can. :-(
Comment 28 Forgotten User OvlPd7Jcli 2016-08-16 19:54:10 UTC
I just found out about this report today, after updating my LEAP installations and having nVidia drivers compromised. Removing the guest add-ons for VirtualBox solved the problem in my case.

Maybe preventing the installation/co-existence of that package with nVidia KMP packages would help? Or are there scenarios where both are needed at the same time?
Comment 29 Stefan Dirsch 2016-08-17 09:21:46 UTC
(In reply to Alberto Passalacqua from comment #28)
> Maybe preventing the installation/co-existence of that package with nVidia
> KMP packages would help? Or are there scenarios where both are needed at the
> same time?

If I understood correctly Virtualbox guest add-ons are not needed at all on host systems. No idea, why these are installed on (some?) systems (by default?).
Comment 30 Wolfgang Bauer 2016-08-17 10:06:14 UTC
(In reply to Stefan Dirsch from comment #29)
> (In reply to Alberto Passalacqua from comment #28)
> > Maybe preventing the installation/co-existence of that package with nVidia
> > KMP packages would help? Or are there scenarios where both are needed at the
> > same time?
> 
> If I understood correctly Virtualbox guest add-ons are not needed at all on
> host systems. No idea, why these are installed on (some?) systems (by
> default?).

Because of this:
$ rpm -qp --supplements http://download.opensuse.org/update/leap/42.1/oss/x86_64/virtualbox-host-kmp-default-5.0.24_k4.1.27_27-25.1.x86_64.rpm 
packageand(kernel-default:virtualbox)
Comment 31 Wolfgang Bauer 2016-08-17 10:09:04 UTC
Oops, sorry, that was the host kmp by mistake.

But it's the same with the guest kmp:
$ rpm -qp --supplements http://download.opensuse.org/update/leap/42.1/oss/x86_64/virtualbox-guest-kmp-default-5.0.24_k4.1.27_27-25.1.x86_64.rpm 
modalias(kernel-default:pci:v000080EEd0000BEEFsv*sd*bc*sc*i*)
modalias(kernel-default:pci:v000080EEd0000CAFEsv00000000sd00000000bc*sc*i*)
packageand(kernel-default:virtualbox)

So if kernel-default and virtualbox are installed, virtualbox-guest-kmp-default will be installed too (as recommended package).
Comment 32 Wolfgang Bauer 2016-08-17 10:12:21 UTC
PS: Years ago the host and guest kmp packages conflicted with each other.
Those conflicts are still in the packages, e.g.:
rpm -qp --conflicts http://download.opensuse.org/update/leap/42.1/oss/x86_64/virtualbox-host-kmp-default-5.0.24_k4.1.27_27-25.1.x86_64.rpm 
virtualbox-ose-guest-kmp

Maybe this should be reinstated/the names updated to the current ones?
Comment 33 Egbert Eich 2016-08-17 10:52:13 UTC
(In reply to Wolfgang Bauer from comment #31)
> Oops, sorry, that was the host kmp by mistake.
> 
> But it's the same with the guest kmp:
> $ rpm -qp --supplements
> http://download.opensuse.org/update/leap/42.1/oss/x86_64/virtualbox-guest-
> kmp-default-5.0.24_k4.1.27_27-25.1.x86_64.rpm 
> modalias(kernel-default:pci:v000080EEd0000BEEFsv*sd*bc*sc*i*)
> modalias(kernel-default:pci:v000080EEd0000CAFEsv00000000sd00000000bc*sc*i*)
> packageand(kernel-default:virtualbox)
> 
> So if kernel-default and virtualbox are installed,
> virtualbox-guest-kmp-default will be installed too (as recommended package).

This seems wrong. Unless you want to run virtualbox inside virtualbox, you should not have virtualbox and the guest-kmps installed.
There should instead be a dependency on the host-kmps.

Larry?

(In reply to Wolfgang Bauer from comment #32)
> PS: Years ago the host and guest kmp packages conflicted with each other.
> Those conflicts are still in the packages, e.g.:
> rpm -qp --conflicts
> http://download.opensuse.org/update/leap/42.1/oss/x86_64/virtualbox-host-kmp-
> default-5.0.24_k4.1.27_27-25.1.x86_64.rpm 
> virtualbox-ose-guest-kmp

Not sure what provides virtualbox-ose-guest-kmp - this could really be an old name.
Comment 34 Wolfgang Bauer 2016-08-17 11:06:10 UTC
(In reply to Egbert Eich from comment #33)
> This seems wrong. Unless you want to run virtualbox inside virtualbox, you
> should not have virtualbox and the guest-kmps installed.

I think this comes from the kmp macros.
At least I didn't find anything that adds this in the virtualbox files.

> There should instead be a dependency on the host-kmps.

There is a dependency on the host kmps in the main package:
$ rpm -qp --requires http://download.opensuse.org/update/leap/42.1/oss/x86_64/virtualbox-5.0.24-25.1.x86_64.rpm | grep kmp
virtualbox-host-kmp = 5.0.24

And the host kmp has this packageand(kernel-default:virtualbox) as shown (by mistake)

> Not sure what provides virtualbox-ose-guest-kmp - this could really be an
> old name.

Yes, that's how they were called years ago.
Regarding the conflict, this was added back then because of problems when having both kmps installed, see bug#661740

I just fear that adding this conflict will cause update problems, especially when using PackageKit...
Comment 35 Adam Majer 2016-08-29 08:37:23 UTC
Any updates on this?

It's not exactly clear for users that virtualbox is the cause when they boot and X is not coming up after a kernel update.
Comment 36 Michal Marek 2016-09-01 11:58:03 UTC
Wolfgang is right, the conflicts dependency still refers to the old name. I submitted a fix via sr#424220.
Comment 37 Wolfgang Bauer 2016-09-02 20:47:54 UTC
(In reply to Michal Marek from comment #36)
> Wolfgang is right, the conflicts dependency still refers to the old name. I
> submitted a fix via sr#424220.

Ok, that fixes the problem with weak-updates on the host.

But virtualbox-guest-kmp is still broken, and the vboxvideo kernel module fails to load in a guest.
I submitted a fix:
https://build.opensuse.org/request/show/424529

I'm reopening this for now, as there should also be updates for the affected openSUSE versions.
AFAICS only Leap 42.1 and 13.1 are affected, the specfile in 13.2:Update does still copy the module symbols for vboxvideo.

I'll prepare the updates...
Comment 38 Wolfgang Bauer 2016-09-13 10:43:42 UTC
(In reply to Wolfgang Bauer from comment #37)
> I'll prepare the updates...

Update submitted for 42.1:
https://build.opensuse.org/request/show/427236

I checked and 13.1 is actually not affected, likely because it only has version 4.2.36...
Comment 39 Bernhard Wiedemann 2016-09-13 12:00:44 UTC
This is an autogenerated message for OBS integration:
This bug (983927) was mentioned in
https://build.opensuse.org/request/show/427237 42.2 / virtualbox
Comment 40 Swamp Workflow Management 2016-09-15 15:11:40 UTC
openSUSE-SU-2016:2314-1: An update that solves two vulnerabilities and has one errata is now available.

Category: security (moderate)
Bug References: 983927,990369,990370
CVE References: CVE-2016-3597,CVE-2016-3612
Sources used:
openSUSE 13.2 (src):    virtualbox-5.0.26-51.1
Comment 41 Wolfgang Bauer 2016-09-16 20:53:08 UTC
Update for 42.1 released, this should be fixed now on all distribution versions.
Comment 42 Swamp Workflow Management 2016-09-16 23:08:57 UTC
openSUSE-RU-2016:2333-1: An update that has two recommended fixes can now be installed.

Category: recommended (important)
Bug References: 983927,998369
CVE References: 
Sources used:
openSUSE Leap 42.1 (src):    virtualbox-5.0.26-31.1