Bug 984901

Summary:	Documentation bug: Manpage & help don't mention that "zypper mr -n" needs an argument (new name) before the repo identifier
Product:	[openSUSE] openSUSE Distribution	Reporter:	Tony Mechelynck <antoine.mechelynck>
Component:	libzypp	Assignee:	E-mail List <zypp-maintainers>
Status:	VERIFIED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P5 - None
Version:	Leap 42.1
Target Milestone:	---
Hardware:	All
OS:	openSUSE 42.1
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Tony Mechelynck 2016-06-15 17:22:09 UTC

For other options requiring an argument, this is stated, i.e.
  -p --priority _positive integer_
  -m --medium-type _type_
in the "modifyrepo (mr)" section of the zypper manpage, or
  -p --priority <integer>
  -m --medium-type <type>
in the "zypper help mr" text.

Not so for the -n --name option. So how is the new name specified? Interactively, by zypper asking you a question? No. After the repo identifier? No. Only by specifying the new name immediately after the option, before the repo (existing) name, alias, # or URL, will the desired result be obtained.

This is the opposite of what happens for "zypper nr" (zypper renamerepo) where the new alias is specified after the repo's existing alias, name, # or URL. This is understandable since in "zypper nr" the alias is not an option argument but IMHO an explicit mention in the docs would be useful.

Comment 1 Michael Andres 2016-06-16 09:30:35 UTC

Thanks; same applies to 'modifyservice --name'.

Fixed for zypper-1.13.3
  SLE-12-SP1      zypper 1.12.42
  LEAP-42_1       zypper 1.12.42

Comment 2 Tony Mechelynck 2016-07-07 10:12:30 UTC

(In reply to Michael Andres from comment #1)
> Thanks; same applies to 'modifyservice --name'.
> 
> Fixed for zypper-1.13.3
>   SLE-12-SP1      zypper 1.12.42
>   LEAP-42_1       zypper 1.12.42

FWIW, the fix hasn't yet appeared on the public 42.1 openSUSE repositories, not even on Update-Test. At the moment, the highest version with vendor openSUSE that I see is zypper-1.12.40-9.1-x86_64 on the Update-OSS repo.

OT1H, I expect this to be a "no risk" change, but OTOH, there might be translations to think of, so I am not in a hurry. Just to explain why I cannot VERIFY this fix.

Comment 3 Michael Andres 2016-07-07 11:24:14 UTC

The packages we submit have to pass mainenance QA before they are released as official updates. They will also take care dependent packages get rebuilt and offered as well. 
AFAICS QA is currently testing 1.12.44, so maybe they will wait for that version...


JFYI: OBS project containing the latest version:
(but just the zypp stack, no dependent packages)
https://build.opensuse.org/project/show/zypp:Code42_1-Branch

Comment 4 Swamp Workflow Management 2016-07-13 17:09:45 UTC

SUSE-RU-2016:1793-1: An update that has 9 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 933760,980263,980901,982379,983141,984494,984901,985674,986694
CVE References: 
Sources used:
SUSE Linux Enterprise Software Development Kit 12-SP1 (src):    libsolv-0.6.22-2.31.2, libzypp-15.22.2-25.1
SUSE Linux Enterprise Server 12-SP1 (src):    libsolv-0.6.22-2.31.2, libzypp-15.22.2-25.1, zypper-1.12.44-28.1
SUSE Linux Enterprise Desktop 12-SP1 (src):    libsolv-0.6.22-2.31.2, libzypp-15.22.2-25.1, zypper-1.12.44-28.1

Comment 5 Tony Mechelynck 2016-07-14 00:06:16 UTC

Patch 5361 for the openSUSE 42.1 Update-Test repository includes the desired improvements. After installing it, I VERIFY that the problem mentioned in comment #0 no longer exists.

Comment 6 Tony Mechelynck 2016-07-14 00:13:17 UTC

P.S. The patch in question updates the following packages to the following versions:

libsolv-tools   0.6.22-12.1
libzypp         15.22.2-12.1
python-solv     0.6.22-12.1
zypper          1.12.44-12.1
zypper-aptitude 1.12.44-12.1
zypper-log      1.12.44-12.1

Of course, it may or may not have additional fixes for packages not installed here.

Comment 7 Swamp Workflow Management 2016-07-23 15:12:45 UTC

openSUSE-RU-2016:1862-1: An update that has 9 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 933760,980263,980901,982379,983141,984494,984901,985674,986694
CVE References: 
Sources used:
openSUSE Leap 42.1 (src):    libsolv-0.6.22-12.1, libzypp-15.22.2-12.1, zypper-1.12.44-12.1