Bug 984945

Summary: zip doesn't check readdir return value
Product: [openSUSE] openSUSE 13.1 Reporter: Forgotten User zVnB049thN <forgotten_zVnB049thN>
Component: BasesystemAssignee: Kristyna Streitova <kstreitova>
Status: RESOLVED UPSTREAM QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: mpluskal
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 13.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Check readdir for errors

Description Forgotten User zVnB049thN 2016-06-15 22:54:52 UTC
Created attachment 680967 [details]
Check readdir for errors

zip doesn't check readdir return value, so it's possible for a zip that you're creating to be silently truncated when certain errors occur.

The attached patch added error checking for the unix generic platform only.
Comment 1 Chenzi Cao 2016-06-16 08:29:08 UTC
Hi Peter, thank you for your patch here! But openSUSE 13.1 doesn't get update any more. Would you like to check whether this issue is reproducible on a newer version product such as openSUSE Leap 42.1 or Tumbleweed? Thank you!

I assign this issue to zip maintainer now.
Comment 2 Forgotten User zVnB049thN 2016-06-16 09:21:51 UTC
Hi Chenzi,

Zip is one of these programs that doesn't change much. I don't have a OpenSuSE 13.2 system to play with, but I've just downloaded the 13.2 source package to verify that the issue is still present, and that the patch applies cleanly.

Peter
Comment 3 Martin Pluskal 2017-07-30 11:46:57 UTC
Not verified on supported distribution, and issue seems to be upstream one - please send patch for review to upstream instead
Comment 4 Karl Cheng 2018-03-19 00:01:10 UTC
*** Bug 984938 has been marked as a duplicate of this bug. ***