Bug 997193

Summary: rkhunter uses wrong OS_VERSION_FILE
Product: [openSUSE] openSUSE Tumbleweed Reporter: Arun Persaud <arun>
Component: SecurityAssignee: Sascha Manns <Sascha.Manns>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: astieger, forgotten_C0AhmtsDhy, meissner, security-team
Version: Current   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Arun Persaud 2016-09-04 22:58:57 UTC
The spec file uses /etc/SuSE-release for OS_VERSION_FILE, but on my Tumbleweed installation (current) this file doesn't exist anymore, instead I now seem to have /etc/SUSE-brand.

Noticed this because I'm getting complaints from rkhunter about this.
Comment 1 Andreas Stieger 2016-09-05 06:45:39 UTC
use /etc/os-release instead
Comment 2 Arun Persaud 2016-09-10 15:44:15 UTC
I guess this should be changed in the rkhunter.spec? but it probably needs a "if suse_version" or something to work on all versions. Not sure what to use there otherwise I could create a pull request for security:rkhunter
Comment 3 Forgotten User C0AhmtsDhy 2016-12-10 13:51:20 UTC
I'd also say this needs an update!

Fedora, Debian, openSUSE, SLES, Red Hat, they're all moving to /etc/os-release. SUSE have decided to get rid of the old SuSE-release already, and a package delivered for an OS that doesn't have this file and thus stops working is

- broken.


It's an easy fix, however. Parse the new file, be done with it. Could veen be that rkhunter already offers this, the package maintainers should check whether they've moved on and they need to adapt, or whether rkhunter in itself needs an update.
Comment 4 Marcus Meissner 2016-12-10 15:50:24 UTC
is already fixed since 25th october.

*** This bug has been marked as a duplicate of bug 1006382 ***
Comment 5 Forgotten User C0AhmtsDhy 2016-12-10 16:04:59 UTC
The mentioned bug has been closed, but within openSUSE-Leap-24.2-Oss this bug still exists.
Comment 6 Andreas Stieger 2016-12-10 17:36:32 UTC
(In reply to Harald Pfeiffer from comment #5)
> The mentioned bug has been closed

As a duplicate, yes. The resolution is and remains duplicate.

> but within openSUSE-Leap-24.2-Oss this bug still exists.

On 42.2: 
$ rpm -qf /etc/SuSE-release
openSUSE-release-42.2-1.150.x86_64

So no, not really.

*** This bug has been marked as a duplicate of bug 1006382 ***
Comment 7 Marcus Meissner 2016-12-10 17:53:24 UTC
FWIW I am just submitting tumbleweed rkhunter to 42.1 and 42.2 update to fix this.

There are some more open bugs, I will see if I can address them.
Comment 8 Forgotten User C0AhmtsDhy 2016-12-10 17:57:57 UTC
In fact, on my machine it was AdrianSuSE's Home Project mixing up things, it took Tumbleweed's SUSE-release package on my Leap... so sorry for mixing things up, and yes it looks it's only a Tumbleweed issue.

Might still be an idea to move away from /etc/SuSE-release (unless it won't be removed forever); but that's no bug here.