Bug 189283 - SuSEconfig.susehelp overwrites /etc/apache2/conf.d/susehelp.conf
Summary: SuSEconfig.susehelp overwrites /etc/apache2/conf.d/susehelp.conf
Status: RESOLVED WONTFIX
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Installation (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.1
: P4 - Low : Major (vote)
Target Milestone: ---
Assignee: Will Stephenson
QA Contact: Stanislav Visnovsky
URL:
Whiteboard:
Keywords: Code
Depends on:
Blocks:
 
Reported: 2006-06-29 13:08 UTC by Christian Eberl
Modified: 2007-05-07 14:17 UTC (History)
1 user (show)

See Also:
Found By: Customer
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Eberl 2006-06-29 13:08:52 UTC
After installing the help-system and setup the machine as documentation server (by setting DOC_SERVER="yes" in /etc/sysconfig/apache2.conf), I configured the parameter DOC_ALLOW="192.168.72.0/24 localhost" in /etc/sysconfig/susehelp. By running SuSEconfig the file /etc/apache2/conf.d/susehelp.conf shows up the new 'allowed hosts'. Running SuSEconfig again - w/o changes to DOC_ALLOW - the allowed hosts are restored to localhost.

I tracked down the problem to the script SuSEconfig.susehelp, where OLD_ALLOW and DOC_ALLOW are checked to prevent running sed useless, but it's always copied from the original in a DOC_SERVER="yes" configuration.

Below is a diff of the version I'm using, which works for me - but I'm not a shell programmer...


71,74c71
<       # only copy if changed
<       if [ "$OLD_ALLOW" != "$DOC_ALLOW" ] ; then
<         cp $httpdconf_working $apacheconfdir/susehelp.conf
<       fi
---
>       cp $httpdconf_working $apacheconfdir/susehelp.conf
Comment 1 Will Stephenson 2007-01-30 08:04:34 UTC
I'll review this shortly
Comment 2 Will Stephenson 2007-05-07 13:40:00 UTC
The diff is correct but since we have removed SuSEconfig.susehelp in 10.2 and later I won't fix this.  Do you need an online update for 10.1 for this?
Comment 3 Christian Eberl 2007-05-07 14:01:04 UTC
No, thank's. I've got it working for me (and update the box anyway in a short time).
Comment 4 Will Stephenson 2007-05-07 14:17:10 UTC
That's that then.  Thanks for the report.