Bug 197475 - Space wasted due to duplicate files (mostly in documentation)
Summary: Space wasted due to duplicate files (mostly in documentation)
Status: RESOLVED UPSTREAM
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Other (show other bugs)
Version: Final
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords: should_go_upstream
Depends on:
Blocks:
 
Reported: 2006-08-05 14:28 UTC by Stefan Brüns
Modified: 2008-08-14 20:46 UTC (History)
1 user (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Script for finding duplicates (956 bytes, application/x-perl)
2006-08-05 15:07 UTC, Stefan Brüns
Details
Proposed patch for gnome-doc-utils (1.27 KB, patch)
2006-08-16 19:24 UTC, Stefan Brüns
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Brüns 2006-08-05 14:28:42 UTC
There are a lot of files which get copied to different locations, e.g. some pngs for every language in a translation.

The attached perl script finds many of the offenders (although there are some false positives). It only checks for duplicate pngs.

IMHO when packaging a check should be run to test if one file gets installed to multiple locations (md5sum is calculated anyways), and a warning should be issued.

Affected packages: freeciv, gtkmm-devel, probaly any package using gnome-doc-utils
Comment 1 Stefan Brüns 2006-08-05 15:07:43 UTC
Created attachment 95310 [details]
Script for finding duplicates

run script with
zcat ARCHIVES.gz | find_duplicate_pngs.pl

(ARCHIVES.gz from DVD)
Comment 2 Michael Gross 2006-08-07 12:46:08 UTC
Reassigning to Gnome team.
Comment 3 JP Rosevear 2006-08-07 13:34:07 UTC
There are a bunch of kde files in the output as well, but I don't think its avoidable either because of the icon theme spec or it just needing to be fixed upstream.
Comment 4 Rodney Dawes 2006-08-07 14:28:55 UTC
This has nothing to do with the icon theme spec. A very small number of these though, are likely to be an icon installed to the hicolor theme, and one installed to the pixmaps dir, because the app may hardcode a path to the pixmaps directory icon, but we added icons in different sizes, and installed them to the theme, so we could have better app icons in the general desktop space.
Comment 5 Stefan Brüns 2006-08-16 19:18:26 UTC
Reopening.

1. gnome-doc-utils has a bug - it makes copies of every documentation image for every language if there is no "translated" image. There are a lot of images which are not "translatable" (e.g. symbols, toolbar buttons ...).
Patch attached

2. There are several other files in different packages, packages which have files several times. freeciv includes images in the documentation which are identical, but packaged for every theme. The same for the documentation html files. gtkmm2-devel has identical files under /usr/share/doc/packages/gtkmm2/{docs/reference|reference}/

3. Rerun the test program, but change .png for .html -> wasted space 30MB!

4. These are bugs which should be fixed upstream, but I am sure this happens all the time, so this should be tested on packaging: Two files, same size, same md5sum: BIG FAT WARNING
Comment 6 Stefan Brüns 2006-08-16 19:24:35 UTC
Created attachment 96283 [details]
Proposed patch for gnome-doc-utils

I am not sure if this fix is correct. I may be a better idea to not install a symlink, but let the help viewer find an alternative, eg: pt_BR pt_PT C.

Also it breaks any package using %find_languages - the script only looks for "-type f", not for "-type l".
Comment 7 JP Rosevear 2006-08-21 14:36:53 UTC
Please file this in bugzilla.gnome.org and get feedback on the patch there first.  Put a link to b.g.o bug here so we can follow it.

Thanks for the patch!
Comment 8 Stefan Brüns 2006-08-22 14:53:19 UTC
Done ...
http://bugzilla.gnome.org/show_bug.cgi?id=352405

Please be aware that gdu is only number 1 in #5 , there are three other points as well. I will file 2. against gtkmm2 and freeciv, but there are more packages doing bad things, and IMHO the only solution to this problem is 4.
Comment 9 JP Rosevear 2007-02-09 21:53:51 UTC
Waiting for upstream based on comments there.
Comment 10 Stephan Kulow 2008-06-25 09:40:09 UTC
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 11 Stephan Kulow 2008-06-25 09:41:07 UTC
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 12 Stephan Kulow 2008-06-25 09:43:45 UTC
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 13 Stephan Kulow 2008-06-25 09:56:43 UTC
Closing old LATER+REMIND bugs as WONTFIX - if you still plan to work on it, feel free to reopen and set to ASSIGNED.

In case the report saw repeated reopen comments, it's due to bugzilla timing out on the huge request ;(
Comment 14 JP Rosevear 2008-08-14 20:26:58 UTC
Update resolution to UPSTREAM.
Comment 15 JP Rosevear 2008-08-14 20:46:36 UTC
Really update.