Bug 225904 - goobox-0.9.93-43: comparison with string literal
Summary: goobox-0.9.93-43: comparison with string literal
Status: RESOLVED DUPLICATE of bug 233655
Alias: None
Product: openSUSE 10.2
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: RC 5
Hardware: All SUSE Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Joe Hargadon
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-04 21:38 UTC by David Binderman
Modified: 2007-01-18 16:55 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-12-04 21:38:31 UTC 
I just tried to build the package goobox-0.9.93-43

I got the following warning message from the compiler.

dlg-ripper.c:368: warning: comparison with string literal

The source code is

                if ((scheme == NULL) || (scheme == ""))

I agree with the compiler. Maybe the programmer intended

                if ((scheme == NULL) || (scheme[0] == '\0'))
Comment 1 Stefan Dirsch 2007-01-16 22:30:34 UTC 
Feel free to close as duplicate of Bug #233655.
Comment 2 Joe Hargadon 2007-01-18 16:55:02 UTC 

*** This bug has been marked as a duplicate of bug 233655 ***