Bug 229785 - bbtools-gui-2006.1.25-42: comparison with string literal
Summary: bbtools-gui-2006.1.25-42: comparison with string literal
Status: RESOLVED DUPLICATE of bug 233655
Alias: None
Product: openSUSE 10.3
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SUSE Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Hendrik Vogelsang
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-19 21:35 UTC by David Binderman
Modified: 2007-07-03 15:14 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-12-19 21:35:46 UTC 
I just tried to compile package bbtools-gui-2006.1.25-42

The compiler said

bbrun.c:325: warning: comparison with string literal

The source code is

  if ((char *) data == "ok")

Suggest new code

  if (strcmp( (char *) data, "ok") == 0)
Comment 1 Stefan Dirsch 2007-01-16 22:30:36 UTC 
Feel free to close as duplicate of Bug #233655.
Comment 2 Hendrik Vogelsang 2007-07-03 15:14:35 UTC 

*** This bug has been marked as a duplicate of bug 233655 ***