231180 – gthumb-2.7.9-32: comparison with string literal

Bug 231180 - gthumb-2.7.9-32: comparison with string literal

Summary: gthumb-2.7.9-32: comparison with string literal

Status:	RESOLVED DUPLICATE of bug 233655

Alias:	None

Product:	openSUSE 10.3
Classification:	openSUSE
Component:	Basesystem (show other bugs)
Version:	unspecified
Hardware:	All SUSE Other

Priority:	P5 - None Severity: Normal (vote)
Target Milestone:	---
Assignee:	Joe Hargadon
QA Contact:	E-mail List

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Clone This Bug

Reported:	2006-12-30 20:28 UTC by David Binderman
Modified:	2007-01-18 16:54 UTC (History)
CC List:	0 users

See Also:
Found By:	Other
Services Priority:
Business Priority:
Blocker:	---
Marketing QA Status:	---
IT Deployment:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Binderman 2006-12-30 20:28:57 UTC

I just tried to compile package gthumb-2.7.9-32

The compiler said

file-utils.c:1143: warning: comparison with string literal

The source code is

        if ((path == "") || (path[0] == '/'))

Suggest new code

        if ((path[ 0] == 0) || (path[0] == '/'))

Comment 1 JP Rosevear 2007-01-03 13:23:51 UTC

Joe, you'll have to check the code to see what the right fix is, could be path == NULL or path[0] == '\0' as well depending.

Comment 2 Stefan Dirsch 2007-01-16 22:30:36 UTC

Feel free to close as duplicate of Bug #233655.

Comment 3 Joe Hargadon 2007-01-18 16:54:31 UTC


*** This bug has been marked as a duplicate of bug 233655 ***